1. 09 11月, 2011 9 次提交
  2. 08 11月, 2011 3 次提交
  3. 07 11月, 2011 5 次提交
  4. 06 11月, 2011 3 次提交
  5. 05 11月, 2011 1 次提交
    • S
      http: don't always prompt for password · 986bbc08
      Stefan Naewe 提交于
      When a username is already specified at the beginning of any HTTP
      transaction (e.g. "git push https://user@hosting.example.com/project.git"
      or "git ls-remote https://user@hosting.example.com/project.git"), the code
      interactively asks for a password before calling into the libcurl library.
      It is very likely that the reason why user included the username in the
      URL is because the user knows that it would require authentication to
      access the resource. Asking for the password upfront would save one
      roundtrip to get a 401 response, getting the password and then retrying
      the request. This is a reasonable optimization.
      
      HOWEVER.
      
      This is done even when $HOME/.netrc might have a corresponding entry to
      access the site, or the site does not require authentication to access the
      resource after all. But neither condition can be determined until we call
      into libcurl library (we do not read and parse $HOME/.netrc ourselves). In
      these cases, the user is forced to respond to the password prompt, only to
      give a password that is not used in the HTTP transaction. If the password
      is in $HOME/.netrc, an empty input would later let the libcurl layer to
      pick up the password from there, and if the resource does not require
      authentication, any input would be taken and then discarded without
      getting used. It is wasteful to ask this unused information to the end
      user.
      
      Reduce the confusion by not trying to optimize for this case and always
      incur roundtrip penalty. An alternative might be to document this and keep
      this round-trip optimization as-is.
      Signed-off-by: NStefan Naewe <stefan.naewe@gmail.com>
      Helped-by: NJeff King <peff@peff.net>
      Signed-off-by: NJunio C Hamano <gitster@pobox.com>
      986bbc08
  6. 04 11月, 2011 1 次提交
  7. 03 11月, 2011 2 次提交
  8. 02 11月, 2011 16 次提交