1. 25 2月, 2007 1 次提交
    • J
      Don't modify CREDITS-FILE if it hasn't changed. · 92446aba
      Junio C Hamano 提交于
      We should always avoid rewriting a built file during `make install`
      if nothing has changed since `make all`.  This is to help support
      the typical installation process of compiling a package as yourself,
      then installing it as root.
      
      Forcing CREDITS-FILE to be always be rebuilt in the Makefile means
      that CREDITS-GEN needs to check for a change and only update
      CREDITS-FILE if the file content actually differs.  After all,
      content is king in Git.
      Signed-off-by: NJunio C Hamano <junkio@cox.net>
      Signed-off-by: NShawn O. Pearce <spearce@spearce.org>
      92446aba
  2. 21 2月, 2007 6 次提交
  3. 18 2月, 2007 1 次提交
    • S
      git-gui: Correct crash when saving options in blame mode. · 372ef954
      Shawn O. Pearce 提交于
      Martin Waitz noticed that git-gui crashed while saving the user's
      options out if the application was started in blame mode.  This
      was caused by the do_save_config procedure invoking reshow_diff
      incase the number of context lines was modified by the user.
      Because we bypassed main window UI setup to enter blame mode we
      did not set many of the globals which were accessed by reshow_diff,
      and reading unset variables is an error in Tcl.
      
      Aside from moving the globals to be set earlier, I also modified
      reshow_diff to not invoke clear_diff if there is no path currently
      in the diff viewer.  This way reshow_diff does not crash when in
      blame mode due to the $ui_diff command not being defined.
      Signed-off-by: NShawn O. Pearce <spearce@spearce.org>
      372ef954
  4. 16 2月, 2007 1 次提交
  5. 15 2月, 2007 1 次提交
  6. 14 2月, 2007 6 次提交
    • S
      git-gui: Prefer version file over git-describe. · 26370f73
      Shawn O. Pearce 提交于
      Some distributions are using Git for part of their package
      management system, but unpack Git's own source code for
      delivery from the .tar.gz.  This means that when we walk
      up the directory tree with git-describe to locate a Git
      repository, the repository we find is for the distribution
      and *not* for git-gui.  Consequently any tag we might find
      there is bogus and does not apply to us.
      
      In this case the version file should always exist and be
      readable, as the packager is working from the released
      .tar.gz sources.  So we should always favor the version
      file over anything git-describe guess for us.
      Signed-off-by: NShawn O. Pearce <spearce@spearce.org>
      26370f73
    • S
      git-gui: Print version on the console. · ed3adde0
      Shawn O. Pearce 提交于
      Like `git version`, `git gui version` (or `git gui --version`) shows
      the version of git-gui, in case the user needs to know this, without
      looking at it in the GUI about dialog.
      Signed-off-by: NShawn O. Pearce <spearce@spearce.org>
      ed3adde0
    • S
      git-gui: More consistently display the application name. · 5ac58f5b
      Shawn O. Pearce 提交于
      I started to find it confusing that git-gui would refer to itself
      as git-citool when it was started through the citool hardlink, or
      with the citool subcommand.  What was especially confusing was the
      options dialog and the about dialog, as both seemed to imply they
      were somehow different from the git-gui versions.  In actuality
      there is no difference at all.
      
      Now we just call our options menu item 'Options...' (skipping the
      application name) and our About dialog now always shows git-gui
      within the short description (above the copyleft notice) and in
      the version field.
      Signed-off-by: NShawn O. Pearce <spearce@spearce.org>
      5ac58f5b
    • S
      git-gui: Permit merging tags into the current branch. · cdf6e088
      Shawn O. Pearce 提交于
      It was pointed out on the git mailing list by Martin Koegler that
      we did not show tags as possible things to merge into the current
      branch.  They actually are, and core Git's Grand Unified Merge
      Driver will accept them just like any other commit.
      
      So our merge dialog now requests all refs/heads, refs/remotes and
      refs/tags named refs and attempts to match them against the commits
      not in HEAD.  One complicating factor here is that we must use the
      %(*objectname) field when talking about an annotated tag, as they
      will not appear in the output of rev-list.
      Signed-off-by: NShawn O. Pearce <spearce@spearce.org>
      cdf6e088
    • S
      git-gui: Basic version check to ensure git 1.5.0 or later is used. · 54acdd95
      Shawn O. Pearce 提交于
      This is a very crude (but hopefully effective) check against the
      `git` executable found in our PATH.  Some of the subcommands and
      options that git-gui requires to be present to operate were created
      during the 1.5.0 development cycle, so 1.5 is the minimum version
      of git that we can expect to support.
      
      There actually are early releases of 1.5 (e.g. 1.5.0-rc0) that
      don't have everything we expect (like `blame --incremental`) but
      these are purely academic at this point.  1.5.0 final was tagged
      and released just a few hours ago.  The release candidates will
      (hopefully) fade into the dark quickly.
      Signed-off-by: NShawn O. Pearce <spearce@spearce.org>
      54acdd95
    • S
      git-gui: Refactor 'exec git subcmd' idiom. · 81347223
      Shawn O. Pearce 提交于
      As we frequently need to execute a Git subcommand and obtain
      its returned output we are making heavy use of [exec git foo]
      to run foo.  As I'm concerned about possibly needing to carry
      environment data through a shell on Cygwin for at least some
      subcommands, I'm migrating all current calls to a new git
      proc.  This actually makes the code look cleaner too, as
      we aren't saying 'exec git' everywhere.
      Signed-off-by: NShawn O. Pearce <spearce@spearce.org>
      81347223
  7. 13 2月, 2007 7 次提交
  8. 12 2月, 2007 1 次提交
  9. 09 2月, 2007 14 次提交
    • S
      git-gui: Focus into blame panels on Mac OS. · d585e782
      Shawn O. Pearce 提交于
      Signed-off-by: NShawn O. Pearce <spearce@spearce.org>
      d585e782
    • S
      git-gui: Improve annotated file display. · 486ef527
      Shawn O. Pearce 提交于
      Rather than trying to mark the background color of the line numbers
      to show which lines have annotated data loaded, we now show a ruler
      between the line numbers and the file data.  This ruler is just 1
      character wide and its background color is set to grey to denote
      which lines have annotation ready.  I had to make this change as I
      kept loosing the annotation marker when a line was no longer colored
      as part of the current selection.
      
      We now color the lines blamed on the current commit in yellow, the
      lines in the commit which came after (descendant) in red (hotter,
      less tested) and the lines in the commit before (ancestor) in blue
      (cooler, better tested).
      Signed-off-by: NShawn O. Pearce <spearce@spearce.org>
      486ef527
    • S
      git-gui: Jump to the first annotation block as soon as its available. · 1351ba13
      Shawn O. Pearce 提交于
      To help clue users into the fact that annotation data arrives
      incrementally, and that they should try to locate the region
      they want while the tool is running, we jump to the first line
      of the first annotation if the user has not already clicked on
      a line they are interested in and if the window is still looking
      at the very top of the file.
      
      Since it takes a second (at least on my PowerBook) to even generate
      the first annotation for git-gui.sh, the user should have plenty of
      time to adjust the scrollbar or click on a line even before we get
      that first annotation record in, which allows the user to bypass
      our automatic jumping.
      Signed-off-by: NShawn O. Pearce <spearce@spearce.org>
      1351ba13
    • S
      git-gui: Redesign the display of annotated files. · 6910ae80
      Shawn O. Pearce 提交于
      Using 180 columns worth of screen space to display just 20 columns of
      file data and 160 columns worth of annotation information is not
      practically useful.  Users need/want to see the file data, and have
      the anotation associated with it displayed in a detail pane only when
      they have focused on a particular region of the file.
      
      Now our file viewer has a small 10-line high pane below the file
      which shows the commit message for the commit this line was blamed
      on.  The columns have all been removed, except the current line
      number column as that has some real value when trying to locate an
      interesting block.
      
      To keep the user entertained we have a progress meter in the status
      bar of the viewer which lets them know how many lines have been
      annotated, and how much has been completed.  We use a grey background
      on the line numbers for lines which we have obtained annotation from,
      and we color all lines in the current commit with a yellow background,
      so they stand out when scanning through the file.  All other lines
      are kept with a white background, making the yellow really pop.
      Signed-off-by: NShawn O. Pearce <spearce@spearce.org>
      6910ae80
    • S
      git-gui: Use git-config now over git-repo-config. · df6287ec
      Shawn O. Pearce 提交于
      Now that core Git has "renamed" git-repo-config to git-config,
      we should do the same.  I don't know how long core Git will
      keep the repo-config command, and since git-gui's userbase
      is so small and almost entirely on some flavor of 1.5.0-rc2
      or later, where the rename has already taken place, it should
      be OK to rename now.
      Signed-off-by: NShawn O. Pearce <spearce@spearce.org>
      df6287ec
    • S
      git-gui: Relabel the Add All action. · 24d2bf2f
      Shawn O. Pearce 提交于
      One user that I spoke with recently was confused why the 'Add All'
      button did not add all of his 'Changed But Not Updated' files.
      The particular files in question were new, and thus not known to
      Git.  Since the 'Add All' routine only updates files which are
      already tracked, they were not added automatically.
      
      I suspect that calling this action 'Add Existing' would be less
      confusing, so I'm renaming it.
      Signed-off-by: NShawn O. Pearce <spearce@spearce.org>
      24d2bf2f
    • S
      git-gui: Select subcommands like git does. · 258871d3
      Shawn O. Pearce 提交于
      If we are invoked as `git-foo`, then we should run the `foo` subcommand,
      as the user has made some sort of link from `git-foo` to our actual
      program code.  So we should honor their request.
      
      If we are invoked as `git-gui foo`, the user has not made a link (or
      did, but is not using it right now) so we should execute the `foo`
      subcommand.
      
      We now can start the single commit UI mode via `git-citool` and also
      through `git gui citool`.
      Signed-off-by: NShawn O. Pearce <spearce@spearce.org>
      258871d3
    • S
      git-gui: View blame from the command line. · 2ebba528
      Shawn O. Pearce 提交于
      Viewing annotated files is one of those tasks that is relatively
      difficult to do in a simple vt100 terminal emulator.  The user
      really wants to be able to browse through a lot of information,
      and to interact with it by navigating through revisions.
      
      Now users can start our file viewer with annotations by running
      'git gui blame commit path', thereby seeing the contents of the
      given file at the given commit.  Right now I am being lazy by
      not allowing the user to omit the commit name (and have us thus
      assume HEAD).
      Signed-off-by: NShawn O. Pearce <spearce@spearce.org>
      2ebba528
    • S
      git-gui: Optionally save commit buffer on exit. · db7f34d4
      Shawn O. Pearce 提交于
      If the commit area does not exist, don't save the commit message to
      a file, or the window geometry.  The reason I'm doing this is I want
      to make the main window entirely optional, such as if the user has
      asked us to show a blame from the command line.  In such cases the
      commit area won't exist and trying to get its text would cause an
      error.
      
      If we are running without the commit message area, we cannot save
      our window geometry either, as the root window '.' won't be a normal
      commit window.
      Signed-off-by: NShawn O. Pearce <spearce@spearce.org>
      db7f34d4
    • S
      git-gui: Separate transport/branch menus from multicommit. · 64a906f8
      Shawn O. Pearce 提交于
      These are now controlled by the transport and branch options, rather
      than the multicommit option.
      Signed-off-by: NShawn O. Pearce <spearce@spearce.org>
      64a906f8
    • S
      git-gui: Refactor single_commit to a proc. · cf25ddc8
      Shawn O. Pearce 提交于
      This is a minor code cleanup to make working with what used to be the
      $single_commit flag easier.  Its also to better handle various UI
      configurations, depending on command line parameters given by the
      user, or perhaps user preferences.
      Signed-off-by: NShawn O. Pearce <spearce@spearce.org>
      cf25ddc8
    • S
      git-gui: Replace \ with \\ when showing paths. · 42b922fc
      Shawn O. Pearce 提交于
      We already replace \n with \\n so that Tk widgets don't start a new
      display line with part of a file path which is just unlucky enough
      to contain an LF.  But then its confusing to read a path whose name
      actually contains \n as literal characters.  Escaping \ to \\ would
      make that case display as \\n, clarifying the output.
      Signed-off-by: NShawn O. Pearce <spearce@spearce.org>
      42b922fc
    • S
      git-gui: Support keyboard traversal in browser. · 9bccb782
      Shawn O. Pearce 提交于
      Users want to navigate the file list shown in our branch browser
      windows using the keyboard.  So we now support basic traversal
      with the arrow keys:
      
        Up/Down:  Move the "selection bar" to focus on a different name.
      
        Return:   Move into the subtree, or open the annotated file.
        M1-Right: Ditto.
      
        M1-Up:    Move to the parent tree.
        M1-Left:  Ditto.
      
      Probably the only feature missing from this is to key a leading part
      of the file name and jump directly to that file (or subtree).
      
      This change did require a bit of refactoring, to pull the navigation
      logic out of the mouse click procedure and into more generic routines
      which can also be used in bindings.
      Signed-off-by: NShawn O. Pearce <spearce@spearce.org>
      9bccb782
    • S
      git-gui: Update known branches during rescan. · 63faf4df
      Shawn O. Pearce 提交于
      If the user has created (or deleted) a branch through an external tool,
      and uses Rescan, they probably are trying to make git-gui update to show
      their newly created branch.
      
      So now we load all known heads and update the branch menu during any
      rescan operation, just in-case the set of known branches was modified.
      Signed-off-by: NShawn O. Pearce <spearce@spearce.org>
      63faf4df
  10. 29 1月, 2007 2 次提交
    • S
      git-gui: Assign background colors to each blame hunk. · 37f1db80
      Shawn O. Pearce 提交于
      To help the user visually see which lines are associated with each other
      in the file we attempt to sign a unique background color to each commit
      and then render all text associated with that commit using that color.
      
      This works out OK for a file which has very few commits in it; but
      most files don't have that property.
      
      What we really need to do is look at what colors are used by our
      neighboring commits (if known yet) and pick a color which does not
      conflict with our neighbor.  If we have run out of colors then we
      should force our neighbor to recolor too.  Yes, its the graph coloring
      problem.
      Signed-off-by: NShawn O. Pearce <spearce@spearce.org>
      37f1db80
    • S
      git-gui: Use a grid layout for the blame viewer. · 747c0cf9
      Shawn O. Pearce 提交于
      Using a panedwindow to display the blame viewer's individual columns
      just doesn't make sense.  Most of the important data fits within the
      columns we have allocated, and those that don't the leading part fits
      and that's good enough.  There are just too many columns within this
      viewer to let the user sanely control individual column widths.  This
      change shouldn't really be an issue for most git-gui users as their
      displays should be large enough to accept this massive dump of data.
      
      We now also have a properly working horizontal scrollbar for the
      current file data area.  This makes it easier to get away with a
      narrow window when screen space is limited, as you can still scroll
      around within the file content.
      Signed-off-by: NShawn O. Pearce <spearce@spearce.org>
      747c0cf9