1. 19 10月, 2012 2 次提交
    • J
      filter-branch: use git-sh-setup's ident parsing functions · 3c730fab
      Jeff King 提交于
      This saves us some code, but it also reduces the number of
      processes we start for each filtered commit. Since we can
      parse both author and committer in the same sed invocation,
      we save one process. And since the new interface avoids tr,
      we save 4 processes.
      
      It also avoids using "tr", which has had some odd
      portability problems reported with from Solaris's xpg6
      version.
      
      We also tweak one of the tests in t7003 to double-check that
      we are properly exporting the variables (because test-lib.sh
      exports GIT_AUTHOR_NAME, it will be automatically exported
      in subprograms. We override this to make sure that
      filter-branch handles it properly itself).
      Signed-off-by: NJeff King <peff@peff.net>
      Signed-off-by: NJunio C Hamano <gitster@pobox.com>
      3c730fab
    • J
      git-sh-setup: refactor ident-parsing functions · ce80ca56
      Jeff King 提交于
      The only ident-parsing function we currently provide is
      get_author_ident_from_commit. This is not very
      flexible for two reasons:
      
        1. It takes a commit as an argument, and can't read from
           commit headers saved on disk.
      
        2. It will only parse authors, not committers.
      
      This patch provides a more flexible interface which will
      parse multiple idents from a commit provide on stdin. We can
      easily use it as a building block for the current function
      to retain compatibility.
      Signed-off-by: NJeff King <peff@peff.net>
      Signed-off-by: NJunio C Hamano <gitster@pobox.com>
      ce80ca56
  2. 18 10月, 2012 15 次提交
  3. 17 10月, 2012 6 次提交
  4. 16 10月, 2012 3 次提交
  5. 15 10月, 2012 1 次提交
  6. 14 10月, 2012 2 次提交
  7. 13 10月, 2012 2 次提交
    • J
      Merge branch 'maint' · fc364c76
      Junio C Hamano 提交于
      * maint:
        gitweb.cgi: fix "comitter_tz" typo in feed
      fc364c76
    • J
      http: fix segfault in handle_curl_result · 188923f0
      Jeff King 提交于
      When we create an http active_request_slot, we can set its
      "results" pointer back to local storage. The http code will
      fill in the details of how the request went, and we can
      access those details even after the slot has been cleaned
      up.
      
      Commit 88097030 (http: factor out http error code handling)
      switched us from accessing our local results struct directly
      to accessing it via the "results" pointer of the slot. That
      means we're accessing the slot after it has been marked as
      finished, defeating the whole purpose of keeping the results
      storage separate.
      
      Most of the time this doesn't matter, as finishing the slot
      does not actually clean up the pointer. However, when using
      curl's multi interface with the dumb-http revision walker,
      we might actually start a new request before handing control
      back to the original caller. In that case, we may reuse the
      slot, zeroing its results pointer, and leading the original
      caller to segfault while looking for its results inside the
      slot.
      
      Instead, we need to pass a pointer to our local results
      storage to the handle_curl_result function, rather than
      relying on the pointer in the slot struct. This matches what
      the original code did before the refactoring (which did not
      use a separate function, and therefore just accessed the
      results struct directly).
      Signed-off-by: NJeff King <peff@peff.net>
      Signed-off-by: NJunio C Hamano <gitster@pobox.com>
      188923f0
  8. 12 10月, 2012 2 次提交
  9. 11 10月, 2012 7 次提交
    • J
      Merge branch 'rr/git-uri-doc' · c5fe2398
      Junio C Hamano 提交于
      * rr/git-uri-doc:
        Git url doc: mark ftp/ftps as read-only and deprecate them
      c5fe2398
    • J
      Merge branch 'bw/cp-a-is-gnuism' · b7804cf2
      Junio C Hamano 提交于
      * bw/cp-a-is-gnuism:
        tests: "cp -a" is a GNUism
      b7804cf2
    • J
      Merge branch 'nd/doc-ignore' · 4321fe0b
      Junio C Hamano 提交于
      * nd/doc-ignore:
        gitignore.txt: suggestions how to get literal # or ! at the beginning
      4321fe0b
    • J
      Merge branch 'jc/doc-long-options' · 01150423
      Junio C Hamano 提交于
      * jc/doc-long-options:
        gitcli: parse-options lets you omit tail of long options
      01150423
    • J
      Sync with maint · 8d47dc7f
      Junio C Hamano 提交于
      * maint:
        attr: a note about the order of .gitattributes lookup
      8d47dc7f
    • J
      Merge git://bogomips.org/git-svn · d5e7c0c2
      Junio C Hamano 提交于
      * git://bogomips.org/git-svn:
        svn test: escape peg revision separator using empty peg rev
        git svn: work around SVN 1.7 mishandling of svn:special changes
      d5e7c0c2
    • J
      svn test: escape peg revision separator using empty peg rev · 44bc5ac7
      Jonathan Nieder 提交于
      This test script uses "svn cp" to create a branch with an @-sign in
      its name:
      
      	svn cp "pr ject/trunk" "pr ject/branches/not-a@{0}reflog"
      
      That sets up for later tests that fetch the branch and check that git
      svn mangles the refname appropriately.
      
      Unfortunately, modern svn versions interpret path arguments with an
      @-sign as an example of path@revision syntax (which pegs a path to a
      particular revision) and truncate the path or error out with message
      "svn: E205000: Syntax error parsing peg revision '{0}reflog'".
      
      When using subversion 1.6.x, escaping the @ sign as %40 avoids trouble
      (see 08fd28bb, 2010-07-08).  Newer versions are stricter:
      
      	$ svn cp "$repo/pr ject/trunk" "$repo/pr ject/branches/not-a%40{reflog}"
      	svn: E205000: Syntax error parsing peg revision '%7B0%7Dreflog'
      
      The recommended method for escaping a literal @ sign in a path passed
      to subversion is to add an empty peg revision at the end of the path
      ("branches/not-a@{0}reflog@").  Do that.
      
      Pre-1.6.12 versions of Subversion probably treat the trailing @ as
      another literal @-sign (svn issue 3651).  Luckily ever since
      v1.8.0-rc0~155^2~7 (t9118: workaround inconsistency between SVN
      versions, 2012-07-28) the test can survive that.
      
      Tested with Debian Subversion 1.6.12dfsg-6 and 1.7.5-1 and r1395837
      of Subversion trunk (1.8.x).
      Signed-off-by: NJonathan Nieder <jrnieder@gmail.com>
      Tested-by: NMichael J Gruber <git@drmicha.warpmail.net>
      Signed-off-by: NEric Wong <normalperson@yhbt.net>
      44bc5ac7