1. 18 2月, 2008 8 次提交
    • M
      24e8a3c9
    • M
      affeef12
    • C
    • J
      Merge branch 'br/gitweb' · a8f6b201
      Junio C Hamano 提交于
      * br/gitweb:
        gitweb: Use the config file to set repository owner's name.
      a8f6b201
    • J
      gitweb: Add new option -nohtml to quot_xxx subroutines · c84c483f
      Jakub Narebski 提交于
      Add support for new option -nohtml to quot_cec and quot_upr
      subroutines, to have output not wrapped in HTML tags.  This makes
      those subroutines suitable to quoting attributes values, and for plain
      text output quoting.  Currently this API is not used yet.
      
      While at it fix whitespace, and use ';' as delimiter, not separator.
      
      The option to not wrap quot_cec output in HTML tag were proposed
      originally in patch:
        "Don't open a XML tag while another one is already open"
        Message-ID: <20080216191628.GK30676@schiele.dyndns.org>
      by Robert Schiele.  Originally the parameter was named '-notag', was
      also supportted by esc_html (but not esc_path) which passed it down to
      quot_cec.  Mentioned patch was meant to fix the bug Martin Koegler
      reported in his mail
        "Invalid html output repo.or.cz (alt-git.git)"
        Message-ID: <20080216130037.GA14571@auto.tuwien.ac.at>
      which was fixed in different way (do not use esc_html to escape and
      quote HTML attributes).
      Signed-off-by: NRobert Schiele <rschiele@gmail.com>
      Signed-off-by: NJakub Narebski <jnareb@gmail.com>
      Signed-off-by: NJunio C Hamano <gitster@pobox.com>
      c84c483f
    • J
      gitweb: Fix displaying unchopped argument in chop_and_escape_str · 850b90a5
      Jakub Narebski 提交于
      Do not use esc_html to escape [title] _attribute_ of a HTML element,
      and quote unprintable characters.  Replace unprintable characters by
      '?' and use CGI method to generate HTML element and do the escaping.
      
      This caused bug noticed by Martin Koegler,
        Message-ID: <20080216130037.GA14571@auto.tuwien.ac.at>
      that for bad commit encoding in author name, the title attribute (here
      to show full, not shortened name) had embedded HTML code in it, result
      of quoting unprintable characters the gitweb/HTML way. This of course
      broke the HTML, causing page being not displayed in XML validating web
      browsers.
      Signed-off-by: NJakub Narebski <jnareb@gmail.com>
      Signed-off-by: NJunio C Hamano <gitster@pobox.com>
      850b90a5
    • J
      bisect view: check for MinGW32 and MacOSX in addition to X11 · 508e84a7
      Johannes Schindelin 提交于
      When deciding if gitk or git-log should be used to visualize the current
      state, the environment variable DISPLAY was checked.  Now, we check
      MSYSTEM (for MinGW32/MSys) and SECURITYSESSIONID (for MacOSX) in addition.
      
      Note that there is currently no way to ssh into MinGW32, and that
      SECURITYSESSIONID is not set automatically on MacOSX when ssh'ing into it.
      So this patch should be safe.
      Signed-off-by: NJohannes Schindelin <johannes.schindelin@gmx.de>
      Signed-off-by: NJunio C Hamano <gitster@pobox.com>
      508e84a7
    • J
      sending errors to stdout under $PAGER · 61b80509
      Junio C Hamano 提交于
      If you do this (and you are not an Emacs user who uses PAGER=cat
      in your *shell* buffer):
      
              $ git init
              Initialized empty Git repository in .git/
              $ echo hello world >foo
              $ H=$(git hash-object -w foo)
              $ git tag -a foo-tag -m "Tags $H" $H
              $ echo $H
              3b18e512dba79e4c8300dd08aeb37f8e728b8dad
              $ rm -f .git/objects/3b/18e5*
              $ git show foo-tag
              tag foo-tag
              Tagger: Junio C Hamano <gitster@pobox.com>
              Date:   Sat Feb 16 10:43:23 2008 -0800
      
              Tags 3b18e512dba79e4c8300dd08aeb37f8e728b8dad
      
      you do not get any indication of error.  If you are careful, you
      would notice that no contents from the tagged object is
      displayed, but that is about it.  If you run the "show" command
      without pager, however, you will see the error:
      
              $ git --no-pager show foo-tag
              tag foo-tag
              Tagger: Junio C Hamano <gitster@pobox.com>
              Date:   Sat Feb 16 10:43:23 2008 -0800
      
              Tags 3b18e512dba79e4c8300dd08aeb37f8e728b8dad
              error: Could not read object 3b18e512dba79e4c8300dd08aeb37f8e728b8dad
      
      Because we spawn the pager as the foreground process and feed
      its input via pipe from the real command, we cannot affect the
      exit status the shell sees from git command when the pager is in
      use (I think there is not much gain we can have by working it
      around, though).  But at least it may make sense to show the
      error message to the user sitting in front of the pager.
      
      [jc: Edgar Toernig suggested a much nicer implementation than
      what I originally posted, which I took.]
      Signed-off-by: NJunio C Hamano <gitster@pobox.com>
      61b80509
  2. 17 2月, 2008 17 次提交
  3. 16 2月, 2008 15 次提交