1. 09 2月, 2007 12 次提交
    • S
      git-gui: Jump to the first annotation block as soon as its available. · 1351ba13
      Shawn O. Pearce 提交于
      To help clue users into the fact that annotation data arrives
      incrementally, and that they should try to locate the region
      they want while the tool is running, we jump to the first line
      of the first annotation if the user has not already clicked on
      a line they are interested in and if the window is still looking
      at the very top of the file.
      
      Since it takes a second (at least on my PowerBook) to even generate
      the first annotation for git-gui.sh, the user should have plenty of
      time to adjust the scrollbar or click on a line even before we get
      that first annotation record in, which allows the user to bypass
      our automatic jumping.
      Signed-off-by: NShawn O. Pearce <spearce@spearce.org>
      1351ba13
    • S
      git-gui: Redesign the display of annotated files. · 6910ae80
      Shawn O. Pearce 提交于
      Using 180 columns worth of screen space to display just 20 columns of
      file data and 160 columns worth of annotation information is not
      practically useful.  Users need/want to see the file data, and have
      the anotation associated with it displayed in a detail pane only when
      they have focused on a particular region of the file.
      
      Now our file viewer has a small 10-line high pane below the file
      which shows the commit message for the commit this line was blamed
      on.  The columns have all been removed, except the current line
      number column as that has some real value when trying to locate an
      interesting block.
      
      To keep the user entertained we have a progress meter in the status
      bar of the viewer which lets them know how many lines have been
      annotated, and how much has been completed.  We use a grey background
      on the line numbers for lines which we have obtained annotation from,
      and we color all lines in the current commit with a yellow background,
      so they stand out when scanning through the file.  All other lines
      are kept with a white background, making the yellow really pop.
      Signed-off-by: NShawn O. Pearce <spearce@spearce.org>
      6910ae80
    • S
      git-gui: Use git-config now over git-repo-config. · df6287ec
      Shawn O. Pearce 提交于
      Now that core Git has "renamed" git-repo-config to git-config,
      we should do the same.  I don't know how long core Git will
      keep the repo-config command, and since git-gui's userbase
      is so small and almost entirely on some flavor of 1.5.0-rc2
      or later, where the rename has already taken place, it should
      be OK to rename now.
      Signed-off-by: NShawn O. Pearce <spearce@spearce.org>
      df6287ec
    • S
      git-gui: Relabel the Add All action. · 24d2bf2f
      Shawn O. Pearce 提交于
      One user that I spoke with recently was confused why the 'Add All'
      button did not add all of his 'Changed But Not Updated' files.
      The particular files in question were new, and thus not known to
      Git.  Since the 'Add All' routine only updates files which are
      already tracked, they were not added automatically.
      
      I suspect that calling this action 'Add Existing' would be less
      confusing, so I'm renaming it.
      Signed-off-by: NShawn O. Pearce <spearce@spearce.org>
      24d2bf2f
    • S
      git-gui: Select subcommands like git does. · 258871d3
      Shawn O. Pearce 提交于
      If we are invoked as `git-foo`, then we should run the `foo` subcommand,
      as the user has made some sort of link from `git-foo` to our actual
      program code.  So we should honor their request.
      
      If we are invoked as `git-gui foo`, the user has not made a link (or
      did, but is not using it right now) so we should execute the `foo`
      subcommand.
      
      We now can start the single commit UI mode via `git-citool` and also
      through `git gui citool`.
      Signed-off-by: NShawn O. Pearce <spearce@spearce.org>
      258871d3
    • S
      git-gui: View blame from the command line. · 2ebba528
      Shawn O. Pearce 提交于
      Viewing annotated files is one of those tasks that is relatively
      difficult to do in a simple vt100 terminal emulator.  The user
      really wants to be able to browse through a lot of information,
      and to interact with it by navigating through revisions.
      
      Now users can start our file viewer with annotations by running
      'git gui blame commit path', thereby seeing the contents of the
      given file at the given commit.  Right now I am being lazy by
      not allowing the user to omit the commit name (and have us thus
      assume HEAD).
      Signed-off-by: NShawn O. Pearce <spearce@spearce.org>
      2ebba528
    • S
      git-gui: Optionally save commit buffer on exit. · db7f34d4
      Shawn O. Pearce 提交于
      If the commit area does not exist, don't save the commit message to
      a file, or the window geometry.  The reason I'm doing this is I want
      to make the main window entirely optional, such as if the user has
      asked us to show a blame from the command line.  In such cases the
      commit area won't exist and trying to get its text would cause an
      error.
      
      If we are running without the commit message area, we cannot save
      our window geometry either, as the root window '.' won't be a normal
      commit window.
      Signed-off-by: NShawn O. Pearce <spearce@spearce.org>
      db7f34d4
    • S
      git-gui: Separate transport/branch menus from multicommit. · 64a906f8
      Shawn O. Pearce 提交于
      These are now controlled by the transport and branch options, rather
      than the multicommit option.
      Signed-off-by: NShawn O. Pearce <spearce@spearce.org>
      64a906f8
    • S
      git-gui: Refactor single_commit to a proc. · cf25ddc8
      Shawn O. Pearce 提交于
      This is a minor code cleanup to make working with what used to be the
      $single_commit flag easier.  Its also to better handle various UI
      configurations, depending on command line parameters given by the
      user, or perhaps user preferences.
      Signed-off-by: NShawn O. Pearce <spearce@spearce.org>
      cf25ddc8
    • S
      git-gui: Replace \ with \\ when showing paths. · 42b922fc
      Shawn O. Pearce 提交于
      We already replace \n with \\n so that Tk widgets don't start a new
      display line with part of a file path which is just unlucky enough
      to contain an LF.  But then its confusing to read a path whose name
      actually contains \n as literal characters.  Escaping \ to \\ would
      make that case display as \\n, clarifying the output.
      Signed-off-by: NShawn O. Pearce <spearce@spearce.org>
      42b922fc
    • S
      git-gui: Support keyboard traversal in browser. · 9bccb782
      Shawn O. Pearce 提交于
      Users want to navigate the file list shown in our branch browser
      windows using the keyboard.  So we now support basic traversal
      with the arrow keys:
      
        Up/Down:  Move the "selection bar" to focus on a different name.
      
        Return:   Move into the subtree, or open the annotated file.
        M1-Right: Ditto.
      
        M1-Up:    Move to the parent tree.
        M1-Left:  Ditto.
      
      Probably the only feature missing from this is to key a leading part
      of the file name and jump directly to that file (or subtree).
      
      This change did require a bit of refactoring, to pull the navigation
      logic out of the mouse click procedure and into more generic routines
      which can also be used in bindings.
      Signed-off-by: NShawn O. Pearce <spearce@spearce.org>
      9bccb782
    • S
      git-gui: Update known branches during rescan. · 63faf4df
      Shawn O. Pearce 提交于
      If the user has created (or deleted) a branch through an external tool,
      and uses Rescan, they probably are trying to make git-gui update to show
      their newly created branch.
      
      So now we load all known heads and update the branch menu during any
      rescan operation, just in-case the set of known branches was modified.
      Signed-off-by: NShawn O. Pearce <spearce@spearce.org>
      63faf4df
  2. 29 1月, 2007 12 次提交
    • S
      git-gui: Assign background colors to each blame hunk. · 37f1db80
      Shawn O. Pearce 提交于
      To help the user visually see which lines are associated with each other
      in the file we attempt to sign a unique background color to each commit
      and then render all text associated with that commit using that color.
      
      This works out OK for a file which has very few commits in it; but
      most files don't have that property.
      
      What we really need to do is look at what colors are used by our
      neighboring commits (if known yet) and pick a color which does not
      conflict with our neighbor.  If we have run out of colors then we
      should force our neighbor to recolor too.  Yes, its the graph coloring
      problem.
      Signed-off-by: NShawn O. Pearce <spearce@spearce.org>
      37f1db80
    • S
      git-gui: Use a grid layout for the blame viewer. · 747c0cf9
      Shawn O. Pearce 提交于
      Using a panedwindow to display the blame viewer's individual columns
      just doesn't make sense.  Most of the important data fits within the
      columns we have allocated, and those that don't the leading part fits
      and that's good enough.  There are just too many columns within this
      viewer to let the user sanely control individual column widths.  This
      change shouldn't really be an issue for most git-gui users as their
      displays should be large enough to accept this massive dump of data.
      
      We now also have a properly working horizontal scrollbar for the
      current file data area.  This makes it easier to get away with a
      narrow window when screen space is limited, as you can still scroll
      around within the file content.
      Signed-off-by: NShawn O. Pearce <spearce@spearce.org>
      747c0cf9
    • S
      git-gui: Install column headers in blame viewer. · e7fb6c69
      Shawn O. Pearce 提交于
      I started to get confused about what each column meant in the blame
      viewer, and I'm the guy who wrote the code!  So now git-gui hints to
      the user about what each column is by drawing headers at the top.
      Unfortunately this meant I had to use those dreaded frame objects
      which seem to cause so much pain on Windows.
      Signed-off-by: NShawn O. Pearce <spearce@spearce.org>
      e7fb6c69
    • S
      git-gui: Display original filename and line number in blame. · 915616e4
      Shawn O. Pearce 提交于
      When we annotate a file and show its line data, we're already asking
      for copy and movement detection (-M -C).  This costs extra time, but
      gives extra data.  Since we are asking for the extra data we really
      should show it to the user.
      
      Now the blame UI has two additional columns, one for the original
      filename (in the case of a move/copy between files) and one for the
      original line number of the current line of code.
      Signed-off-by: NShawn O. Pearce <spearce@spearce.org>
      915616e4
    • S
      git-gui: Correctly handle spaces in filepaths. · 8f6c07b9
      Shawn O. Pearce 提交于
      Anytime are about to open a pipe on what may be user data we need to
      make sure the value is escaped correctly into a Tcl list, so that the
      executed subprocess will receive the right arguments.  For the most
      part we were already doing this correctly, but a handful of locations
      did not.
      Signed-off-by: NShawn O. Pearce <spearce@spearce.org>
      8f6c07b9
    • S
      git-gui: Use -M and -C when running blame. · 463ca37b
      Shawn O. Pearce 提交于
      Since we run blame incrementally in the background we might as well get
      as much data as we can from the file.  Adding -M and -C definately makes
      it take longer to compute the revision annotations, but since they are
      streamed in and updated as they are discovered we'll get recent data
      almost immediately anyway.
      Signed-off-by: NShawn O. Pearce <spearce@spearce.org>
      463ca37b
    • S
      git-gui: Allow users to edit user.name, user.email from options. · db453781
      Shawn O. Pearce 提交于
      Users may need to be able to alter their user.name or user.email
      configuration settings.  If they are mostly a git-gui user they
      should be able to view/set these important values from within
      the git-gui environment, rather than needing to edit a raw text
      file on their local filesystem.
      Signed-off-by: NShawn O. Pearce <spearce@spearce.org>
      db453781
    • S
      git-gui: Display the current branch name in browsers. · c94dd1c8
      Shawn O. Pearce 提交于
      Rather than using HEAD for the current branch, use the actual name of
      the current branch in the browser.  This way the user knows what a
      browser is browsing if they open up different browsers while on different
      branches.
      Signed-off-by: NShawn O. Pearce <spearce@spearce.org>
      c94dd1c8
    • S
      git-gui: Improve the icons used in the browser display. · 3eddda98
      Shawn O. Pearce 提交于
      Real icons which seem to indicate going up to the parent (an up arrow)
      and a subdirectory (an open folder).  Files are now drawn with the
      file_mod icon, like a modified file is.  This just looks better as it
      is more consistent with the rest of our UI.
      Signed-off-by: NShawn O. Pearce <spearce@spearce.org>
      3eddda98
    • S
      git-gui: Implemented file browser and incremental blame. · 35874c16
      Shawn O. Pearce 提交于
      This rather huge change provides a browser for the current branch.  The
      browser simply shows the contents of tree HEAD, and lets the user drill
      down through the tree.  The icons used really stink, as I just copied in
      icon which we already had.  I really need to replace the file_dir and
      file_uplevel icons with something more useful.
      
      If the user double clicks on a file within the browser we open it in
      a blame viewer.  This makes use of the new incremental blame feature
      that Linus just added yesterday to core Git.  Fortunately the feature
      will be in 1.5.0 final so we can rely on having it available here.
      
      Since the blame engine is incremental the user will get blame data
      for groups which can be determined early.  Git will slowly fill in
      the remaining lines as it goes.
      Signed-off-by: NShawn O. Pearce <spearce@spearce.org>
      35874c16
    • S
      git-gui: Test for Cygwin differently than from Windows. · 20ddfcaa
      Shawn O. Pearce 提交于
      Running on Cygwin is different than if we were running through MinGW.
      
      In the Cygwin case we have cygpath available to us, we need to perform
      UNIX<->Windows path translation sometimes, and we need to perform odd
      things like spawning our own login shells to perform network operations.
      But in the MinGW case these don't occur.  Git knows native Windows file
      paths, and login shells may not even exist.
      
      Now git-gui will avoid running cygpath unless it knows its on Cygwin.
      It also uses a different shortcut type when Cygwin is not present, and
      it avoids invoking /bin/sh to execute hooks if Cygwin is not present.
      This latter part probably needs more testing in the MinGW case.
      
      This change also improves how we start gitk.  If the user is on any type
      of Windows system its known that gitk won't start right if ~/.gitk exists.
      So we delete it before starting if we are running on any type of Windows
      operating system.  We always use the same wish executable which launched
      git-gui to start gitk; this way on Windows we don't have to jump back to
      /bin/sh just to go into the first wish found in the user's PATH.  This
      should help on MinGW when we probably don't want to spawn a shell just
      to start gitk.
      Signed-off-by: NShawn O. Pearce <spearce@spearce.org>
      20ddfcaa
    • S
      git-gui: Offer quick access to the HTML formatted documentation. · 273984fc
      Shawn O. Pearce 提交于
      Users may want to be able to read Git documentation, even if they
      are not command line users.  There are many important concepts and
      terms covered within the standard Git documentation which would be
      useful to even non command line using people.
      
      We now try to offer an 'Online Documentation' menu option within the
      Help menu.  First we try to guess to see what browser the user has
      setup.  We default to instaweb.browser, if set, as this is probably
      accurate for the user's configuration.  If not then we try to guess
      based on the operating system and the available browsers for each.
      We prefer documentation which is installed parallel to Git's own
      executables, e.g. `git --exec-path`/../Documentation/index.html, as
      that is how I typically install the HTML docs.  If those are not found
      then we open the documentation published on kernel.org.
      Signed-off-by: NShawn O. Pearce <spearce@spearce.org>
      273984fc
  3. 27 1月, 2007 1 次提交
    • S
      git-gui: Reword meaning of merge.summary. · 6b90d391
      Shawn O. Pearce 提交于
      OK, its official, I'm not reading documentation as well as I should be.
      Core Git's merge.summary configuration option is used to control the
      generation of the text appearing within the merge commit itself.  It
      is not (and never has been) used to default the --no-summary command
      line option, which disables the diffstat at the end of the merge.
      
      I completely blame Git for naming two unrelated options almost the
      exact same thing.  But its my own fault for allowing git-gui to
      confuse the two.
      Signed-off-by: NShawn O. Pearce <spearce@spearce.org>
      6b90d391
  4. 26 1月, 2007 15 次提交
    • S
      git-gui: Support merge.summary, merge.verbosity. · c539449b
      Shawn O. Pearce 提交于
      Changed our private merge summary config option to be the same as the
      merge.summary option supported by core Git.  This means setting the
      "Show Merge Summary" flag in git-gui will have the same effect on
      the command line.
      
      In the same vein I've also added merge.verbosity to the gui options,
      allowing the user to adjust the verbosity level of the recursive
      merge strategy.  I happen to like level 1 and suggest that other users
      use that, but level 2 is the core Git default right now so we'll use
      the same default in git-gui.
      
      Unfortunately it appears as though core Git has broken support for
      the merge.summary option, even though its still in the documentation
      For the time being we should pass along --no-summary to git-merge if
      merge.summary is false.
      Signed-off-by: NShawn O. Pearce <spearce@spearce.org>
      c539449b
    • S
      git-gui: Always offer scrollbars for branch lists. · 729a6f60
      Shawn O. Pearce 提交于
      Anytime we use a listbox to show branch names its possible for the
      listbox to exceed 10 entries (actually its probably very common).
      So we should always offer a scrollbar for the Y axis on these
      listboxes.  I just forgot to add it when I defined them.
      Signed-off-by: NShawn O. Pearce <spearce@spearce.org>
      729a6f60
    • S
      git-gui: Don't allow merges in the middle of other things. · 5f39dbf6
      Shawn O. Pearce 提交于
      If the user is in the middle of a commit they have files which are
      modified.  These may conflict with any merge that they may want
      to perform, which would cause problems if the user wants to abort
      a bad merge as we wouldn't have a checkpoint to roll back onto.
      Signed-off-by: NShawn O. Pearce <spearce@spearce.org>
      5f39dbf6
    • S
      git-gui: Don't allow users to commit a bad octopus merge. · dff7e88f
      Shawn O. Pearce 提交于
      If an octopus merge goes horribly wrong git-merge will leave the
      working directory and index dirty, but will not leave behind a
      MERGE_HEAD file for a later commit.  Consequently we won't know
      its a merge commit and instead would let the user resolve the
      conflicts and commit a single-parent commit, which is wrong.
      
      So now if an octopus merge fails we notify the user that the
      merge did not work, tell them we will reset the working directory,
      and suggest that they merge one branch at a time.  This prevents
      the user from committing a bad octopus merge.
      Signed-off-by: NShawn O. Pearce <spearce@spearce.org>
      dff7e88f
    • S
      git-gui: Update status bar during a merge. · ee3cfb59
      Shawn O. Pearce 提交于
      I got slightly confused when I did two merges in a row, as the status
      bar said "merge completed successfully" while the second merge was
      still running.  Now we show what branches are actively being merged.
      Signed-off-by: NShawn O. Pearce <spearce@spearce.org>
      ee3cfb59
    • S
      git-gui: Let users abort with `reset --hard` type logic. · ce9735df
      Shawn O. Pearce 提交于
      If you get into the middle of a merge that turns out to be horrible
      and just not something you want to do right now, odds are you need
      to run `git reset --hard` to recover your working directory to a
      pre-merge state.
      
      We now offer Merge->Abort Merge for exactly this purpose, however
      its also useful to thow away a non-merge, as its basically the same
      logic as `git reset --hard`.
      Signed-off-by: NShawn O. Pearce <spearce@spearce.org>
      ce9735df
    • S
      git-gui: Implement local merge operations. · e4834837
      Shawn O. Pearce 提交于
      To allow users to merge local heads and tracking branches we now offer
      a dialog which lets the user select 1-15 branches and merge them using
      the stock `git merge` Grand Unified Merge Driver.
      
      Originally I had wanted to implement this merge internally within git-gui
      as I consider GUMD to be mostly Porcelain-ish, but the truth is it does
      its job exceedingly well and its a relatively complex chunk of code.
      I'll probably circle back later and try to remove the invocation of GUMD
      from git-gui, but right now it lets me get the job done faster.
      
      Users cannot start a merge if they are currently in the middle of one,
      or if they are amending a commit.  Trying to do either is just stupid
      and should be stopped as early as possible.
      
      I've also made it simple for users to startup a gitk session prior to
      a merge by offering a Visualize button which runs `gitk $revs --not HEAD`,
      where $revs is the list of branches currently selected in the merge
      dialog.  This makes it quite simple to find out what the damage will
      be to the current branch if you were to carry out the currently proposed
      merge.
      Signed-off-by: NShawn O. Pearce <spearce@spearce.org>
      e4834837
    • S
      git-gui: Use builtin version of 'git gc'. · bc7452f5
      Shawn O. Pearce 提交于
      Technically the new git-gc command is strictly Porcelain; its invoking
      multiple plumbing commands to do its work.  Since git-gui tries to not
      rely on Porclain we shouldn't be invoking git-gc directly, instead we
      should perform its tasks on our own.
      
      To make this easy I've created console_chain, which takes a list of
      tasks to perform and runs them all in the same console window.  If
      any individual task fails then the chain stops running and the window
      shows a failure bar.  Only once all tasks have been completed will it
      invoke console_done with a successful status.
      Signed-off-by: NShawn O. Pearce <spearce@spearce.org>
      bc7452f5
    • S
      git-gui: Refactor console success/failure handling. · 6c3d1481
      Shawn O. Pearce 提交于
      Because I want to be able to run multiple output-producing commands
      in a single 'console' window within git-gui I'm refactoring the
      console handling routines to require the "after" argument of console_exec.
      This should specify a procedure to execute which will receive two args,
      the first is the console window handle and the second is the status of
      the last command (0 on failure, 1 on success).
      
      A new procedure console_done can be passed to the last console_exec
      command to forward perform all cleanup and enable the Close button.
      Its status argument is used to update the final status bar on the
      bottom of the console window.
      
      This isn't any real logic changing, and no new functionality is in
      this patch.
      Signed-off-by: NShawn O. Pearce <spearce@spearce.org>
      6c3d1481
    • S
      git-gui: Always use -v option to push. · b972ea59
      Shawn O. Pearce 提交于
      Right now `git-push -v` is actually not that verbose; it merely adds
      the URL it is pushing to.  This can be informative if you are pushing
      to a configured remote, as you may not actually remember what URL that
      remote is connected to.  That detail can be important if the push
      fails and you attempt to communicate the errors to a 3rd party to help
      you resolve the issue.
      Signed-off-by: NShawn O. Pearce <spearce@spearce.org>
      b972ea59
    • S
      git-gui: Remove no longer used pull from remote code. · 86a2af60
      Shawn O. Pearce 提交于
      Because we aren't going to support single click pulling of changes from
      an existing remote anytime in the near future, I'm moving the code which
      used to perform that action.  Hopefully we'll be able to do something
      like it in the near-future, but also support local branches just as
      easily.
      Signed-off-by: NShawn O. Pearce <spearce@spearce.org>
      86a2af60
    • S
      git-gui: Added arbitrary branch pushing support. · 1d6a9787
      Shawn O. Pearce 提交于
      Because its common for some users to push topic branches to a remote
      repository for review and merging by other parties, users need an
      easy way to push one or more branches to a remote repository without
      needing to edit their .git/config file anytime their set of active
      branches changes.
      
      We now provide a basic 'Push...' menu action in the Push menu which
      opens a dialog allowing the user to select from their set of local
      branches (refs/heads, minus tracking branches).  The user can designate
      which repository to send the changes to by selecting from an already
      configured remote or by entering any valid Git URL.
      Signed-off-by: NShawn O. Pearce <spearce@spearce.org>
      1d6a9787
    • S
      git-gui: Always use lsearch -exact, to prevent globbing. · 156b2921
      Shawn O. Pearce 提交于
      Anytime we are using lsearch we are doing [lsearch -sorted] and we
      are applying it to file paths (or file path like things).  Its valid
      for these to contain special glob characters, but when that happens
      we do not want globbing to occur.  Instead we really need exact
      match semantics.  Always supplying -exact to lsearch will ensure that
      is the case.
      Signed-off-by: NShawn O. Pearce <spearce@spearce.org>
      156b2921
    • S
      git-gui: Maintain the same file list for diff during refresh. · 5f8b70b1
      Shawn O. Pearce 提交于
      I just noticed that a file was always jumping to compare against HEAD
      and the index during a refresh, even if the diff viewer was comparing
      the index against the working directory prior to the refresh.  The
      bug turned out to be caused by a foreach loop going through all file
      list names searching for the path.  Since $ui_index was the first one
      searched and the file was contained in that file list the loop broke
      out, leaving $w set to $ui_index when it had been set by the caller
      to $ui_workdir.  Silly bug caused by using a parameter as a loop
      index.
      Signed-off-by: NShawn O. Pearce <spearce@spearce.org>
      5f8b70b1
    • S
      git-gui: Don't switch branches if changing to the current branch. · d070c4cb
      Shawn O. Pearce 提交于
      Its pointless to switch to the current branch, so don't do it. We
      are already on it and the current index and working directory should
      just be left alone.
      Signed-off-by: NShawn O. Pearce <spearce@spearce.org>
      d070c4cb