提交 8b1f6de8 编写于 作者: A Ariel Badichi 提交者: Junio C Hamano

copy.c: copy_fd - correctly report write errors

Previously, the errno could have been lost due to an intervening
close() call.

This patch also contains minor cosmetic changes.
Signed-off-by: NAriel Badichi <abadichi@bezeqint.net>
Signed-off-by: NJunio C Hamano <gitster@pobox.com>
上级 82881b38
......@@ -9,8 +9,7 @@ int copy_fd(int ifd, int ofd)
if (!len)
break;
if (len < 0) {
int read_error;
read_error = errno;
int read_error = errno;
close(ifd);
return error("copy-fd: read returned %s",
strerror(read_error));
......@@ -25,9 +24,10 @@ int copy_fd(int ifd, int ofd)
close(ifd);
return error("copy-fd: write returned 0");
} else {
int write_error = errno;
close(ifd);
return error("copy-fd: write returned %s",
strerror(errno));
strerror(write_error));
}
}
}
......@@ -48,7 +48,7 @@ int copy_file(const char *dst, const char *src, int mode)
}
status = copy_fd(fdi, fdo);
if (close(fdo) != 0)
return error("%s: write error: %s", dst, strerror(errno));
return error("%s: close error: %s", dst, strerror(errno));
if (!status && adjust_shared_perm(dst))
return -1;
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册