提交 14e1a4e1 编写于 作者: J Jan H. Schönherr 提交者: Junio C Hamano

utf8: fix off-by-one wrapping of text

The wrapping logic in strbuf_add_wrapped_text() does currently not allow
lines that entirely fill the allowed width, instead it wraps the line one
character too early.

For example, the text "This is the sixth commit." formatted via
"%w(11,1,2)" (wrap at 11 characters, 1 char indent of first line, 2 char
indent of following lines) results in four lines: " This is", "  the",
"  sixth", "  commit." This is wrong, because "  the sixth" is exactly
11 characters long, and thus allowed.

Fix this by allowing the (width+1) character of a line to be a valid
wrapping point if it is a whitespace character.
Signed-off-by: NJan H. Schönherr <schnhrr@cs.tu-berlin.de>
Signed-off-by: NJunio C Hamano <gitster@pobox.com>
上级 bafc478f
......@@ -72,9 +72,9 @@ cat > expect << EOF
commit.
EOF
test_expect_success 'format %w(12,1,2)' '
test_expect_success 'format %w(11,1,2)' '
git log -2 --format="%w(12,1,2)This is the %s commit." > actual &&
git log -2 --format="%w(11,1,2)This is the %s commit." > actual &&
test_cmp expect actual
'
......
......@@ -353,7 +353,7 @@ int strbuf_add_wrapped_text(struct strbuf *buf,
c = *text;
if (!c || isspace(c)) {
if (w < width || !space) {
if (w <= width || !space) {
const char *start = bol;
if (!c && text == start)
return w;
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册