• J
    remote-curl: rewrite base url from info/refs redirects · 050ef365
    Jeff King 提交于
    For efficiency and security reasons, an earlier commit in
    this series taught http_get_* to re-write the base url based
    on redirections we saw while making a specific request.
    
    This commit wires that option into the info/refs request,
    meaning that a redirect from
    
        http://example.com/foo.git/info/refs
    
    to
    
        https://example.com/bar.git/info/refs
    
    will behave as if "https://example.com/bar.git" had been
    provided to git in the first place.
    
    The tests bear some explanation. We introduce two new
    hierearchies into the httpd test config:
    
      1. Requests to /smart-redir-limited will work only for the
         initial info/refs request, but not any subsequent
         requests. As a result, we can confirm whether the
         client is re-rooting its requests after the initial
         contact, since otherwise it will fail (it will ask for
         "repo.git/git-upload-pack", which is not redirected).
    
      2. Requests to smart-redir-auth will redirect, and require
         auth after the redirection. Since we are using the
         redirected base for further requests, we also update
         the credential struct, in order not to mislead the user
         (or credential helpers) about which credential is
         needed. We can therefore check the GIT_ASKPASS prompts
         to make sure we are prompting for the new location.
         Because we have neither multiple servers nor https
         support in our test setup, we can only redirect between
         paths, meaning we need to turn on
         credential.useHttpPath to see the difference.
    Signed-off-by: NJeff King <peff@peff.net>
    Signed-off-by: NJonathan Nieder <jrnieder@gmail.com>
    050ef365
remote-curl.c 22.4 KB