• J
    Do not use VISUAL editor on dumb terminals · d33738d7
    Jonathan Nieder 提交于
    Refuse to use $VISUAL and fall back to $EDITOR if TERM is unset
    or set to "dumb".  Traditionally, VISUAL is set to a screen
    editor and EDITOR to a line-based editor, which should be more
    useful in that situation.
    
    vim, for example, is happy to assume a terminal supports ANSI
    sequences even if TERM is dumb (e.g., when running from a text
    editor like Acme).  git already refuses to fall back to vi on a
    dumb terminal if GIT_EDITOR, core.editor, VISUAL, and EDITOR are
    unset, but without this patch, that check is suppressed by
    VISUAL=vi.
    Signed-off-by: NJonathan Nieder <jrnieder@gmail.com>
    Signed-off-by: NJunio C Hamano <gitster@pobox.com>
    d33738d7
test-lib.sh 16.4 KB