• J
    sha1_file: stop opening files with O_NOATIME · b4d065df
    Junio C Hamano 提交于
    When we open object files, we try to do so with O_NOATIME.
    This dates back to 144bde78 (Use O_NOATIME when opening
    the sha1 files., 2005-04-23), which is an optimization to
    avoid creating a bunch of dirty inodes when we're accessing
    many objects.  But a few things have changed since then:
    
      1. In June 2005, git learned about packfiles, which means
         we would do a lot fewer atime updates (rather than one
         per object access, we'd generally get one per packfile).
    
      2. In late 2006, Linux learned about "relatime", which is
         generally the default on modern installs. So
         performance around atimes updates is a non-issue there
         these days.
    
         All the world isn't Linux, but as it turns out, Linux
         is the only platform to implement O_NOATIME in the
         first place.
    
    So it's very unlikely that this code is helping anybody
    these days.
    Helped-by: NJeff King <peff@peff.net>
    [jc: took idea and log message from peff]
    Signed-off-by: NJunio C Hamano <gitster@pobox.com>
    b4d065df
cache.h 69.5 KB