• D
    bloom: fix logic in get_bloom_filter() · 94919742
    Derrick Stolee 提交于
    The get_bloom_filter() method is a bit complicated in some parts where
    it does not need to be. In particular, it needs to return a NULL filter
    only when compute_if_not_present is zero AND the filter data cannot be
    loaded from a commit-graph file. This currently happens by accident
    because the commit-graph does not load changed-path Bloom filters from
    an existing commit-graph when writing a new one. This will change in a
    later patch.
    
    Also clean up some style issues while we are here.
    
    One side-effect of returning a NULL filter is that the filters that are
    reported as "too large" will now be reported as NULL insead of length
    zero. This case was not properly covered before, so add a test. Further,
    remote the counting of the zero-length filters from revision.c and the
    trace2 logs.
    Helped-by: NRené Scharfe <l.s.r@web.de>
    Helped-by: NSZEDER Gábor <szeder.dev@gmail.com>
    Signed-off-by: NDerrick Stolee <dstolee@microsoft.com>
    Signed-off-by: NJunio C Hamano <gitster@pobox.com>
    94919742
revision.c 112.3 KB