• J
    diff.c: output correct index lines for a split diff · b67b9612
    Junio C Hamano 提交于
    A patch that changes the filetype (e.g. regular file to symlink) of a path
    must be split into a deletion event followed by a creation event, which
    means that we need to have two independent metainfo lines for each.
    However, the code reused the single set of metainfo lines.
    
    As the blob object names recorded on the index lines are usually not used
    nor validated on the receiving end, this is not an issue with normal use
    of the resulting patch.  However, when accepting a binary patch to delete
    a blob, git-apply verified that the postimage blob object name on the
    index line is 0{40}, hence a patch that deletes a regular file blob that
    records binary contents to create a blob with different filetype (e.g. a
    symbolic link) failed to apply.  "git am -3" also uses the blob object
    names recorded on the index line, so it would also misbehave when
    synthesizing a preimage tree.
    
    This moves the code to generate metainfo lines around, so that two
    independent sets of metainfo lines are used for the split halves.
    
    Additional tests by Jeff King.
    Signed-off-by: NJeff King <peff@peff.net>
    Signed-off-by: NJunio C Hamano <gitster@pobox.com>
    b67b9612
t4114-apply-typechange.sh 3.0 KB