• L
    [PATCH] Avoid wasting memory in git-rev-list · 60ab26de
    Linus Torvalds 提交于
    As pointed out on the list, git-rev-list can use a lot of memory.
    
    One low-hanging fruit is to free the commit buffer for commits that we
    parse. By default, parse_commit() will save away the buffer, since a lot
    of cases do want it, and re-reading it continually would be unnecessary.
    However, in many cases the buffer isn't actually necessary and saving it
    just wastes memory.
    
    We could just free the buffer ourselves, but especially in git-rev-list,
    we actually end up using the helper functions that automatically add
    parent commits to the commit lists, so we don't actually control the
    commit parsing directly.
    
    Instead, just make this behaviour of "parse_commit()" a global flag.
    Maybe this is a bit tasteless, but it's very simple, and it makes a
    noticable difference in memory usage.
    
    Before the change:
    
    	[torvalds@g5 linux]$ /usr/bin/time git-rev-list v2.6.12..HEAD > /dev/null
    	0.26user 0.02system 0:00.28elapsed 99%CPU (0avgtext+0avgdata 0maxresident)k
    	0inputs+0outputs (0major+3714minor)pagefaults 0swaps
    
    after the change:
    
    	[torvalds@g5 linux]$ /usr/bin/time git-rev-list v2.6.12..HEAD > /dev/null
    	0.26user 0.00system 0:00.27elapsed 100%CPU (0avgtext+0avgdata 0maxresident)k
    	0inputs+0outputs (0major+2433minor)pagefaults 0swaps
    
    note how the minor faults have decreased from 3714 pages to 2433 pages.
    That's all due to the fewer anonymous pages allocated to hold the comment
    buffers and their metadata.
    Signed-off-by: NLinus Torvalds <torvalds@osdl.org>
    Signed-off-by: NJunio C Hamano <junkio@cox.net>
    60ab26de
commit.h 1.9 KB