• J
    run_command: return exit code as positive value · 5709e036
    Johannes Sixt 提交于
    As a general guideline, functions in git's code return zero to indicate
    success and negative values to indicate failure. The run_command family of
    functions followed this guideline. But there are actually two different
    kinds of failure:
    
    - failures of system calls;
    
    - non-zero exit code of the program that was run.
    
    Usually, a non-zero exit code of the program is a failure and means a
    failure to the caller. Except that sometimes it does not. For example, the
    exit code of merge programs (e.g. external merge drivers) conveys
    information about how the merge failed, and not all exit calls are
    actually failures.
    
    Furthermore, the return value of run_command is sometimes used as exit
    code by the caller.
    
    This change arranges that the exit code of the program is returned as a
    positive value, which can now be regarded as the "result" of the function.
    System call failures continue to be reported as negative values.
    Signed-off-by: NJohannes Sixt <j6t@kdbg.org>
    Signed-off-by: NJunio C Hamano <gitster@pobox.com>
    5709e036
run-command.c 7.8 KB