The upload_pack shell variable is initialized to an empty string, so
conditional expansion with ${upload_pack+"$upload_pack"} would not
work very well.  You need a colon there.
Signed-off-by: NJunio C Hamano <gitster@pobox.com>