• M
    parse_dirstat_params(): use string_list to split comma-separated string · 02e8ca0e
    Michael Haggerty 提交于
    Use string_list_split_in_place() to split the comma-separated
    parameters string.  This simplifies the code and also fixes a bug: the
    old code made calls like
    
        memcmp(p, "lines", p_len)
    
    which needn't work if p_len is different than the length of the
    constant string (and could illegally access memory if p_len is larger
    than the length of the constant string).
    
    When p_len was less than the length of the constant string, the old
    code would have allowed some abbreviations to be accepted (e.g., "cha"
    for "changes") but this seems to have been a bug rather than a
    feature, because (1) it is not documented; (2) no attempt was made to
    handle ambiguous abbreviations, like "c" for "changes" vs
    "cumulative".
    Signed-off-by: NMichael Haggerty <mhagger@alum.mit.edu>
    Signed-off-by: NJeff King <peff@peff.net>
    02e8ca0e
diff.c 130.2 KB