• N
    add: do not rely on dtype being NULL behavior · 0188f6b3
    Nguyễn Thái Ngọc Duy 提交于
    Commit c84de707 (excluded_1(): support exclude files in index -
    2009-08-20) added support for excluded() where dtype can be NULL. It
    was designed specifically for index matching because there was no
    other way to extract dtype information from index. It did not support
    wildcard matching (for example, "a*/" pattern would fail to match).
    
    The code was probably misread when commit 108da0db (git add: Add the
    "--ignore-missing" option for the dry run - 2010-07-10) was made
    because DT_UNKNOWN happens to be zero (NULL) too.
    
    Do not pass DT_UNKNOWN/NULL to excluded(), instead pass a pointer to a
    variable that contains DT_UNKNOWN. The real dtype will be extracted
    from worktree by excluded(), as expected.
    Signed-off-by: NNguyễn Thái Ngọc Duy <pclouds@gmail.com>
    Signed-off-by: NJunio C Hamano <gitster@pobox.com>
    0188f6b3
add.c 12.1 KB