http.c 15.7 KB
Newer Older
1 2 3
#include "http.h"

int data_received;
J
Junio C Hamano 已提交
4
int active_requests;
5 6

#ifdef USE_CURL_MULTI
M
Mike Hommey 已提交
7 8
static int max_requests = -1;
static CURLM *curlm;
9 10
#endif
#ifndef NO_CURL_EASY_DUPHANDLE
M
Mike Hommey 已提交
11
static CURL *curl_default;
12 13 14
#endif
char curl_errorstr[CURL_ERROR_SIZE];

M
Mike Hommey 已提交
15
static int curl_ssl_verify = -1;
J
Junio C Hamano 已提交
16
static const char *ssl_cert;
17
#if LIBCURL_VERSION_NUM >= 0x070902
J
Junio C Hamano 已提交
18
static const char *ssl_key;
19 20
#endif
#if LIBCURL_VERSION_NUM >= 0x070908
J
Junio C Hamano 已提交
21
static const char *ssl_capath;
22
#endif
J
Junio C Hamano 已提交
23
static const char *ssl_cainfo;
M
Mike Hommey 已提交
24 25
static long curl_low_speed_limit = -1;
static long curl_low_speed_time = -1;
J
Junio C Hamano 已提交
26 27
static int curl_ftp_no_epsv;
static const char *curl_http_proxy;
J
Junio C Hamano 已提交
28
static char *user_name, *user_pass;
29

M
Mike Hommey 已提交
30
static struct curl_slist *pragma_header;
31

J
Junio C Hamano 已提交
32
static struct active_request_slot *active_queue_head;
33

34
size_t fread_buffer(void *ptr, size_t eltsize, size_t nmemb, void *buffer_)
35 36
{
	size_t size = eltsize * nmemb;
37 38
	struct buffer *buffer = buffer_;

M
Mike Hommey 已提交
39 40 41
	if (size > buffer->buf.len - buffer->posn)
		size = buffer->buf.len - buffer->posn;
	memcpy(ptr, buffer->buf.buf + buffer->posn, size);
42
	buffer->posn += size;
M
Mike Hommey 已提交
43

44 45 46
	return size;
}

47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65
#ifndef NO_CURL_IOCTL
curlioerr ioctl_buffer(CURL *handle, int cmd, void *clientp)
{
	struct buffer *buffer = clientp;

	switch (cmd) {
	case CURLIOCMD_NOP:
		return CURLIOE_OK;

	case CURLIOCMD_RESTARTREAD:
		buffer->posn = 0;
		return CURLIOE_OK;

	default:
		return CURLIOE_UNKNOWNCMD;
	}
}
#endif

66
size_t fwrite_buffer(const void *ptr, size_t eltsize, size_t nmemb, void *buffer_)
67 68
{
	size_t size = eltsize * nmemb;
69 70
	struct strbuf *buffer = buffer_;

M
Mike Hommey 已提交
71
	strbuf_add(buffer, ptr, size);
72 73 74 75
	data_received++;
	return size;
}

76
size_t fwrite_null(const void *ptr, size_t eltsize, size_t nmemb, void *strbuf)
77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113
{
	data_received++;
	return eltsize * nmemb;
}

static void finish_active_slot(struct active_request_slot *slot);

#ifdef USE_CURL_MULTI
static void process_curl_messages(void)
{
	int num_messages;
	struct active_request_slot *slot;
	CURLMsg *curl_message = curl_multi_info_read(curlm, &num_messages);

	while (curl_message != NULL) {
		if (curl_message->msg == CURLMSG_DONE) {
			int curl_result = curl_message->data.result;
			slot = active_queue_head;
			while (slot != NULL &&
			       slot->curl != curl_message->easy_handle)
				slot = slot->next;
			if (slot != NULL) {
				curl_multi_remove_handle(curlm, slot->curl);
				slot->curl_result = curl_result;
				finish_active_slot(slot);
			} else {
				fprintf(stderr, "Received DONE message for unknown request!\n");
			}
		} else {
			fprintf(stderr, "Unknown CURL message received: %d\n",
				(int)curl_message->msg);
		}
		curl_message = curl_multi_info_read(curlm, &num_messages);
	}
}
#endif

114
static int http_options(const char *var, const char *value, void *cb)
115 116
{
	if (!strcmp("http.sslverify", var)) {
117
		curl_ssl_verify = git_config_bool(var, value);
118 119
		return 0;
	}
120 121
	if (!strcmp("http.sslcert", var))
		return git_config_string(&ssl_cert, var, value);
122
#if LIBCURL_VERSION_NUM >= 0x070902
123 124
	if (!strcmp("http.sslkey", var))
		return git_config_string(&ssl_key, var, value);
125 126
#endif
#if LIBCURL_VERSION_NUM >= 0x070908
127 128
	if (!strcmp("http.sslcapath", var))
		return git_config_string(&ssl_capath, var, value);
129
#endif
130 131
	if (!strcmp("http.sslcainfo", var))
		return git_config_string(&ssl_cainfo, var, value);
J
Junio C Hamano 已提交
132
#ifdef USE_CURL_MULTI
133
	if (!strcmp("http.maxrequests", var)) {
134
		max_requests = git_config_int(var, value);
135 136 137 138
		return 0;
	}
#endif
	if (!strcmp("http.lowspeedlimit", var)) {
139
		curl_low_speed_limit = (long)git_config_int(var, value);
140 141 142
		return 0;
	}
	if (!strcmp("http.lowspeedtime", var)) {
143
		curl_low_speed_time = (long)git_config_int(var, value);
144 145 146
		return 0;
	}

147 148 149 150
	if (!strcmp("http.noepsv", var)) {
		curl_ftp_no_epsv = git_config_bool(var, value);
		return 0;
	}
151 152
	if (!strcmp("http.proxy", var))
		return git_config_string(&curl_http_proxy, var, value);
153

154
	/* Fall back on the default ones */
155
	return git_default_config(var, value, cb);
156 157
}

J
Junio C Hamano 已提交
158 159
static void init_curl_http_auth(CURL *result)
{
160
	if (user_name) {
J
Junio C Hamano 已提交
161 162 163 164 165 166 167 168 169
		struct strbuf up = STRBUF_INIT;
		if (!user_pass)
			user_pass = xstrdup(getpass("Password: "));
		strbuf_addf(&up, "%s:%s", user_name, user_pass);
		curl_easy_setopt(result, CURLOPT_USERPWD,
				 strbuf_detach(&up, NULL));
	}
}

J
Junio C Hamano 已提交
170
static CURL *get_curl_handle(void)
171
{
J
Junio C Hamano 已提交
172
	CURL *result = curl_easy_init();
173

174 175 176 177 178 179 180 181 182 183
	if (!curl_ssl_verify) {
		curl_easy_setopt(result, CURLOPT_SSL_VERIFYPEER, 0);
		curl_easy_setopt(result, CURLOPT_SSL_VERIFYHOST, 0);
	} else {
		/* Verify authenticity of the peer's certificate */
		curl_easy_setopt(result, CURLOPT_SSL_VERIFYPEER, 1);
		/* The name in the cert must match whom we tried to connect */
		curl_easy_setopt(result, CURLOPT_SSL_VERIFYHOST, 2);
	}

184 185 186 187
#if LIBCURL_VERSION_NUM >= 0x070907
	curl_easy_setopt(result, CURLOPT_NETRC, CURL_NETRC_OPTIONAL);
#endif

J
Junio C Hamano 已提交
188 189
	init_curl_http_auth(result);

190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212
	if (ssl_cert != NULL)
		curl_easy_setopt(result, CURLOPT_SSLCERT, ssl_cert);
#if LIBCURL_VERSION_NUM >= 0x070902
	if (ssl_key != NULL)
		curl_easy_setopt(result, CURLOPT_SSLKEY, ssl_key);
#endif
#if LIBCURL_VERSION_NUM >= 0x070908
	if (ssl_capath != NULL)
		curl_easy_setopt(result, CURLOPT_CAPATH, ssl_capath);
#endif
	if (ssl_cainfo != NULL)
		curl_easy_setopt(result, CURLOPT_CAINFO, ssl_cainfo);
	curl_easy_setopt(result, CURLOPT_FAILONERROR, 1);

	if (curl_low_speed_limit > 0 && curl_low_speed_time > 0) {
		curl_easy_setopt(result, CURLOPT_LOW_SPEED_LIMIT,
				 curl_low_speed_limit);
		curl_easy_setopt(result, CURLOPT_LOW_SPEED_TIME,
				 curl_low_speed_time);
	}

	curl_easy_setopt(result, CURLOPT_FOLLOWLOCATION, 1);

213 214 215
	if (getenv("GIT_CURL_VERBOSE"))
		curl_easy_setopt(result, CURLOPT_VERBOSE, 1);

216 217
	curl_easy_setopt(result, CURLOPT_USERAGENT, GIT_USER_AGENT);

218 219 220
	if (curl_ftp_no_epsv)
		curl_easy_setopt(result, CURLOPT_FTP_USE_EPSV, 0);

221 222 223
	if (curl_http_proxy)
		curl_easy_setopt(result, CURLOPT_PROXY, curl_http_proxy);

224 225 226
	return result;
}

J
Junio C Hamano 已提交
227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266
static void http_auth_init(const char *url)
{
	char *at, *colon, *cp, *slash;
	int len;

	cp = strstr(url, "://");
	if (!cp)
		return;

	/*
	 * Ok, the URL looks like "proto://something".  Which one?
	 * "proto://<user>:<pass>@<host>/...",
	 * "proto://<user>@<host>/...", or just
	 * "proto://<host>/..."?
	 */
	cp += 3;
	at = strchr(cp, '@');
	colon = strchr(cp, ':');
	slash = strchrnul(cp, '/');
	if (!at || slash <= at)
		return; /* No credentials */
	if (!colon || at <= colon) {
		/* Only username */
		len = at - cp;
		user_name = xmalloc(len + 1);
		memcpy(user_name, cp, len);
		user_name[len] = '\0';
		user_pass = NULL;
	} else {
		len = colon - cp;
		user_name = xmalloc(len + 1);
		memcpy(user_name, cp, len);
		user_name[len] = '\0';
		len = at - (colon + 1);
		user_pass = xmalloc(len + 1);
		memcpy(user_pass, colon + 1, len);
		user_pass[len] = '\0';
	}
}

267 268 269 270 271 272 273
static void set_from_env(const char **var, const char *envname)
{
	const char *val = getenv(envname);
	if (val)
		*var = val;
}

274
void http_init(struct remote *remote)
275 276 277 278
{
	char *low_speed_limit;
	char *low_speed_time;

279 280
	git_config(http_options, NULL);

281 282
	curl_global_init(CURL_GLOBAL_ALL);

283 284 285
	if (remote && remote->http_proxy)
		curl_http_proxy = xstrdup(remote->http_proxy);

286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304
	pragma_header = curl_slist_append(pragma_header, "Pragma: no-cache");

#ifdef USE_CURL_MULTI
	{
		char *http_max_requests = getenv("GIT_HTTP_MAX_REQUESTS");
		if (http_max_requests != NULL)
			max_requests = atoi(http_max_requests);
	}

	curlm = curl_multi_init();
	if (curlm == NULL) {
		fprintf(stderr, "Error creating curl multi handle.\n");
		exit(1);
	}
#endif

	if (getenv("GIT_SSL_NO_VERIFY"))
		curl_ssl_verify = 0;

305
	set_from_env(&ssl_cert, "GIT_SSL_CERT");
306
#if LIBCURL_VERSION_NUM >= 0x070902
307
	set_from_env(&ssl_key, "GIT_SSL_KEY");
308 309
#endif
#if LIBCURL_VERSION_NUM >= 0x070908
310
	set_from_env(&ssl_capath, "GIT_SSL_CAPATH");
311
#endif
312
	set_from_env(&ssl_cainfo, "GIT_SSL_CAINFO");
313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328

	low_speed_limit = getenv("GIT_HTTP_LOW_SPEED_LIMIT");
	if (low_speed_limit != NULL)
		curl_low_speed_limit = strtol(low_speed_limit, NULL, 10);
	low_speed_time = getenv("GIT_HTTP_LOW_SPEED_TIME");
	if (low_speed_time != NULL)
		curl_low_speed_time = strtol(low_speed_time, NULL, 10);

	if (curl_ssl_verify == -1)
		curl_ssl_verify = 1;

#ifdef USE_CURL_MULTI
	if (max_requests < 1)
		max_requests = DEFAULT_MAX_REQUESTS;
#endif

329 330 331
	if (getenv("GIT_CURL_FTP_NO_EPSV"))
		curl_ftp_no_epsv = 1;

J
Junio C Hamano 已提交
332 333 334
	if (remote && remote->url && remote->url[0])
		http_auth_init(remote->url[0]);

335 336 337 338 339 340 341 342 343 344
#ifndef NO_CURL_EASY_DUPHANDLE
	curl_default = get_curl_handle();
#endif
}

void http_cleanup(void)
{
	struct active_request_slot *slot = active_queue_head;

	while (slot != NULL) {
345
		struct active_request_slot *next = slot->next;
346
		if (slot->curl != NULL) {
347
#ifdef USE_CURL_MULTI
348
			curl_multi_remove_handle(curlm, slot->curl);
349 350
#endif
			curl_easy_cleanup(slot->curl);
351
		}
352 353
		free(slot);
		slot = next;
354
	}
355
	active_queue_head = NULL;
356 357 358 359 360 361 362 363 364

#ifndef NO_CURL_EASY_DUPHANDLE
	curl_easy_cleanup(curl_default);
#endif

#ifdef USE_CURL_MULTI
	curl_multi_cleanup(curlm);
#endif
	curl_global_cleanup();
N
Nick Hengeveld 已提交
365 366

	curl_slist_free_all(pragma_header);
367
	pragma_header = NULL;
368 369

	if (curl_http_proxy) {
370
		free((void *)curl_http_proxy);
371 372
		curl_http_proxy = NULL;
	}
373 374 375 376 377 378 379 380 381 382 383 384 385
}

struct active_request_slot *get_active_slot(void)
{
	struct active_request_slot *slot = active_queue_head;
	struct active_request_slot *newslot;

#ifdef USE_CURL_MULTI
	int num_transfers;

	/* Wait for a slot to open up if the queue is full */
	while (active_requests >= max_requests) {
		curl_multi_perform(curlm, &num_transfers);
J
Junio C Hamano 已提交
386
		if (num_transfers < active_requests)
387 388 389 390
			process_curl_messages();
	}
#endif

J
Junio C Hamano 已提交
391
	while (slot != NULL && slot->in_use)
392
		slot = slot->next;
J
Junio C Hamano 已提交
393

394 395 396 397 398 399 400 401 402 403
	if (slot == NULL) {
		newslot = xmalloc(sizeof(*newslot));
		newslot->curl = NULL;
		newslot->in_use = 0;
		newslot->next = NULL;

		slot = active_queue_head;
		if (slot == NULL) {
			active_queue_head = newslot;
		} else {
J
Junio C Hamano 已提交
404
			while (slot->next != NULL)
405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421
				slot = slot->next;
			slot->next = newslot;
		}
		slot = newslot;
	}

	if (slot->curl == NULL) {
#ifdef NO_CURL_EASY_DUPHANDLE
		slot->curl = get_curl_handle();
#else
		slot->curl = curl_easy_duphandle(curl_default);
#endif
	}

	active_requests++;
	slot->in_use = 1;
	slot->local = NULL;
422
	slot->results = NULL;
N
Nick Hengeveld 已提交
423
	slot->finished = NULL;
424 425 426 427
	slot->callback_data = NULL;
	slot->callback_func = NULL;
	curl_easy_setopt(slot->curl, CURLOPT_HTTPHEADER, pragma_header);
	curl_easy_setopt(slot->curl, CURLOPT_ERRORBUFFER, curl_errorstr);
428 429 430 431 432
	curl_easy_setopt(slot->curl, CURLOPT_CUSTOMREQUEST, NULL);
	curl_easy_setopt(slot->curl, CURLOPT_READFUNCTION, NULL);
	curl_easy_setopt(slot->curl, CURLOPT_WRITEFUNCTION, NULL);
	curl_easy_setopt(slot->curl, CURLOPT_UPLOAD, 0);
	curl_easy_setopt(slot->curl, CURLOPT_HTTPGET, 1);
433 434 435 436 437 438 439 440

	return slot;
}

int start_active_slot(struct active_request_slot *slot)
{
#ifdef USE_CURL_MULTI
	CURLMcode curlm_result = curl_multi_add_handle(curlm, slot->curl);
441
	int num_transfers;
442 443 444 445 446 447 448

	if (curlm_result != CURLM_OK &&
	    curlm_result != CURLM_CALL_MULTI_PERFORM) {
		active_requests--;
		slot->in_use = 0;
		return 0;
	}
449 450 451 452 453 454

	/*
	 * We know there must be something to do, since we just added
	 * something.
	 */
	curl_multi_perform(curlm, &num_transfers);
455 456 457 458 459
#endif
	return 1;
}

#ifdef USE_CURL_MULTI
460 461 462 463 464 465
struct fill_chain {
	void *data;
	int (*fill)(void *);
	struct fill_chain *next;
};

J
Junio C Hamano 已提交
466
static struct fill_chain *fill_cfg;
467 468 469

void add_fill_function(void *data, int (*fill)(void *))
{
470
	struct fill_chain *new = xmalloc(sizeof(*new));
471 472 473 474 475 476 477 478 479
	struct fill_chain **linkp = &fill_cfg;
	new->data = data;
	new->fill = fill;
	new->next = NULL;
	while (*linkp)
		linkp = &(*linkp)->next;
	*linkp = new;
}

480 481 482 483
void fill_active_slots(void)
{
	struct active_request_slot *slot = active_queue_head;

484 485 486 487 488 489 490
	while (active_requests < max_requests) {
		struct fill_chain *fill;
		for (fill = fill_cfg; fill; fill = fill->next)
			if (fill->fill(fill->data))
				break;

		if (!fill)
491
			break;
492
	}
493 494 495 496 497 498 499 500 501 502

	while (slot != NULL) {
		if (!slot->in_use && slot->curl != NULL) {
			curl_easy_cleanup(slot->curl);
			slot->curl = NULL;
		}
		slot = slot->next;
	}
}

503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527
void step_active_slots(void)
{
	int num_transfers;
	CURLMcode curlm_result;

	do {
		curlm_result = curl_multi_perform(curlm, &num_transfers);
	} while (curlm_result == CURLM_CALL_MULTI_PERFORM);
	if (num_transfers < active_requests) {
		process_curl_messages();
		fill_active_slots();
	}
}
#endif

void run_active_slot(struct active_request_slot *slot)
{
#ifdef USE_CURL_MULTI
	long last_pos = 0;
	long current_pos;
	fd_set readfds;
	fd_set writefds;
	fd_set excfds;
	int max_fd;
	struct timeval select_timeout;
N
Nick Hengeveld 已提交
528
	int finished = 0;
529

N
Nick Hengeveld 已提交
530 531
	slot->finished = &finished;
	while (!finished) {
532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560
		data_received = 0;
		step_active_slots();

		if (!data_received && slot->local != NULL) {
			current_pos = ftell(slot->local);
			if (current_pos > last_pos)
				data_received++;
			last_pos = current_pos;
		}

		if (slot->in_use && !data_received) {
			max_fd = 0;
			FD_ZERO(&readfds);
			FD_ZERO(&writefds);
			FD_ZERO(&excfds);
			select_timeout.tv_sec = 0;
			select_timeout.tv_usec = 50000;
			select(max_fd, &readfds, &writefds,
			       &excfds, &select_timeout);
		}
	}
#else
	while (slot->in_use) {
		slot->curl_result = curl_easy_perform(slot->curl);
		finish_active_slot(slot);
	}
#endif
}

561
static void closedown_active_slot(struct active_request_slot *slot)
562
{
M
Mike Hommey 已提交
563 564
	active_requests--;
	slot->in_use = 0;
565 566 567 568 569 570
}

void release_active_slot(struct active_request_slot *slot)
{
	closedown_active_slot(slot);
	if (slot->curl) {
N
Nick Hengeveld 已提交
571
#ifdef USE_CURL_MULTI
572
		curl_multi_remove_handle(curlm, slot->curl);
N
Nick Hengeveld 已提交
573
#endif
574 575 576
		curl_easy_cleanup(slot->curl);
		slot->curl = NULL;
	}
N
Nick Hengeveld 已提交
577
#ifdef USE_CURL_MULTI
578
	fill_active_slots();
N
Nick Hengeveld 已提交
579
#endif
580 581 582 583 584
}

static void finish_active_slot(struct active_request_slot *slot)
{
	closedown_active_slot(slot);
M
Mike Hommey 已提交
585
	curl_easy_getinfo(slot->curl, CURLINFO_HTTP_CODE, &slot->http_code);
586

N
Nick Hengeveld 已提交
587 588 589
	if (slot->finished != NULL)
		(*slot->finished) = 1;

590 591 592 593 594 595
	/* Store slot results so they can be read after the slot is reused */
	if (slot->results != NULL) {
		slot->results->curl_result = slot->curl_result;
		slot->results->http_code = slot->http_code;
	}

M
Mike Hommey 已提交
596
	/* Run callback if appropriate */
J
Junio C Hamano 已提交
597
	if (slot->callback_func != NULL)
M
Mike Hommey 已提交
598
		slot->callback_func(slot->callback_data);
599 600 601 602 603 604 605 606 607 608 609 610 611 612
}

void finish_all_active_slots(void)
{
	struct active_request_slot *slot = active_queue_head;

	while (slot != NULL)
		if (slot->in_use) {
			run_active_slot(slot);
			slot = active_queue_head;
		} else {
			slot = slot->next;
		}
}
613 614 615 616 617 618 619 620 621 622 623 624 625 626 627

static inline int needs_quote(int ch)
{
	if (((ch >= 'A') && (ch <= 'Z'))
			|| ((ch >= 'a') && (ch <= 'z'))
			|| ((ch >= '0') && (ch <= '9'))
			|| (ch == '/')
			|| (ch == '-')
			|| (ch == '.'))
		return 0;
	return 1;
}

static inline int hex(int v)
{
J
Junio C Hamano 已提交
628 629 630 631
	if (v < 10)
		return '0' + v;
	else
		return 'A' + v - 10;
632 633 634 635
}

static char *quote_ref_url(const char *base, const char *ref)
{
636
	struct strbuf buf = STRBUF_INIT;
637
	const char *cp;
638
	int ch;
639

640 641 642 643 644
	strbuf_addstr(&buf, base);
	if (buf.len && buf.buf[buf.len - 1] != '/' && *ref != '/')
		strbuf_addstr(&buf, "/");

	for (cp = ref; (ch = *cp) != 0; cp++)
645
		if (needs_quote(ch))
646
			strbuf_addf(&buf, "%%%02x", ch);
647
		else
648
			strbuf_addch(&buf, *cp);
649

650
	return strbuf_detach(&buf, NULL);
651 652
}

653
int http_fetch_ref(const char *base, struct ref *ref)
654 655 656 657 658 659 660
{
	char *url;
	struct strbuf buffer = STRBUF_INIT;
	struct active_request_slot *slot;
	struct slot_results results;
	int ret;

661
	url = quote_ref_url(base, ref->name);
662 663 664 665 666 667 668 669 670 671 672
	slot = get_active_slot();
	slot->results = &results;
	curl_easy_setopt(slot->curl, CURLOPT_FILE, &buffer);
	curl_easy_setopt(slot->curl, CURLOPT_WRITEFUNCTION, fwrite_buffer);
	curl_easy_setopt(slot->curl, CURLOPT_HTTPHEADER, NULL);
	curl_easy_setopt(slot->curl, CURLOPT_URL, url);
	if (start_active_slot(slot)) {
		run_active_slot(slot);
		if (results.curl_result == CURLE_OK) {
			strbuf_rtrim(&buffer);
			if (buffer.len == 40)
673
				ret = get_sha1_hex(buffer.buf, ref->old_sha1);
674 675 676 677
			else if (!prefixcmp(buffer.buf, "ref: ")) {
				ref->symref = xstrdup(buffer.buf + 5);
				ret = 0;
			} else
678 679 680
				ret = 1;
		} else {
			ret = error("Couldn't get %s for %s\n%s",
681
				    url, ref->name, curl_errorstr);
682 683 684 685 686 687 688 689 690
		}
	} else {
		ret = error("Unable to start request");
	}

	strbuf_release(&buffer);
	free(url);
	return ret;
}