Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
李少辉-开发者
Brakeman
提交
c40c2570
B
Brakeman
项目概览
李少辉-开发者
/
Brakeman
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
B
Brakeman
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
前往新版Gitcode,体验更适合开发者的 AI 搜索 >>
提交
c40c2570
编写于
7月 11, 2015
作者:
J
Justin
浏览文件
操作
浏览文件
下载
差异文件
Merge pull request #681 from presidentbeef/better_string_concat
Better handling of string concatenation
上级
22030751
b00a7ace
变更
4
隐藏空白更改
内联
并排
Showing
4 changed file
with
73 addition
and
4 deletion
+73
-4
lib/brakeman/processors/alias_processor.rb
lib/brakeman/processors/alias_processor.rb
+16
-2
test/apps/rails4/app/controllers/another_controller.rb
test/apps/rails4/app/controllers/another_controller.rb
+18
-0
test/tests/alias_processor.rb
test/tests/alias_processor.rb
+25
-0
test/tests/rails4.rb
test/tests/rails4.rb
+14
-2
未找到文件。
lib/brakeman/processors/alias_processor.rb
浏览文件 @
c40c2570
...
...
@@ -77,6 +77,7 @@ class Brakeman::AliasProcessor < Brakeman::SexpProcessor
#Process a method call.
def
process_call
exp
target_var
=
exp
.
target
target_var
&&=
target_var
.
deep_clone
exp
=
process_default
exp
#In case it is replaced with something else
...
...
@@ -159,13 +160,26 @@ class Brakeman::AliasProcessor < Brakeman::SexpProcessor
target
.
value
<<
first_arg
.
value
env
[
target_var
]
=
target
return
target
elsif
string?
target
and
node_type?
first_arg
,
:dstr
,
:
string_interp
exp
=
Sexp
.
new
(:
dstr
,
target
.
value
+
first_arg
[
1
]).
concat
(
first_arg
[
2
..-
1
])
env
[
target_var
]
=
exp
elsif
string?
first_arg
and
node_type?
target
,
:dstr
,
:string_interp
if
string?
target
.
last
target
.
last
.
value
<<
first_arg
.
value
elsif
target
.
last
.
is_a?
String
target
.
last
<<
first_arg
.
value
else
target
<<
first_arg
end
env
[
target_var
]
=
target
return
first_arg
elsif
array?
target
target
<<
first_arg
env
[
target_var
]
=
target
return
target
else
target
=
find_push_target
exp
env
[
target
]
=
exp
unless
target
.
nil?
#Happens in TemplateAliasProcessor
target
=
find_push_target
(
target_var
)
env
[
target
]
=
exp
unless
target
.
nil?
#
Happens in TemplateAliasProcessor
end
end
...
...
test/apps/rails4/app/controllers/another_controller.rb
浏览文件 @
c40c2570
...
...
@@ -37,4 +37,22 @@ class AnotherController < ApplicationController
def
use_params_in_regex
@x
=
something
.
match
/
#{
params
[
:x
]
}
/
end
def
building_strings_for_sql
query
=
"SELECT * FROM users WHERE"
if
params
[
:search
].
to_i
==
1
query
<<
" role = 'admin'"
else
query
<<
" role = 'admin' "
+
params
[
:search
]
end
begin
result
=
{
:result
=>
User
.
find_by_sql
(
query
)
}
rescue
result
=
{}
end
render
json:
result
.
as_json
end
end
test/tests/alias_processor.rb
浏览文件 @
c40c2570
...
...
@@ -50,6 +50,31 @@ class AliasProcessorTests < Test::Unit::TestCase
RUBY
end
def
test_string_append_call
assert_alias
"'hello ' << params[:x]"
,
<<-
RUBY
x = ""
x << 'hello ' << params[:x]
x
RUBY
end
def
test_string_interp_concat
assert_alias
'"#{y}\nthing"'
,
<<-
'RUBY'
x = "
#{
y
}
\n
"
x << "thing"
x
RUBY
end
def
test_string_concat_interp
assert_alias
'"hello\n#{world}"'
,
<<-
'RUBY'
x = ""
x << "hello"
x << "
\n
#{
world
}
"
x
RUBY
end
def
test_array_index
assert_alias
"'cookie'"
,
<<-
RUBY
dessert = ["fruit", "pie", "ice cream"]
...
...
test/tests/rails4.rb
浏览文件 @
c40c2570
...
...
@@ -14,7 +14,7 @@ class Rails4Tests < Test::Unit::TestCase
:controller
=>
0
,
:model
=>
2
,
:template
=>
6
,
:generic
=>
6
0
:generic
=>
6
1
}
end
...
...
@@ -702,7 +702,19 @@ class Rails4Tests < Test::Unit::TestCase
:user_input
=>
s
(
:lvar
,
:locale
)
end
def
test_no_sql_injection_from_arel_methods
def
test_sql_injection_string_concat
assert_warning
:type
=>
:warning
,
:warning_code
=>
0
,
:fingerprint
=>
"b92b1e8d755fb15bed56f8e6f872f81784813b0eae3682b68dd0601e4fb9c0a6"
,
:warning_type
=>
"SQL Injection"
,
:line
=>
51
,
:message
=>
/^Possible\ SQL\ injection/
,
:confidence
=>
0
,
:relative_path
=>
"app/controllers/another_controller.rb"
,
:user_input
=>
s
(
:call
,
s
(
:params
),
:[]
,
s
(
:lit
,
:search
))
end
def
test_no_sql_injection_from_arel_methods
assert_no_warning
:type
=>
:warning
,
:warning_code
=>
0
,
:fingerprint
=>
"61d957cdeca70a82f53d7ec72287fc21f67c67c6e8dbc9c3c4cb2d115f3a5602"
,
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录