Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
李少辉-开发者
Brakeman
提交
7dabe237
B
Brakeman
项目概览
李少辉-开发者
/
Brakeman
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
B
Brakeman
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
7dabe237
编写于
12月 11, 2013
作者:
J
Justin Collins
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Warn on all uses of permit!
上级
eabbc9dd
变更
3
隐藏空白更改
内联
并排
Showing
3 changed file
with
21 addition
and
18 deletion
+21
-18
lib/brakeman/checks/check_mass_assignment.rb
lib/brakeman/checks/check_mass_assignment.rb
+8
-5
test/apps/rails4/app/controllers/friendly_controller.rb
test/apps/rails4/app/controllers/friendly_controller.rb
+3
-3
test/tests/rails4.rb
test/tests/rails4.rb
+10
-10
未找到文件。
lib/brakeman/checks/check_mass_assignment.rb
浏览文件 @
7dabe237
...
...
@@ -172,16 +172,19 @@ class Brakeman::CheckMassAssignment < Brakeman::BaseCheck
end
def
warn_on_permit!
result
return
if
duplicate?
result
or
result
[
:call
].
original_line
or
not
subsequent_mass_assignment?
result
return
if
duplicate?
result
or
result
[
:call
].
original_line
add_result
result
confidence
=
if
subsequent_mass_assignment?
result
CONFIDENCE
[
:high
]
else
CONFIDENCE
[
:med
]
end
warn
:result
=>
result
,
:warning_type
=>
"Mass Assignment"
,
:warning_code
=>
:mass_assign_permit!
,
:message
=>
"Parameters should be whitelisted for mass assignment"
,
:confidence
=>
CONFIDENCE
[
:high
]
:confidence
=>
confidence
end
end
test/apps/rails4/app/controllers/friendly_controller.rb
浏览文件 @
7dabe237
...
...
@@ -24,18 +24,18 @@ class FriendlyController
end
def
mass_assign_protected_model
#
Should not warn
because Account uses attr_accessible
#
Warns with medium confidence
because Account uses attr_accessible
params
.
permit!
Account
.
new
(
params
)
end
def
permit_without_usage
#
Should not warn
because there is no mass assignment
#
Warns with medium confidence
because there is no mass assignment
params
.
permit!
end
def
permit_after_usage
#
Should not warn
because permit! is called after mass assignment
#
Warns with medium confidence
because permit! is called after mass assignment
User
.
new
(
params
)
params
.
permit!
end
...
...
test/tests/rails4.rb
浏览文件 @
7dabe237
...
...
@@ -15,7 +15,7 @@ class Rails4Tests < Test::Unit::TestCase
:controller
=>
0
,
:model
=>
0
,
:template
=>
1
,
:generic
=>
1
0
:generic
=>
1
3
}
end
...
...
@@ -211,33 +211,33 @@ class Rails4Tests < Test::Unit::TestCase
:relative_path
=>
"app/controllers/friendly_controller.rb"
,
:user_input
=>
nil
assert_
no_
warning
:type
=>
:warning
,
assert_warning
:type
=>
:warning
,
:warning_code
=>
70
,
:fingerprint
=>
"
cf2c82b751c8a1ce6a12ad89832cf7da43676032b058278ae65e8895bd6e8a57
"
,
:fingerprint
=>
"
2f2df4aef71799a6a441783b50e7a43a9bed7da6c8d50e07e73d9d165065ceec
"
,
:warning_type
=>
"Mass Assignment"
,
:line
=>
28
,
:message
=>
/^Parameters\ should\ be\ whitelisted\ for\ mas/
,
:confidence
=>
0
,
:confidence
=>
1
,
:relative_path
=>
"app/controllers/friendly_controller.rb"
,
:user_input
=>
nil
assert_
no_
warning
:type
=>
:warning
,
assert_warning
:type
=>
:warning
,
:warning_code
=>
70
,
:fingerprint
=>
"
5495f802e6d3851519c6b911ffb8bfb039e51a77072cf8224306d54e20cf0e9e
"
,
:fingerprint
=>
"
4f6a0d82f6ddf5528f3d50545ce353f2f1658d5102a745107ea572af5c2eee4b
"
,
:warning_type
=>
"Mass Assignment"
,
:line
=>
34
,
:message
=>
/^Parameters\ should\ be\ whitelisted\ for\ mas/
,
:confidence
=>
0
,
:confidence
=>
1
,
:relative_path
=>
"app/controllers/friendly_controller.rb"
,
:user_input
=>
nil
assert_
no_
warning
:type
=>
:warning
,
assert_warning
:type
=>
:warning
,
:warning_code
=>
70
,
:fingerprint
=>
"
f8984beda14640a9c6baa25e8046d8bd6943493425b142174292c804b7afc63e
"
,
:fingerprint
=>
"
947bddec4cdd3ff8b2485eec1bd0078352c182a3bca18a5f68da0a64e87d4e80
"
,
:warning_type
=>
"Mass Assignment"
,
:line
=>
40
,
:message
=>
/^Parameters\ should\ be\ whitelisted\ for\ mas/
,
:confidence
=>
0
,
:confidence
=>
1
,
:relative_path
=>
"app/controllers/friendly_controller.rb"
,
:user_input
=>
nil
end
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录