提交 5d99f32b 编写于 作者: J Justin Collins

Fix Rails LTS detection

上级 51a2a469
......@@ -481,7 +481,8 @@ class Brakeman::BaseCheck < Brakeman::SexpProcessor
def lts_version? version
tracker.config[:gems] and
version_between? version, "2.3.18.99", tracker.config[:gems][:"railslts-version"]
tracker.config[:gems][:'railslts-version'] and
version_between? version, "2.3.18.99", tracker.config[:gems][:'railslts-version']
end
def gemfile_or_environment
......
......@@ -41,6 +41,11 @@ class BaseCheckTests < Test::Unit::TestCase
@check.send(:version_between?, low, high)
end
def lts_version? version, low
@tracker.config = { :gems => { :"railslts-version" => version } }
@check.send(:lts_version?, low)
end
def test_version_between
assert version_between?("2.3.8", "2.3.0", "2.3.8")
assert version_between?("2.3.8", "2.3.0", "2.3.14")
......@@ -61,6 +66,12 @@ class BaseCheckTests < Test::Unit::TestCase
assert version_between?("3.2.9.rc2", "3.2.5", "4.0.0")
end
def test_lts_version
@tracker.config = { :rails_version => "2.3.18" }
assert lts_version? '2.3.18.6', '2.3.18.6'
assert !lts_version?('2.3.18.1', '2.3.18.6')
assert !lts_version?(nil, '2.3.18.6')
end
end
class ConfigTests < Test::Unit::TestCase
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册