提交 07f96375 编写于 作者: Z ZHAOLIPAN 提交者: qiaozhanwei

replace strings with constants already exist. (#1825)

上级 be4fa728
...@@ -16,6 +16,7 @@ ...@@ -16,6 +16,7 @@
*/ */
package org.apache.dolphinscheduler.common.job.db; package org.apache.dolphinscheduler.common.job.db;
import org.apache.dolphinscheduler.common.Constants;
import org.apache.dolphinscheduler.common.utils.StringUtils; import org.apache.dolphinscheduler.common.utils.StringUtils;
import org.slf4j.Logger; import org.slf4j.Logger;
import org.slf4j.LoggerFactory; import org.slf4j.LoggerFactory;
...@@ -58,7 +59,7 @@ public class ClickHouseDataSource extends BaseDataSource { ...@@ -58,7 +59,7 @@ public class ClickHouseDataSource extends BaseDataSource {
public void isConnectable() throws Exception { public void isConnectable() throws Exception {
Connection con = null; Connection con = null;
try { try {
Class.forName("ru.yandex.clickhouse.ClickHouseDriver"); Class.forName(Constants.COM_CLICKHOUSE_JDBC_DRIVER);
con = DriverManager.getConnection(getJdbcUrl(), getUser(), getPassword()); con = DriverManager.getConnection(getJdbcUrl(), getUser(), getPassword());
} finally { } finally {
if (con != null) { if (con != null) {
......
...@@ -16,6 +16,7 @@ ...@@ -16,6 +16,7 @@
*/ */
package org.apache.dolphinscheduler.common.job.db; package org.apache.dolphinscheduler.common.job.db;
import org.apache.dolphinscheduler.common.Constants;
import org.apache.dolphinscheduler.common.utils.StringUtils; import org.apache.dolphinscheduler.common.utils.StringUtils;
import org.slf4j.Logger; import org.slf4j.Logger;
import org.slf4j.LoggerFactory; import org.slf4j.LoggerFactory;
...@@ -61,7 +62,7 @@ public class HiveDataSource extends BaseDataSource { ...@@ -61,7 +62,7 @@ public class HiveDataSource extends BaseDataSource {
public void isConnectable() throws Exception { public void isConnectable() throws Exception {
Connection con = null; Connection con = null;
try { try {
Class.forName("org.apache.hive.jdbc.HiveDriver"); Class.forName(Constants.ORG_APACHE_HIVE_JDBC_HIVE_DRIVER);
con = DriverManager.getConnection(getJdbcUrl(), getUser(), ""); con = DriverManager.getConnection(getJdbcUrl(), getUser(), "");
} finally { } finally {
if (con != null) { if (con != null) {
......
...@@ -16,6 +16,7 @@ ...@@ -16,6 +16,7 @@
*/ */
package org.apache.dolphinscheduler.common.job.db; package org.apache.dolphinscheduler.common.job.db;
import org.apache.dolphinscheduler.common.Constants;
import org.apache.dolphinscheduler.common.utils.StringUtils; import org.apache.dolphinscheduler.common.utils.StringUtils;
import org.slf4j.Logger; import org.slf4j.Logger;
import org.slf4j.LoggerFactory; import org.slf4j.LoggerFactory;
...@@ -56,7 +57,7 @@ public class MySQLDataSource extends BaseDataSource { ...@@ -56,7 +57,7 @@ public class MySQLDataSource extends BaseDataSource {
public void isConnectable() throws Exception { public void isConnectable() throws Exception {
Connection con = null; Connection con = null;
try { try {
Class.forName("com.mysql.jdbc.Driver"); Class.forName(Constants.COM_MYSQL_JDBC_DRIVER);
con = DriverManager.getConnection(getJdbcUrl(), getUser(), getPassword()); con = DriverManager.getConnection(getJdbcUrl(), getUser(), getPassword());
} finally { } finally {
if (con != null) { if (con != null) {
......
...@@ -16,6 +16,7 @@ ...@@ -16,6 +16,7 @@
*/ */
package org.apache.dolphinscheduler.common.job.db; package org.apache.dolphinscheduler.common.job.db;
import org.apache.dolphinscheduler.common.Constants;
import org.apache.dolphinscheduler.common.utils.StringUtils; import org.apache.dolphinscheduler.common.utils.StringUtils;
import org.slf4j.Logger; import org.slf4j.Logger;
import org.slf4j.LoggerFactory; import org.slf4j.LoggerFactory;
...@@ -58,7 +59,7 @@ public class OracleDataSource extends BaseDataSource { ...@@ -58,7 +59,7 @@ public class OracleDataSource extends BaseDataSource {
public void isConnectable() throws Exception { public void isConnectable() throws Exception {
Connection con = null; Connection con = null;
try { try {
Class.forName("oracle.jdbc.driver.OracleDriver"); Class.forName(Constants.COM_ORACLE_JDBC_DRIVER);
con = DriverManager.getConnection(getJdbcUrl(), getUser(), getPassword()); con = DriverManager.getConnection(getJdbcUrl(), getUser(), getPassword());
} finally { } finally {
if (con != null) { if (con != null) {
......
...@@ -16,6 +16,7 @@ ...@@ -16,6 +16,7 @@
*/ */
package org.apache.dolphinscheduler.common.job.db; package org.apache.dolphinscheduler.common.job.db;
import org.apache.dolphinscheduler.common.Constants;
import org.apache.dolphinscheduler.common.utils.StringUtils; import org.apache.dolphinscheduler.common.utils.StringUtils;
import org.slf4j.Logger; import org.slf4j.Logger;
import org.slf4j.LoggerFactory; import org.slf4j.LoggerFactory;
...@@ -60,7 +61,7 @@ public class PostgreDataSource extends BaseDataSource { ...@@ -60,7 +61,7 @@ public class PostgreDataSource extends BaseDataSource {
public void isConnectable() throws Exception { public void isConnectable() throws Exception {
Connection con = null; Connection con = null;
try { try {
Class.forName("org.postgresql.Driver"); Class.forName(Constants.ORG_POSTGRESQL_DRIVER);
con = DriverManager.getConnection(getJdbcUrl(), getUser(), getPassword()); con = DriverManager.getConnection(getJdbcUrl(), getUser(), getPassword());
} finally { } finally {
if (con != null) { if (con != null) {
......
...@@ -16,6 +16,7 @@ ...@@ -16,6 +16,7 @@
*/ */
package org.apache.dolphinscheduler.common.job.db; package org.apache.dolphinscheduler.common.job.db;
import org.apache.dolphinscheduler.common.Constants;
import org.apache.dolphinscheduler.common.utils.StringUtils; import org.apache.dolphinscheduler.common.utils.StringUtils;
import org.slf4j.Logger; import org.slf4j.Logger;
import org.slf4j.LoggerFactory; import org.slf4j.LoggerFactory;
...@@ -54,7 +55,7 @@ public class SQLServerDataSource extends BaseDataSource { ...@@ -54,7 +55,7 @@ public class SQLServerDataSource extends BaseDataSource {
public void isConnectable() throws Exception { public void isConnectable() throws Exception {
Connection con = null; Connection con = null;
try { try {
Class.forName("com.microsoft.sqlserver.jdbc.SQLServerDriver"); Class.forName(Constants.COM_SQLSERVER_JDBC_DRIVER);
con = DriverManager.getConnection(getJdbcUrl(), getUser(), getPassword()); con = DriverManager.getConnection(getJdbcUrl(), getUser(), getPassword());
} finally { } finally {
if (con != null) { if (con != null) {
......
...@@ -16,6 +16,7 @@ ...@@ -16,6 +16,7 @@
*/ */
package org.apache.dolphinscheduler.common.job.db; package org.apache.dolphinscheduler.common.job.db;
import org.apache.dolphinscheduler.common.Constants;
import org.apache.dolphinscheduler.common.utils.StringUtils; import org.apache.dolphinscheduler.common.utils.StringUtils;
import org.slf4j.Logger; import org.slf4j.Logger;
import org.slf4j.LoggerFactory; import org.slf4j.LoggerFactory;
...@@ -63,7 +64,7 @@ public class SparkDataSource extends BaseDataSource { ...@@ -63,7 +64,7 @@ public class SparkDataSource extends BaseDataSource {
public void isConnectable() throws Exception { public void isConnectable() throws Exception {
Connection con = null; Connection con = null;
try { try {
Class.forName("org.apache.hive.jdbc.HiveDriver"); Class.forName(Constants.ORG_APACHE_HIVE_JDBC_HIVE_DRIVER);
con = DriverManager.getConnection(getJdbcUrl(), getUser(), ""); con = DriverManager.getConnection(getJdbcUrl(), getUser(), "");
} finally { } finally {
if (con != null) { if (con != null) {
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册