blk-cgroup.c 46.4 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12 13
/*
 * Common Block IO controller cgroup interface
 *
 * Based on ideas and code from CFQ, CFS and BFQ:
 * Copyright (C) 2003 Jens Axboe <axboe@kernel.dk>
 *
 * Copyright (C) 2008 Fabio Checconi <fabio@gandalf.sssup.it>
 *		      Paolo Valente <paolo.valente@unimore.it>
 *
 * Copyright (C) 2009 Vivek Goyal <vgoyal@redhat.com>
 * 	              Nauman Rafique <nauman@google.com>
 */
#include <linux/ioprio.h>
14 15
#include <linux/seq_file.h>
#include <linux/kdev_t.h>
16
#include <linux/module.h>
17
#include <linux/err.h>
18
#include <linux/blkdev.h>
19
#include <linux/slab.h>
20
#include <linux/genhd.h>
21 22
#include <linux/delay.h>
#include "blk-cgroup.h"
23

24 25
#define MAX_KEY_LEN 100

26 27
static DEFINE_SPINLOCK(blkio_list_lock);
static LIST_HEAD(blkio_list);
28

29
struct blkio_cgroup blkio_root_cgroup = { .weight = 2*BLKIO_WEIGHT_DEFAULT };
30 31
EXPORT_SYMBOL_GPL(blkio_root_cgroup);

32 33
static struct blkio_policy_type *blkio_policy[BLKIO_NR_POLICIES];

B
Ben Blum 已提交
34 35
static struct cgroup_subsys_state *blkiocg_create(struct cgroup_subsys *,
						  struct cgroup *);
36 37 38 39
static int blkiocg_can_attach(struct cgroup_subsys *, struct cgroup *,
			      struct cgroup_taskset *);
static void blkiocg_attach(struct cgroup_subsys *, struct cgroup *,
			   struct cgroup_taskset *);
B
Ben Blum 已提交
40 41 42
static void blkiocg_destroy(struct cgroup_subsys *, struct cgroup *);
static int blkiocg_populate(struct cgroup_subsys *, struct cgroup *);

43 44 45 46 47 48
/* for encoding cft->private value on file */
#define BLKIOFILE_PRIVATE(x, val)	(((x) << 16) | (val))
/* What policy owns the file, proportional or throttle */
#define BLKIOFILE_POLICY(val)		(((val) >> 16) & 0xffff)
#define BLKIOFILE_ATTR(val)		((val) & 0xffff)

B
Ben Blum 已提交
49 50 51
struct cgroup_subsys blkio_subsys = {
	.name = "blkio",
	.create = blkiocg_create,
52 53
	.can_attach = blkiocg_can_attach,
	.attach = blkiocg_attach,
B
Ben Blum 已提交
54 55 56 57 58 59 60 61
	.destroy = blkiocg_destroy,
	.populate = blkiocg_populate,
	.subsys_id = blkio_subsys_id,
	.use_id = 1,
	.module = THIS_MODULE,
};
EXPORT_SYMBOL_GPL(blkio_subsys);

62 63 64 65 66 67
static inline void blkio_policy_insert_node(struct blkio_cgroup *blkcg,
					    struct blkio_policy_node *pn)
{
	list_add(&pn->node, &blkcg->policy_list);
}

68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88
static inline bool cftype_blkg_same_policy(struct cftype *cft,
			struct blkio_group *blkg)
{
	enum blkio_policy_id plid = BLKIOFILE_POLICY(cft->private);

	if (blkg->plid == plid)
		return 1;

	return 0;
}

/* Determines if policy node matches cgroup file being accessed */
static inline bool pn_matches_cftype(struct cftype *cft,
			struct blkio_policy_node *pn)
{
	enum blkio_policy_id plid = BLKIOFILE_POLICY(cft->private);
	int fileid = BLKIOFILE_ATTR(cft->private);

	return (plid == pn->plid && fileid == pn->fileid);
}

89 90 91 92 93 94 95 96
/* Must be called with blkcg->lock held */
static inline void blkio_policy_delete_node(struct blkio_policy_node *pn)
{
	list_del(&pn->node);
}

/* Must be called with blkcg->lock held */
static struct blkio_policy_node *
97 98
blkio_policy_search_node(const struct blkio_cgroup *blkcg, dev_t dev,
		enum blkio_policy_id plid, int fileid)
99 100 101 102
{
	struct blkio_policy_node *pn;

	list_for_each_entry(pn, &blkcg->policy_list, node) {
103
		if (pn->dev == dev && pn->plid == plid && pn->fileid == fileid)
104 105 106 107 108 109
			return pn;
	}

	return NULL;
}

110 111 112 113 114
struct blkio_cgroup *cgroup_to_blkio_cgroup(struct cgroup *cgroup)
{
	return container_of(cgroup_subsys_state(cgroup, blkio_subsys_id),
			    struct blkio_cgroup, css);
}
115
EXPORT_SYMBOL_GPL(cgroup_to_blkio_cgroup);
116

117 118 119 120 121 122 123
struct blkio_cgroup *task_blkio_cgroup(struct task_struct *tsk)
{
	return container_of(task_subsys_state(tsk, blkio_subsys_id),
			    struct blkio_cgroup, css);
}
EXPORT_SYMBOL_GPL(task_blkio_cgroup);

124 125 126 127 128 129 130 131 132 133
static inline void
blkio_update_group_weight(struct blkio_group *blkg, unsigned int weight)
{
	struct blkio_policy_type *blkiop;

	list_for_each_entry(blkiop, &blkio_list, list) {
		/* If this policy does not own the blkg, do not send updates */
		if (blkiop->plid != blkg->plid)
			continue;
		if (blkiop->ops.blkio_update_group_weight_fn)
134
			blkiop->ops.blkio_update_group_weight_fn(blkg->q,
135
							blkg, weight);
136 137 138
	}
}

139 140 141 142 143 144 145 146 147 148 149 150 151
static inline void blkio_update_group_bps(struct blkio_group *blkg, u64 bps,
				int fileid)
{
	struct blkio_policy_type *blkiop;

	list_for_each_entry(blkiop, &blkio_list, list) {

		/* If this policy does not own the blkg, do not send updates */
		if (blkiop->plid != blkg->plid)
			continue;

		if (fileid == BLKIO_THROTL_read_bps_device
		    && blkiop->ops.blkio_update_group_read_bps_fn)
152
			blkiop->ops.blkio_update_group_read_bps_fn(blkg->q,
153
								blkg, bps);
154 155 156

		if (fileid == BLKIO_THROTL_write_bps_device
		    && blkiop->ops.blkio_update_group_write_bps_fn)
157
			blkiop->ops.blkio_update_group_write_bps_fn(blkg->q,
158
								blkg, bps);
159 160 161
	}
}

162 163 164 165 166 167 168 169 170 171 172 173 174
static inline void blkio_update_group_iops(struct blkio_group *blkg,
			unsigned int iops, int fileid)
{
	struct blkio_policy_type *blkiop;

	list_for_each_entry(blkiop, &blkio_list, list) {

		/* If this policy does not own the blkg, do not send updates */
		if (blkiop->plid != blkg->plid)
			continue;

		if (fileid == BLKIO_THROTL_read_iops_device
		    && blkiop->ops.blkio_update_group_read_iops_fn)
175
			blkiop->ops.blkio_update_group_read_iops_fn(blkg->q,
176
								blkg, iops);
177 178 179

		if (fileid == BLKIO_THROTL_write_iops_device
		    && blkiop->ops.blkio_update_group_write_iops_fn)
180
			blkiop->ops.blkio_update_group_write_iops_fn(blkg->q,
181
								blkg,iops);
182 183 184
	}
}

185 186 187 188
/*
 * Add to the appropriate stat variable depending on the request type.
 * This should be called with the blkg->stats_lock held.
 */
189 190
static void blkio_add_stat(uint64_t *stat, uint64_t add, bool direction,
				bool sync)
191
{
192 193
	if (direction)
		stat[BLKIO_STAT_WRITE] += add;
194
	else
195 196 197
		stat[BLKIO_STAT_READ] += add;
	if (sync)
		stat[BLKIO_STAT_SYNC] += add;
198
	else
199
		stat[BLKIO_STAT_ASYNC] += add;
200 201
}

202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225
/*
 * Decrements the appropriate stat variable if non-zero depending on the
 * request type. Panics on value being zero.
 * This should be called with the blkg->stats_lock held.
 */
static void blkio_check_and_dec_stat(uint64_t *stat, bool direction, bool sync)
{
	if (direction) {
		BUG_ON(stat[BLKIO_STAT_WRITE] == 0);
		stat[BLKIO_STAT_WRITE]--;
	} else {
		BUG_ON(stat[BLKIO_STAT_READ] == 0);
		stat[BLKIO_STAT_READ]--;
	}
	if (sync) {
		BUG_ON(stat[BLKIO_STAT_SYNC] == 0);
		stat[BLKIO_STAT_SYNC]--;
	} else {
		BUG_ON(stat[BLKIO_STAT_ASYNC] == 0);
		stat[BLKIO_STAT_ASYNC]--;
	}
}

#ifdef CONFIG_DEBUG_BLK_CGROUP
226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295
/* This should be called with the blkg->stats_lock held. */
static void blkio_set_start_group_wait_time(struct blkio_group *blkg,
						struct blkio_group *curr_blkg)
{
	if (blkio_blkg_waiting(&blkg->stats))
		return;
	if (blkg == curr_blkg)
		return;
	blkg->stats.start_group_wait_time = sched_clock();
	blkio_mark_blkg_waiting(&blkg->stats);
}

/* This should be called with the blkg->stats_lock held. */
static void blkio_update_group_wait_time(struct blkio_group_stats *stats)
{
	unsigned long long now;

	if (!blkio_blkg_waiting(stats))
		return;

	now = sched_clock();
	if (time_after64(now, stats->start_group_wait_time))
		stats->group_wait_time += now - stats->start_group_wait_time;
	blkio_clear_blkg_waiting(stats);
}

/* This should be called with the blkg->stats_lock held. */
static void blkio_end_empty_time(struct blkio_group_stats *stats)
{
	unsigned long long now;

	if (!blkio_blkg_empty(stats))
		return;

	now = sched_clock();
	if (time_after64(now, stats->start_empty_time))
		stats->empty_time += now - stats->start_empty_time;
	blkio_clear_blkg_empty(stats);
}

void blkiocg_update_set_idle_time_stats(struct blkio_group *blkg)
{
	unsigned long flags;

	spin_lock_irqsave(&blkg->stats_lock, flags);
	BUG_ON(blkio_blkg_idling(&blkg->stats));
	blkg->stats.start_idle_time = sched_clock();
	blkio_mark_blkg_idling(&blkg->stats);
	spin_unlock_irqrestore(&blkg->stats_lock, flags);
}
EXPORT_SYMBOL_GPL(blkiocg_update_set_idle_time_stats);

void blkiocg_update_idle_time_stats(struct blkio_group *blkg)
{
	unsigned long flags;
	unsigned long long now;
	struct blkio_group_stats *stats;

	spin_lock_irqsave(&blkg->stats_lock, flags);
	stats = &blkg->stats;
	if (blkio_blkg_idling(stats)) {
		now = sched_clock();
		if (time_after64(now, stats->start_idle_time))
			stats->idle_time += now - stats->start_idle_time;
		blkio_clear_blkg_idling(stats);
	}
	spin_unlock_irqrestore(&blkg->stats_lock, flags);
}
EXPORT_SYMBOL_GPL(blkiocg_update_idle_time_stats);

296
void blkiocg_update_avg_queue_size_stats(struct blkio_group *blkg)
297 298 299 300 301 302 303 304 305 306
{
	unsigned long flags;
	struct blkio_group_stats *stats;

	spin_lock_irqsave(&blkg->stats_lock, flags);
	stats = &blkg->stats;
	stats->avg_queue_size_sum +=
			stats->stat_arr[BLKIO_STAT_QUEUED][BLKIO_STAT_READ] +
			stats->stat_arr[BLKIO_STAT_QUEUED][BLKIO_STAT_WRITE];
	stats->avg_queue_size_samples++;
307
	blkio_update_group_wait_time(stats);
308 309
	spin_unlock_irqrestore(&blkg->stats_lock, flags);
}
310 311
EXPORT_SYMBOL_GPL(blkiocg_update_avg_queue_size_stats);

312
void blkiocg_set_start_empty_time(struct blkio_group *blkg)
D
Divyesh Shah 已提交
313 314 315 316 317 318 319 320 321 322 323 324 325 326
{
	unsigned long flags;
	struct blkio_group_stats *stats;

	spin_lock_irqsave(&blkg->stats_lock, flags);
	stats = &blkg->stats;

	if (stats->stat_arr[BLKIO_STAT_QUEUED][BLKIO_STAT_READ] ||
			stats->stat_arr[BLKIO_STAT_QUEUED][BLKIO_STAT_WRITE]) {
		spin_unlock_irqrestore(&blkg->stats_lock, flags);
		return;
	}

	/*
327 328 329
	 * group is already marked empty. This can happen if cfqq got new
	 * request in parent group and moved to this group while being added
	 * to service tree. Just ignore the event and move on.
D
Divyesh Shah 已提交
330
	 */
331 332 333 334 335
	if(blkio_blkg_empty(stats)) {
		spin_unlock_irqrestore(&blkg->stats_lock, flags);
		return;
	}

D
Divyesh Shah 已提交
336 337 338 339 340 341
	stats->start_empty_time = sched_clock();
	blkio_mark_blkg_empty(stats);
	spin_unlock_irqrestore(&blkg->stats_lock, flags);
}
EXPORT_SYMBOL_GPL(blkiocg_set_start_empty_time);

342 343 344 345 346 347
void blkiocg_update_dequeue_stats(struct blkio_group *blkg,
			unsigned long dequeue)
{
	blkg->stats.dequeue += dequeue;
}
EXPORT_SYMBOL_GPL(blkiocg_update_dequeue_stats);
348 349 350 351
#else
static inline void blkio_set_start_group_wait_time(struct blkio_group *blkg,
					struct blkio_group *curr_blkg) {}
static inline void blkio_end_empty_time(struct blkio_group_stats *stats) {}
352 353
#endif

354
void blkiocg_update_io_add_stats(struct blkio_group *blkg,
355 356 357 358 359 360 361 362
			struct blkio_group *curr_blkg, bool direction,
			bool sync)
{
	unsigned long flags;

	spin_lock_irqsave(&blkg->stats_lock, flags);
	blkio_add_stat(blkg->stats.stat_arr[BLKIO_STAT_QUEUED], 1, direction,
			sync);
363 364
	blkio_end_empty_time(&blkg->stats);
	blkio_set_start_group_wait_time(blkg, curr_blkg);
365 366
	spin_unlock_irqrestore(&blkg->stats_lock, flags);
}
367
EXPORT_SYMBOL_GPL(blkiocg_update_io_add_stats);
368

369
void blkiocg_update_io_remove_stats(struct blkio_group *blkg,
370 371 372 373 374 375 376 377 378
						bool direction, bool sync)
{
	unsigned long flags;

	spin_lock_irqsave(&blkg->stats_lock, flags);
	blkio_check_and_dec_stat(blkg->stats.stat_arr[BLKIO_STAT_QUEUED],
					direction, sync);
	spin_unlock_irqrestore(&blkg->stats_lock, flags);
}
379
EXPORT_SYMBOL_GPL(blkiocg_update_io_remove_stats);
380

381 382
void blkiocg_update_timeslice_used(struct blkio_group *blkg, unsigned long time,
				unsigned long unaccounted_time)
383
{
384 385 386 387
	unsigned long flags;

	spin_lock_irqsave(&blkg->stats_lock, flags);
	blkg->stats.time += time;
388
#ifdef CONFIG_DEBUG_BLK_CGROUP
389
	blkg->stats.unaccounted_time += unaccounted_time;
390
#endif
391
	spin_unlock_irqrestore(&blkg->stats_lock, flags);
392
}
393
EXPORT_SYMBOL_GPL(blkiocg_update_timeslice_used);
394

395 396 397 398
/*
 * should be called under rcu read lock or queue lock to make sure blkg pointer
 * is valid.
 */
399 400
void blkiocg_update_dispatch_stats(struct blkio_group *blkg,
				uint64_t bytes, bool direction, bool sync)
401
{
402
	struct blkio_group_stats_cpu *stats_cpu;
403 404 405 406 407 408 409 410
	unsigned long flags;

	/*
	 * Disabling interrupts to provide mutual exclusion between two
	 * writes on same cpu. It probably is not needed for 64bit. Not
	 * optimizing that case yet.
	 */
	local_irq_save(flags);
411

412 413
	stats_cpu = this_cpu_ptr(blkg->stats_cpu);

414
	u64_stats_update_begin(&stats_cpu->syncp);
415 416 417 418 419
	stats_cpu->sectors += bytes >> 9;
	blkio_add_stat(stats_cpu->stat_arr_cpu[BLKIO_STAT_CPU_SERVICED],
			1, direction, sync);
	blkio_add_stat(stats_cpu->stat_arr_cpu[BLKIO_STAT_CPU_SERVICE_BYTES],
			bytes, direction, sync);
420 421
	u64_stats_update_end(&stats_cpu->syncp);
	local_irq_restore(flags);
422
}
423
EXPORT_SYMBOL_GPL(blkiocg_update_dispatch_stats);
424

425 426
void blkiocg_update_completion_stats(struct blkio_group *blkg,
	uint64_t start_time, uint64_t io_start_time, bool direction, bool sync)
427 428 429 430 431 432 433
{
	struct blkio_group_stats *stats;
	unsigned long flags;
	unsigned long long now = sched_clock();

	spin_lock_irqsave(&blkg->stats_lock, flags);
	stats = &blkg->stats;
434 435 436 437 438 439
	if (time_after64(now, io_start_time))
		blkio_add_stat(stats->stat_arr[BLKIO_STAT_SERVICE_TIME],
				now - io_start_time, direction, sync);
	if (time_after64(io_start_time, start_time))
		blkio_add_stat(stats->stat_arr[BLKIO_STAT_WAIT_TIME],
				io_start_time - start_time, direction, sync);
440 441
	spin_unlock_irqrestore(&blkg->stats_lock, flags);
}
442
EXPORT_SYMBOL_GPL(blkiocg_update_completion_stats);
443

444
/*  Merged stats are per cpu.  */
D
Divyesh Shah 已提交
445 446 447
void blkiocg_update_io_merged_stats(struct blkio_group *blkg, bool direction,
					bool sync)
{
448
	struct blkio_group_stats_cpu *stats_cpu;
D
Divyesh Shah 已提交
449 450
	unsigned long flags;

451 452 453 454 455 456 457 458 459 460 461 462 463 464
	/*
	 * Disabling interrupts to provide mutual exclusion between two
	 * writes on same cpu. It probably is not needed for 64bit. Not
	 * optimizing that case yet.
	 */
	local_irq_save(flags);

	stats_cpu = this_cpu_ptr(blkg->stats_cpu);

	u64_stats_update_begin(&stats_cpu->syncp);
	blkio_add_stat(stats_cpu->stat_arr_cpu[BLKIO_STAT_CPU_MERGED], 1,
				direction, sync);
	u64_stats_update_end(&stats_cpu->syncp);
	local_irq_restore(flags);
D
Divyesh Shah 已提交
465 466 467
}
EXPORT_SYMBOL_GPL(blkiocg_update_io_merged_stats);

468 469 470 471 472
struct blkio_group *blkg_lookup_create(struct blkio_cgroup *blkcg,
				       struct request_queue *q,
				       enum blkio_policy_id plid,
				       bool for_root)
	__releases(q->queue_lock) __acquires(q->queue_lock)
473
{
474 475
	struct blkio_policy_type *pol = blkio_policy[plid];
	struct blkio_group *blkg, *new_blkg;
476

477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522
	WARN_ON_ONCE(!rcu_read_lock_held());
	lockdep_assert_held(q->queue_lock);

	/*
	 * This could be the first entry point of blkcg implementation and
	 * we shouldn't allow anything to go through for a bypassing queue.
	 * The following can be removed if blkg lookup is guaranteed to
	 * fail on a bypassing queue.
	 */
	if (unlikely(blk_queue_bypass(q)) && !for_root)
		return ERR_PTR(blk_queue_dead(q) ? -EINVAL : -EBUSY);

	blkg = blkg_lookup(blkcg, q, plid);
	if (blkg)
		return blkg;

	if (!css_tryget(&blkcg->css))
		return ERR_PTR(-EINVAL);

	/*
	 * Allocate and initialize.
	 *
	 * FIXME: The following is broken.  Percpu memory allocation
	 * requires %GFP_KERNEL context and can't be performed from IO
	 * path.  Allocation here should inherently be atomic and the
	 * following lock dancing can be removed once the broken percpu
	 * allocation is fixed.
	 */
	spin_unlock_irq(q->queue_lock);
	rcu_read_unlock();

	new_blkg = pol->ops.blkio_alloc_group_fn(q, blkcg);
	if (new_blkg) {
		new_blkg->stats_cpu = alloc_percpu(struct blkio_group_stats_cpu);

		spin_lock_init(&new_blkg->stats_lock);
		rcu_assign_pointer(new_blkg->q, q);
		new_blkg->blkcg_id = css_id(&blkcg->css);
		new_blkg->plid = plid;
		cgroup_path(blkcg->css.cgroup, new_blkg->path,
			    sizeof(new_blkg->path));
	}

	rcu_read_lock();
	spin_lock_irq(q->queue_lock);
	css_put(&blkcg->css);
523

524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543
	/* did bypass get turned on inbetween? */
	if (unlikely(blk_queue_bypass(q)) && !for_root) {
		blkg = ERR_PTR(blk_queue_dead(q) ? -EINVAL : -EBUSY);
		goto out;
	}

	/* did someone beat us to it? */
	blkg = blkg_lookup(blkcg, q, plid);
	if (unlikely(blkg))
		goto out;

	/* did alloc fail? */
	if (unlikely(!new_blkg || !new_blkg->stats_cpu)) {
		blkg = ERR_PTR(-ENOMEM);
		goto out;
	}

	/* insert */
	spin_lock(&blkcg->lock);
	swap(blkg, new_blkg);
544
	hlist_add_head_rcu(&blkg->blkcg_node, &blkcg->blkg_list);
545 546 547 548 549 550 551 552
	pol->ops.blkio_link_group_fn(q, blkg);
	spin_unlock(&blkcg->lock);
out:
	if (new_blkg) {
		free_percpu(new_blkg->stats_cpu);
		kfree(new_blkg);
	}
	return blkg;
553
}
554
EXPORT_SYMBOL_GPL(blkg_lookup_create);
555

556 557 558 559 560 561 562 563 564 565
static void __blkiocg_del_blkio_group(struct blkio_group *blkg)
{
	hlist_del_init_rcu(&blkg->blkcg_node);
	blkg->blkcg_id = 0;
}

/*
 * returns 0 if blkio_group was still on cgroup list. Otherwise returns 1
 * indicating that blk_group was unhashed by the time we got to it.
 */
566 567
int blkiocg_del_blkio_group(struct blkio_group *blkg)
{
568 569 570 571 572 573 574
	struct blkio_cgroup *blkcg;
	unsigned long flags;
	struct cgroup_subsys_state *css;
	int ret = 1;

	rcu_read_lock();
	css = css_lookup(&blkio_subsys, blkg->blkcg_id);
575 576 577 578 579 580 581 582
	if (css) {
		blkcg = container_of(css, struct blkio_cgroup, css);
		spin_lock_irqsave(&blkcg->lock, flags);
		if (!hlist_unhashed(&blkg->blkcg_node)) {
			__blkiocg_del_blkio_group(blkg);
			ret = 0;
		}
		spin_unlock_irqrestore(&blkcg->lock, flags);
583
	}
584

585 586
	rcu_read_unlock();
	return ret;
587
}
588
EXPORT_SYMBOL_GPL(blkiocg_del_blkio_group);
589 590

/* called under rcu_read_lock(). */
591 592 593
struct blkio_group *blkg_lookup(struct blkio_cgroup *blkcg,
				struct request_queue *q,
				enum blkio_policy_id plid)
594 595 596 597
{
	struct blkio_group *blkg;
	struct hlist_node *n;

598 599
	hlist_for_each_entry_rcu(blkg, n, &blkcg->blkg_list, blkcg_node)
		if (blkg->q == q && blkg->plid == plid)
600 601 602
			return blkg;
	return NULL;
}
603
EXPORT_SYMBOL_GPL(blkg_lookup);
604

605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635
void blkg_destroy_all(struct request_queue *q)
{
	struct blkio_policy_type *pol;

	while (true) {
		bool done = true;

		spin_lock(&blkio_list_lock);
		spin_lock_irq(q->queue_lock);

		/*
		 * clear_queue_fn() might return with non-empty group list
		 * if it raced cgroup removal and lost.  cgroup removal is
		 * guaranteed to make forward progress and retrying after a
		 * while is enough.  This ugliness is scheduled to be
		 * removed after locking update.
		 */
		list_for_each_entry(pol, &blkio_list, list)
			if (!pol->ops.blkio_clear_queue_fn(q))
				done = false;

		spin_unlock_irq(q->queue_lock);
		spin_unlock(&blkio_list_lock);

		if (done)
			break;

		msleep(10);	/* just some random duration I like */
	}
}

636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659
static void blkio_reset_stats_cpu(struct blkio_group *blkg)
{
	struct blkio_group_stats_cpu *stats_cpu;
	int i, j, k;
	/*
	 * Note: On 64 bit arch this should not be an issue. This has the
	 * possibility of returning some inconsistent value on 32bit arch
	 * as 64bit update on 32bit is non atomic. Taking care of this
	 * corner case makes code very complicated, like sending IPIs to
	 * cpus, taking care of stats of offline cpus etc.
	 *
	 * reset stats is anyway more of a debug feature and this sounds a
	 * corner case. So I am not complicating the code yet until and
	 * unless this becomes a real issue.
	 */
	for_each_possible_cpu(i) {
		stats_cpu = per_cpu_ptr(blkg->stats_cpu, i);
		stats_cpu->sectors = 0;
		for(j = 0; j < BLKIO_STAT_CPU_NR; j++)
			for (k = 0; k < BLKIO_STAT_TOTAL; k++)
				stats_cpu->stat_arr_cpu[j][k] = 0;
	}
}

660
static int
661
blkiocg_reset_stats(struct cgroup *cgroup, struct cftype *cftype, u64 val)
662 663 664
{
	struct blkio_cgroup *blkcg;
	struct blkio_group *blkg;
665
	struct blkio_group_stats *stats;
666
	struct hlist_node *n;
667 668
	uint64_t queued[BLKIO_STAT_TOTAL];
	int i;
669 670 671 672
#ifdef CONFIG_DEBUG_BLK_CGROUP
	bool idling, waiting, empty;
	unsigned long long now = sched_clock();
#endif
673 674 675 676 677

	blkcg = cgroup_to_blkio_cgroup(cgroup);
	spin_lock_irq(&blkcg->lock);
	hlist_for_each_entry(blkg, n, &blkcg->blkg_list, blkcg_node) {
		spin_lock(&blkg->stats_lock);
678 679 680 681 682 683
		stats = &blkg->stats;
#ifdef CONFIG_DEBUG_BLK_CGROUP
		idling = blkio_blkg_idling(stats);
		waiting = blkio_blkg_waiting(stats);
		empty = blkio_blkg_empty(stats);
#endif
684
		for (i = 0; i < BLKIO_STAT_TOTAL; i++)
685 686
			queued[i] = stats->stat_arr[BLKIO_STAT_QUEUED][i];
		memset(stats, 0, sizeof(struct blkio_group_stats));
687
		for (i = 0; i < BLKIO_STAT_TOTAL; i++)
688 689 690 691 692 693 694 695 696 697 698 699 700 701 702
			stats->stat_arr[BLKIO_STAT_QUEUED][i] = queued[i];
#ifdef CONFIG_DEBUG_BLK_CGROUP
		if (idling) {
			blkio_mark_blkg_idling(stats);
			stats->start_idle_time = now;
		}
		if (waiting) {
			blkio_mark_blkg_waiting(stats);
			stats->start_group_wait_time = now;
		}
		if (empty) {
			blkio_mark_blkg_empty(stats);
			stats->start_empty_time = now;
		}
#endif
703
		spin_unlock(&blkg->stats_lock);
704 705 706

		/* Reset Per cpu stats which don't take blkg->stats_lock */
		blkio_reset_stats_cpu(blkg);
707
	}
708

709 710 711 712
	spin_unlock_irq(&blkcg->lock);
	return 0;
}

713 714
static void blkio_get_key_name(enum stat_sub_type type, dev_t dev, char *str,
				int chars_left, bool diskname_only)
715
{
716
	snprintf(str, chars_left, "%d:%d", MAJOR(dev), MINOR(dev));
717 718 719 720 721 722
	chars_left -= strlen(str);
	if (chars_left <= 0) {
		printk(KERN_WARNING
			"Possibly incorrect cgroup stat display format");
		return;
	}
723 724
	if (diskname_only)
		return;
725
	switch (type) {
726
	case BLKIO_STAT_READ:
727 728
		strlcat(str, " Read", chars_left);
		break;
729
	case BLKIO_STAT_WRITE:
730 731
		strlcat(str, " Write", chars_left);
		break;
732
	case BLKIO_STAT_SYNC:
733 734
		strlcat(str, " Sync", chars_left);
		break;
735
	case BLKIO_STAT_ASYNC:
736 737
		strlcat(str, " Async", chars_left);
		break;
738
	case BLKIO_STAT_TOTAL:
739 740 741 742 743 744 745
		strlcat(str, " Total", chars_left);
		break;
	default:
		strlcat(str, " Invalid", chars_left);
	}
}

746 747 748 749 750 751 752
static uint64_t blkio_fill_stat(char *str, int chars_left, uint64_t val,
				struct cgroup_map_cb *cb, dev_t dev)
{
	blkio_get_key_name(0, dev, str, chars_left, true);
	cb->fill(cb, str, val);
	return val;
}
753

754 755 756 757 758 759

static uint64_t blkio_read_stat_cpu(struct blkio_group *blkg,
			enum stat_type_cpu type, enum stat_sub_type sub_type)
{
	int cpu;
	struct blkio_group_stats_cpu *stats_cpu;
760
	u64 val = 0, tval;
761 762

	for_each_possible_cpu(cpu) {
763
		unsigned int start;
764 765
		stats_cpu  = per_cpu_ptr(blkg->stats_cpu, cpu);

766 767 768 769 770 771 772 773 774
		do {
			start = u64_stats_fetch_begin(&stats_cpu->syncp);
			if (type == BLKIO_STAT_CPU_SECTORS)
				tval = stats_cpu->sectors;
			else
				tval = stats_cpu->stat_arr_cpu[type][sub_type];
		} while(u64_stats_fetch_retry(&stats_cpu->syncp, start));

		val += tval;
775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806
	}

	return val;
}

static uint64_t blkio_get_stat_cpu(struct blkio_group *blkg,
		struct cgroup_map_cb *cb, dev_t dev, enum stat_type_cpu type)
{
	uint64_t disk_total, val;
	char key_str[MAX_KEY_LEN];
	enum stat_sub_type sub_type;

	if (type == BLKIO_STAT_CPU_SECTORS) {
		val = blkio_read_stat_cpu(blkg, type, 0);
		return blkio_fill_stat(key_str, MAX_KEY_LEN - 1, val, cb, dev);
	}

	for (sub_type = BLKIO_STAT_READ; sub_type < BLKIO_STAT_TOTAL;
			sub_type++) {
		blkio_get_key_name(sub_type, dev, key_str, MAX_KEY_LEN, false);
		val = blkio_read_stat_cpu(blkg, type, sub_type);
		cb->fill(cb, key_str, val);
	}

	disk_total = blkio_read_stat_cpu(blkg, type, BLKIO_STAT_READ) +
			blkio_read_stat_cpu(blkg, type, BLKIO_STAT_WRITE);

	blkio_get_key_name(BLKIO_STAT_TOTAL, dev, key_str, MAX_KEY_LEN, false);
	cb->fill(cb, key_str, disk_total);
	return disk_total;
}

807 808 809
/* This should be called with blkg->stats_lock held */
static uint64_t blkio_get_stat(struct blkio_group *blkg,
		struct cgroup_map_cb *cb, dev_t dev, enum stat_type type)
810 811 812
{
	uint64_t disk_total;
	char key_str[MAX_KEY_LEN];
813 814 815 816 817
	enum stat_sub_type sub_type;

	if (type == BLKIO_STAT_TIME)
		return blkio_fill_stat(key_str, MAX_KEY_LEN - 1,
					blkg->stats.time, cb, dev);
818
#ifdef CONFIG_DEBUG_BLK_CGROUP
819 820 821
	if (type == BLKIO_STAT_UNACCOUNTED_TIME)
		return blkio_fill_stat(key_str, MAX_KEY_LEN - 1,
					blkg->stats.unaccounted_time, cb, dev);
822 823 824 825 826 827 828 829 830
	if (type == BLKIO_STAT_AVG_QUEUE_SIZE) {
		uint64_t sum = blkg->stats.avg_queue_size_sum;
		uint64_t samples = blkg->stats.avg_queue_size_samples;
		if (samples)
			do_div(sum, samples);
		else
			sum = 0;
		return blkio_fill_stat(key_str, MAX_KEY_LEN - 1, sum, cb, dev);
	}
831 832 833 834 835 836 837 838 839
	if (type == BLKIO_STAT_GROUP_WAIT_TIME)
		return blkio_fill_stat(key_str, MAX_KEY_LEN - 1,
					blkg->stats.group_wait_time, cb, dev);
	if (type == BLKIO_STAT_IDLE_TIME)
		return blkio_fill_stat(key_str, MAX_KEY_LEN - 1,
					blkg->stats.idle_time, cb, dev);
	if (type == BLKIO_STAT_EMPTY_TIME)
		return blkio_fill_stat(key_str, MAX_KEY_LEN - 1,
					blkg->stats.empty_time, cb, dev);
840 841 842 843
	if (type == BLKIO_STAT_DEQUEUE)
		return blkio_fill_stat(key_str, MAX_KEY_LEN - 1,
					blkg->stats.dequeue, cb, dev);
#endif
844

845 846 847 848
	for (sub_type = BLKIO_STAT_READ; sub_type < BLKIO_STAT_TOTAL;
			sub_type++) {
		blkio_get_key_name(sub_type, dev, key_str, MAX_KEY_LEN, false);
		cb->fill(cb, key_str, blkg->stats.stat_arr[type][sub_type]);
849
	}
850 851 852
	disk_total = blkg->stats.stat_arr[type][BLKIO_STAT_READ] +
			blkg->stats.stat_arr[type][BLKIO_STAT_WRITE];
	blkio_get_key_name(BLKIO_STAT_TOTAL, dev, key_str, MAX_KEY_LEN, false);
853 854 855 856
	cb->fill(cb, key_str, disk_total);
	return disk_total;
}

857
static int blkio_policy_parse_and_set(char *buf,
858 859 860
				      struct blkio_policy_node *newpn,
				      enum blkio_policy_id plid, int fileid,
				      struct blkio_cgroup *blkcg)
861
{
862
	struct gendisk *disk = NULL;
863
	struct blkio_group *blkg = NULL;
864
	char *s[4], *p, *major_s = NULL, *minor_s = NULL;
865
	unsigned long major, minor;
866 867
	int i = 0, ret = -EINVAL;
	int part;
868
	dev_t dev;
869
	u64 temp;
870 871 872 873 874 875 876 877 878 879 880 881 882 883 884

	memset(s, 0, sizeof(s));

	while ((p = strsep(&buf, " ")) != NULL) {
		if (!*p)
			continue;

		s[i++] = p;

		/* Prevent from inputing too many things */
		if (i == 3)
			break;
	}

	if (i != 2)
885
		goto out;
886 887 888 889 890

	p = strsep(&s[0], ":");
	if (p != NULL)
		major_s = p;
	else
891
		goto out;
892 893 894

	minor_s = s[0];
	if (!minor_s)
895
		goto out;
896

897 898
	if (strict_strtoul(major_s, 10, &major))
		goto out;
899

900 901
	if (strict_strtoul(minor_s, 10, &minor))
		goto out;
902 903 904

	dev = MKDEV(major, minor);

905 906
	if (strict_strtoull(s[1], 10, &temp))
		goto out;
907

908
	/* For rule removal, do not check for device presence. */
909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927
	disk = get_gendisk(dev, &part);

	if ((!disk || part) && temp) {
		ret = -ENODEV;
		goto out;
	}

	rcu_read_lock();

	if (disk && !part) {
		spin_lock_irq(disk->queue->queue_lock);
		blkg = blkg_lookup_create(blkcg, disk->queue, plid, false);
		spin_unlock_irq(disk->queue->queue_lock);

		if (IS_ERR(blkg)) {
			ret = PTR_ERR(blkg);
			if (ret == -EBUSY)
				goto out_unlock;
			blkg = NULL;
928
		}
929
	}
930

931
	newpn->dev = dev;
932

933 934
	switch (plid) {
	case BLKIO_POLICY_PROP:
935 936
		if ((temp < BLKIO_WEIGHT_MIN && temp > 0) ||
		     temp > BLKIO_WEIGHT_MAX)
937
			goto out_unlock;
938

939 940
		newpn->plid = plid;
		newpn->fileid = fileid;
941
		newpn->val.weight = temp;
942 943
		if (blkg)
			blkg->conf.weight = temp;
944 945
		break;
	case BLKIO_POLICY_THROTL:
946 947
		switch(fileid) {
		case BLKIO_THROTL_read_bps_device:
948 949 950 951 952 953
			if (blkg)
				blkg->conf.bps[READ] = temp;
			newpn->plid = plid;
			newpn->fileid = fileid;
			newpn->val.bps = temp;
			break;
954
		case BLKIO_THROTL_write_bps_device:
955 956
			if (blkg)
				blkg->conf.bps[WRITE] = temp;
957 958
			newpn->plid = plid;
			newpn->fileid = fileid;
959
			newpn->val.bps = temp;
960 961
			break;
		case BLKIO_THROTL_read_iops_device:
962 963 964 965 966 967 968 969 970
			if (temp > THROTL_IOPS_MAX)
				goto out_unlock;

			if (blkg)
				blkg->conf.iops[READ] = temp;
			newpn->plid = plid;
			newpn->fileid = fileid;
			newpn->val.iops = (unsigned int)temp;
			break;
971
		case BLKIO_THROTL_write_iops_device:
972
			if (temp > THROTL_IOPS_MAX)
973
				goto out_unlock;
974

975 976
			if (blkg)
				blkg->conf.iops[WRITE] = temp;
977 978
			newpn->plid = plid;
			newpn->fileid = fileid;
979
			newpn->val.iops = (unsigned int)temp;
980 981
			break;
		}
982 983 984 985
		break;
	default:
		BUG();
	}
986
	ret = 0;
987 988
out_unlock:
	rcu_read_unlock();
989 990
out:
	put_disk(disk);
991 992 993 994 995 996 997 998 999 1000 1001

	/*
	 * If queue was bypassing, we should retry.  Do so after a short
	 * msleep().  It isn't strictly necessary but queue can be
	 * bypassing for some time and it's always nice to avoid busy
	 * looping.
	 */
	if (ret == -EBUSY) {
		msleep(10);
		return restart_syscall();
	}
1002
	return ret;
1003 1004 1005 1006 1007 1008
}

unsigned int blkcg_get_weight(struct blkio_cgroup *blkcg,
			      dev_t dev)
{
	struct blkio_policy_node *pn;
1009 1010 1011 1012
	unsigned long flags;
	unsigned int weight;

	spin_lock_irqsave(&blkcg->lock, flags);
1013

1014 1015
	pn = blkio_policy_search_node(blkcg, dev, BLKIO_POLICY_PROP,
				BLKIO_PROP_weight_device);
1016
	if (pn)
1017
		weight = pn->val.weight;
1018
	else
1019 1020 1021 1022 1023
		weight = blkcg->weight;

	spin_unlock_irqrestore(&blkcg->lock, flags);

	return weight;
1024 1025 1026
}
EXPORT_SYMBOL_GPL(blkcg_get_weight);

1027 1028 1029
uint64_t blkcg_get_read_bps(struct blkio_cgroup *blkcg, dev_t dev)
{
	struct blkio_policy_node *pn;
1030 1031
	unsigned long flags;
	uint64_t bps = -1;
1032

1033
	spin_lock_irqsave(&blkcg->lock, flags);
1034 1035 1036
	pn = blkio_policy_search_node(blkcg, dev, BLKIO_POLICY_THROTL,
				BLKIO_THROTL_read_bps_device);
	if (pn)
1037 1038 1039 1040
		bps = pn->val.bps;
	spin_unlock_irqrestore(&blkcg->lock, flags);

	return bps;
1041 1042 1043 1044 1045
}

uint64_t blkcg_get_write_bps(struct blkio_cgroup *blkcg, dev_t dev)
{
	struct blkio_policy_node *pn;
1046 1047 1048 1049
	unsigned long flags;
	uint64_t bps = -1;

	spin_lock_irqsave(&blkcg->lock, flags);
1050 1051 1052
	pn = blkio_policy_search_node(blkcg, dev, BLKIO_POLICY_THROTL,
				BLKIO_THROTL_write_bps_device);
	if (pn)
1053 1054 1055 1056
		bps = pn->val.bps;
	spin_unlock_irqrestore(&blkcg->lock, flags);

	return bps;
1057 1058
}

1059 1060 1061
unsigned int blkcg_get_read_iops(struct blkio_cgroup *blkcg, dev_t dev)
{
	struct blkio_policy_node *pn;
1062 1063
	unsigned long flags;
	unsigned int iops = -1;
1064

1065
	spin_lock_irqsave(&blkcg->lock, flags);
1066 1067 1068
	pn = blkio_policy_search_node(blkcg, dev, BLKIO_POLICY_THROTL,
				BLKIO_THROTL_read_iops_device);
	if (pn)
1069 1070 1071 1072
		iops = pn->val.iops;
	spin_unlock_irqrestore(&blkcg->lock, flags);

	return iops;
1073 1074 1075 1076 1077
}

unsigned int blkcg_get_write_iops(struct blkio_cgroup *blkcg, dev_t dev)
{
	struct blkio_policy_node *pn;
1078 1079 1080 1081
	unsigned long flags;
	unsigned int iops = -1;

	spin_lock_irqsave(&blkcg->lock, flags);
1082 1083 1084
	pn = blkio_policy_search_node(blkcg, dev, BLKIO_POLICY_THROTL,
				BLKIO_THROTL_write_iops_device);
	if (pn)
1085 1086 1087 1088
		iops = pn->val.iops;
	spin_unlock_irqrestore(&blkcg->lock, flags);

	return iops;
1089 1090
}

1091 1092 1093 1094 1095
/* Checks whether user asked for deleting a policy rule */
static bool blkio_delete_rule_command(struct blkio_policy_node *pn)
{
	switch(pn->plid) {
	case BLKIO_POLICY_PROP:
1096 1097 1098 1099
		if (pn->val.weight == 0)
			return 1;
		break;
	case BLKIO_POLICY_THROTL:
1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110
		switch(pn->fileid) {
		case BLKIO_THROTL_read_bps_device:
		case BLKIO_THROTL_write_bps_device:
			if (pn->val.bps == 0)
				return 1;
			break;
		case BLKIO_THROTL_read_iops_device:
		case BLKIO_THROTL_write_iops_device:
			if (pn->val.iops == 0)
				return 1;
		}
1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123
		break;
	default:
		BUG();
	}

	return 0;
}

static void blkio_update_policy_rule(struct blkio_policy_node *oldpn,
					struct blkio_policy_node *newpn)
{
	switch(oldpn->plid) {
	case BLKIO_POLICY_PROP:
1124 1125 1126
		oldpn->val.weight = newpn->val.weight;
		break;
	case BLKIO_POLICY_THROTL:
1127 1128 1129 1130 1131 1132 1133 1134 1135
		switch(newpn->fileid) {
		case BLKIO_THROTL_read_bps_device:
		case BLKIO_THROTL_write_bps_device:
			oldpn->val.bps = newpn->val.bps;
			break;
		case BLKIO_THROTL_read_iops_device:
		case BLKIO_THROTL_write_iops_device:
			oldpn->val.iops = newpn->val.iops;
		}
1136 1137 1138 1139 1140 1141 1142
		break;
	default:
		BUG();
	}
}

/*
L
Lucas De Marchi 已提交
1143
 * Some rules/values in blkg have changed. Propagate those to respective
1144 1145 1146 1147 1148
 * policies.
 */
static void blkio_update_blkg_policy(struct blkio_cgroup *blkcg,
		struct blkio_group *blkg, struct blkio_policy_node *pn)
{
1149
	struct blkio_group_conf *conf = &blkg->conf;
1150 1151 1152

	switch(pn->plid) {
	case BLKIO_POLICY_PROP:
1153
		blkio_update_group_weight(blkg, conf->weight ?: blkcg->weight);
1154
		break;
1155 1156 1157
	case BLKIO_POLICY_THROTL:
		switch(pn->fileid) {
		case BLKIO_THROTL_read_bps_device:
1158 1159 1160
			blkio_update_group_bps(blkg, conf->bps[READ] ?: -1,
					       pn->fileid);
			break;
1161
		case BLKIO_THROTL_write_bps_device:
1162 1163
			blkio_update_group_bps(blkg, conf->bps[WRITE] ?: -1,
					       pn->fileid);
1164
			break;
1165
		case BLKIO_THROTL_read_iops_device:
1166 1167 1168
			blkio_update_group_iops(blkg, conf->iops[READ] ?: -1,
						pn->fileid);
			break;
1169
		case BLKIO_THROTL_write_iops_device:
1170 1171
			blkio_update_group_iops(blkg, conf->iops[WRITE] ?: -1,
						pn->fileid);
1172
			break;
1173 1174
		}
		break;
1175 1176 1177 1178 1179 1180
	default:
		BUG();
	}
}

/*
L
Lucas De Marchi 已提交
1181
 * A policy node rule has been updated. Propagate this update to all the
1182 1183 1184 1185 1186 1187 1188 1189 1190 1191
 * block groups which might be affected by this update.
 */
static void blkio_update_policy_node_blkg(struct blkio_cgroup *blkcg,
				struct blkio_policy_node *pn)
{
	struct blkio_group *blkg;
	struct hlist_node *n;

	spin_lock(&blkio_list_lock);
	spin_lock_irq(&blkcg->lock);
1192

1193 1194 1195 1196 1197 1198 1199 1200 1201
	hlist_for_each_entry(blkg, n, &blkcg->blkg_list, blkcg_node) {
		if (pn->dev != blkg->dev || pn->plid != blkg->plid)
			continue;
		blkio_update_blkg_policy(blkcg, blkg, pn);
	}

	spin_unlock_irq(&blkcg->lock);
	spin_unlock(&blkio_list_lock);
}
1202

1203 1204
static int blkiocg_file_write(struct cgroup *cgrp, struct cftype *cft,
 				       const char *buffer)
1205 1206 1207 1208
{
	int ret = 0;
	char *buf;
	struct blkio_policy_node *newpn, *pn;
1209
	struct blkio_cgroup *blkcg = cgroup_to_blkio_cgroup(cgrp);
1210
	int keep_newpn = 0;
1211 1212
	enum blkio_policy_id plid = BLKIOFILE_POLICY(cft->private);
	int fileid = BLKIOFILE_ATTR(cft->private);
1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223

	buf = kstrdup(buffer, GFP_KERNEL);
	if (!buf)
		return -ENOMEM;

	newpn = kzalloc(sizeof(*newpn), GFP_KERNEL);
	if (!newpn) {
		ret = -ENOMEM;
		goto free_buf;
	}

1224
	ret = blkio_policy_parse_and_set(buf, newpn, plid, fileid, blkcg);
1225 1226 1227 1228 1229
	if (ret)
		goto free_newpn;

	spin_lock_irq(&blkcg->lock);

1230
	pn = blkio_policy_search_node(blkcg, newpn->dev, plid, fileid);
1231
	if (!pn) {
1232
		if (!blkio_delete_rule_command(newpn)) {
1233 1234 1235 1236 1237 1238 1239
			blkio_policy_insert_node(blkcg, newpn);
			keep_newpn = 1;
		}
		spin_unlock_irq(&blkcg->lock);
		goto update_io_group;
	}

1240
	if (blkio_delete_rule_command(newpn)) {
1241
		blkio_policy_delete_node(pn);
1242
		kfree(pn);
1243 1244 1245 1246 1247
		spin_unlock_irq(&blkcg->lock);
		goto update_io_group;
	}
	spin_unlock_irq(&blkcg->lock);

1248
	blkio_update_policy_rule(pn, newpn);
1249 1250

update_io_group:
1251
	blkio_update_policy_node_blkg(blkcg, newpn);
1252 1253 1254 1255 1256 1257 1258 1259 1260

free_newpn:
	if (!keep_newpn)
		kfree(newpn);
free_buf:
	kfree(buf);
	return ret;
}

1261 1262
static void
blkio_print_policy_node(struct seq_file *m, struct blkio_policy_node *pn)
1263
{
1264 1265 1266 1267
	switch(pn->plid) {
		case BLKIO_POLICY_PROP:
			if (pn->fileid == BLKIO_PROP_weight_device)
				seq_printf(m, "%u:%u\t%u\n", MAJOR(pn->dev),
1268 1269 1270
					MINOR(pn->dev), pn->val.weight);
			break;
		case BLKIO_POLICY_THROTL:
1271 1272 1273
			switch(pn->fileid) {
			case BLKIO_THROTL_read_bps_device:
			case BLKIO_THROTL_write_bps_device:
1274 1275
				seq_printf(m, "%u:%u\t%llu\n", MAJOR(pn->dev),
					MINOR(pn->dev), pn->val.bps);
1276 1277 1278 1279 1280 1281 1282
				break;
			case BLKIO_THROTL_read_iops_device:
			case BLKIO_THROTL_write_iops_device:
				seq_printf(m, "%u:%u\t%u\n", MAJOR(pn->dev),
					MINOR(pn->dev), pn->val.iops);
				break;
			}
1283 1284 1285 1286 1287
			break;
		default:
			BUG();
	}
}
1288

1289 1290 1291
/* cgroup files which read their data from policy nodes end up here */
static void blkio_read_policy_node_files(struct cftype *cft,
			struct blkio_cgroup *blkcg, struct seq_file *m)
1292 1293 1294
{
	struct blkio_policy_node *pn;

1295 1296 1297
	if (!list_empty(&blkcg->policy_list)) {
		spin_lock_irq(&blkcg->lock);
		list_for_each_entry(pn, &blkcg->policy_list, node) {
1298 1299 1300
			if (!pn_matches_cftype(cft, pn))
				continue;
			blkio_print_policy_node(m, pn);
1301 1302
		}
		spin_unlock_irq(&blkcg->lock);
1303
	}
1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324
}

static int blkiocg_file_read(struct cgroup *cgrp, struct cftype *cft,
				struct seq_file *m)
{
	struct blkio_cgroup *blkcg;
	enum blkio_policy_id plid = BLKIOFILE_POLICY(cft->private);
	int name = BLKIOFILE_ATTR(cft->private);

	blkcg = cgroup_to_blkio_cgroup(cgrp);

	switch(plid) {
	case BLKIO_POLICY_PROP:
		switch(name) {
		case BLKIO_PROP_weight_device:
			blkio_read_policy_node_files(cft, blkcg, m);
			return 0;
		default:
			BUG();
		}
		break;
1325 1326 1327 1328
	case BLKIO_POLICY_THROTL:
		switch(name){
		case BLKIO_THROTL_read_bps_device:
		case BLKIO_THROTL_write_bps_device:
1329 1330
		case BLKIO_THROTL_read_iops_device:
		case BLKIO_THROTL_write_iops_device:
1331 1332 1333 1334 1335 1336
			blkio_read_policy_node_files(cft, blkcg, m);
			return 0;
		default:
			BUG();
		}
		break;
1337 1338 1339 1340 1341 1342 1343 1344
	default:
		BUG();
	}

	return 0;
}

static int blkio_read_blkg_stats(struct blkio_cgroup *blkcg,
1345 1346
		struct cftype *cft, struct cgroup_map_cb *cb,
		enum stat_type type, bool show_total, bool pcpu)
1347 1348 1349 1350 1351 1352 1353 1354 1355 1356
{
	struct blkio_group *blkg;
	struct hlist_node *n;
	uint64_t cgroup_total = 0;

	rcu_read_lock();
	hlist_for_each_entry_rcu(blkg, n, &blkcg->blkg_list, blkcg_node) {
		if (blkg->dev) {
			if (!cftype_blkg_same_policy(cft, blkg))
				continue;
1357 1358 1359 1360 1361 1362 1363 1364 1365
			if (pcpu)
				cgroup_total += blkio_get_stat_cpu(blkg, cb,
						blkg->dev, type);
			else {
				spin_lock_irq(&blkg->stats_lock);
				cgroup_total += blkio_get_stat(blkg, cb,
						blkg->dev, type);
				spin_unlock_irq(&blkg->stats_lock);
			}
1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388
		}
	}
	if (show_total)
		cb->fill(cb, "Total", cgroup_total);
	rcu_read_unlock();
	return 0;
}

/* All map kind of cgroup file get serviced by this function */
static int blkiocg_file_read_map(struct cgroup *cgrp, struct cftype *cft,
				struct cgroup_map_cb *cb)
{
	struct blkio_cgroup *blkcg;
	enum blkio_policy_id plid = BLKIOFILE_POLICY(cft->private);
	int name = BLKIOFILE_ATTR(cft->private);

	blkcg = cgroup_to_blkio_cgroup(cgrp);

	switch(plid) {
	case BLKIO_POLICY_PROP:
		switch(name) {
		case BLKIO_PROP_time:
			return blkio_read_blkg_stats(blkcg, cft, cb,
1389
						BLKIO_STAT_TIME, 0, 0);
1390 1391
		case BLKIO_PROP_sectors:
			return blkio_read_blkg_stats(blkcg, cft, cb,
1392
						BLKIO_STAT_CPU_SECTORS, 0, 1);
1393 1394
		case BLKIO_PROP_io_service_bytes:
			return blkio_read_blkg_stats(blkcg, cft, cb,
1395
					BLKIO_STAT_CPU_SERVICE_BYTES, 1, 1);
1396 1397
		case BLKIO_PROP_io_serviced:
			return blkio_read_blkg_stats(blkcg, cft, cb,
1398
						BLKIO_STAT_CPU_SERVICED, 1, 1);
1399 1400
		case BLKIO_PROP_io_service_time:
			return blkio_read_blkg_stats(blkcg, cft, cb,
1401
						BLKIO_STAT_SERVICE_TIME, 1, 0);
1402 1403
		case BLKIO_PROP_io_wait_time:
			return blkio_read_blkg_stats(blkcg, cft, cb,
1404
						BLKIO_STAT_WAIT_TIME, 1, 0);
1405 1406
		case BLKIO_PROP_io_merged:
			return blkio_read_blkg_stats(blkcg, cft, cb,
1407
						BLKIO_STAT_CPU_MERGED, 1, 1);
1408 1409
		case BLKIO_PROP_io_queued:
			return blkio_read_blkg_stats(blkcg, cft, cb,
1410
						BLKIO_STAT_QUEUED, 1, 0);
1411
#ifdef CONFIG_DEBUG_BLK_CGROUP
1412 1413
		case BLKIO_PROP_unaccounted_time:
			return blkio_read_blkg_stats(blkcg, cft, cb,
1414
					BLKIO_STAT_UNACCOUNTED_TIME, 0, 0);
1415 1416
		case BLKIO_PROP_dequeue:
			return blkio_read_blkg_stats(blkcg, cft, cb,
1417
						BLKIO_STAT_DEQUEUE, 0, 0);
1418 1419
		case BLKIO_PROP_avg_queue_size:
			return blkio_read_blkg_stats(blkcg, cft, cb,
1420
					BLKIO_STAT_AVG_QUEUE_SIZE, 0, 0);
1421 1422
		case BLKIO_PROP_group_wait_time:
			return blkio_read_blkg_stats(blkcg, cft, cb,
1423
					BLKIO_STAT_GROUP_WAIT_TIME, 0, 0);
1424 1425
		case BLKIO_PROP_idle_time:
			return blkio_read_blkg_stats(blkcg, cft, cb,
1426
						BLKIO_STAT_IDLE_TIME, 0, 0);
1427 1428
		case BLKIO_PROP_empty_time:
			return blkio_read_blkg_stats(blkcg, cft, cb,
1429
						BLKIO_STAT_EMPTY_TIME, 0, 0);
1430 1431 1432 1433 1434
#endif
		default:
			BUG();
		}
		break;
1435 1436 1437 1438
	case BLKIO_POLICY_THROTL:
		switch(name){
		case BLKIO_THROTL_io_service_bytes:
			return blkio_read_blkg_stats(blkcg, cft, cb,
1439
						BLKIO_STAT_CPU_SERVICE_BYTES, 1, 1);
1440 1441
		case BLKIO_THROTL_io_serviced:
			return blkio_read_blkg_stats(blkcg, cft, cb,
1442
						BLKIO_STAT_CPU_SERVICED, 1, 1);
1443 1444 1445 1446
		default:
			BUG();
		}
		break;
1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479 1480 1481 1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518
	default:
		BUG();
	}

	return 0;
}

static int blkio_weight_write(struct blkio_cgroup *blkcg, u64 val)
{
	struct blkio_group *blkg;
	struct hlist_node *n;
	struct blkio_policy_node *pn;

	if (val < BLKIO_WEIGHT_MIN || val > BLKIO_WEIGHT_MAX)
		return -EINVAL;

	spin_lock(&blkio_list_lock);
	spin_lock_irq(&blkcg->lock);
	blkcg->weight = (unsigned int)val;

	hlist_for_each_entry(blkg, n, &blkcg->blkg_list, blkcg_node) {
		pn = blkio_policy_search_node(blkcg, blkg->dev,
				BLKIO_POLICY_PROP, BLKIO_PROP_weight_device);
		if (pn)
			continue;

		blkio_update_group_weight(blkg, blkcg->weight);
	}
	spin_unlock_irq(&blkcg->lock);
	spin_unlock(&blkio_list_lock);
	return 0;
}

static u64 blkiocg_file_read_u64 (struct cgroup *cgrp, struct cftype *cft) {
	struct blkio_cgroup *blkcg;
	enum blkio_policy_id plid = BLKIOFILE_POLICY(cft->private);
	int name = BLKIOFILE_ATTR(cft->private);

	blkcg = cgroup_to_blkio_cgroup(cgrp);

	switch(plid) {
	case BLKIO_POLICY_PROP:
		switch(name) {
		case BLKIO_PROP_weight:
			return (u64)blkcg->weight;
		}
		break;
	default:
		BUG();
	}
	return 0;
}

static int
blkiocg_file_write_u64(struct cgroup *cgrp, struct cftype *cft, u64 val)
{
	struct blkio_cgroup *blkcg;
	enum blkio_policy_id plid = BLKIOFILE_POLICY(cft->private);
	int name = BLKIOFILE_ATTR(cft->private);

	blkcg = cgroup_to_blkio_cgroup(cgrp);

	switch(plid) {
	case BLKIO_POLICY_PROP:
		switch(name) {
		case BLKIO_PROP_weight:
			return blkio_weight_write(blkcg, val);
		}
		break;
	default:
		BUG();
	}
1519 1520 1521 1522

	return 0;
}

1523
struct cftype blkio_files[] = {
1524 1525
	{
		.name = "weight_device",
1526 1527 1528 1529
		.private = BLKIOFILE_PRIVATE(BLKIO_POLICY_PROP,
				BLKIO_PROP_weight_device),
		.read_seq_string = blkiocg_file_read,
		.write_string = blkiocg_file_write,
1530 1531
		.max_write_len = 256,
	},
1532 1533
	{
		.name = "weight",
1534 1535 1536 1537
		.private = BLKIOFILE_PRIVATE(BLKIO_POLICY_PROP,
				BLKIO_PROP_weight),
		.read_u64 = blkiocg_file_read_u64,
		.write_u64 = blkiocg_file_write_u64,
1538
	},
1539 1540
	{
		.name = "time",
1541 1542 1543
		.private = BLKIOFILE_PRIVATE(BLKIO_POLICY_PROP,
				BLKIO_PROP_time),
		.read_map = blkiocg_file_read_map,
1544 1545 1546
	},
	{
		.name = "sectors",
1547 1548 1549
		.private = BLKIOFILE_PRIVATE(BLKIO_POLICY_PROP,
				BLKIO_PROP_sectors),
		.read_map = blkiocg_file_read_map,
1550 1551 1552
	},
	{
		.name = "io_service_bytes",
1553 1554 1555
		.private = BLKIOFILE_PRIVATE(BLKIO_POLICY_PROP,
				BLKIO_PROP_io_service_bytes),
		.read_map = blkiocg_file_read_map,
1556 1557 1558
	},
	{
		.name = "io_serviced",
1559 1560 1561
		.private = BLKIOFILE_PRIVATE(BLKIO_POLICY_PROP,
				BLKIO_PROP_io_serviced),
		.read_map = blkiocg_file_read_map,
1562 1563 1564
	},
	{
		.name = "io_service_time",
1565 1566 1567
		.private = BLKIOFILE_PRIVATE(BLKIO_POLICY_PROP,
				BLKIO_PROP_io_service_time),
		.read_map = blkiocg_file_read_map,
1568 1569 1570
	},
	{
		.name = "io_wait_time",
1571 1572 1573
		.private = BLKIOFILE_PRIVATE(BLKIO_POLICY_PROP,
				BLKIO_PROP_io_wait_time),
		.read_map = blkiocg_file_read_map,
1574
	},
D
Divyesh Shah 已提交
1575 1576
	{
		.name = "io_merged",
1577 1578 1579
		.private = BLKIOFILE_PRIVATE(BLKIO_POLICY_PROP,
				BLKIO_PROP_io_merged),
		.read_map = blkiocg_file_read_map,
D
Divyesh Shah 已提交
1580
	},
1581 1582
	{
		.name = "io_queued",
1583 1584 1585
		.private = BLKIOFILE_PRIVATE(BLKIO_POLICY_PROP,
				BLKIO_PROP_io_queued),
		.read_map = blkiocg_file_read_map,
1586
	},
1587 1588 1589
	{
		.name = "reset_stats",
		.write_u64 = blkiocg_reset_stats,
1590
	},
1591 1592 1593 1594 1595 1596 1597 1598 1599 1600 1601 1602 1603 1604 1605 1606 1607 1608 1609 1610 1611 1612 1613 1614 1615 1616 1617 1618 1619 1620 1621 1622 1623 1624 1625 1626 1627 1628 1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639 1640
#ifdef CONFIG_BLK_DEV_THROTTLING
	{
		.name = "throttle.read_bps_device",
		.private = BLKIOFILE_PRIVATE(BLKIO_POLICY_THROTL,
				BLKIO_THROTL_read_bps_device),
		.read_seq_string = blkiocg_file_read,
		.write_string = blkiocg_file_write,
		.max_write_len = 256,
	},

	{
		.name = "throttle.write_bps_device",
		.private = BLKIOFILE_PRIVATE(BLKIO_POLICY_THROTL,
				BLKIO_THROTL_write_bps_device),
		.read_seq_string = blkiocg_file_read,
		.write_string = blkiocg_file_write,
		.max_write_len = 256,
	},

	{
		.name = "throttle.read_iops_device",
		.private = BLKIOFILE_PRIVATE(BLKIO_POLICY_THROTL,
				BLKIO_THROTL_read_iops_device),
		.read_seq_string = blkiocg_file_read,
		.write_string = blkiocg_file_write,
		.max_write_len = 256,
	},

	{
		.name = "throttle.write_iops_device",
		.private = BLKIOFILE_PRIVATE(BLKIO_POLICY_THROTL,
				BLKIO_THROTL_write_iops_device),
		.read_seq_string = blkiocg_file_read,
		.write_string = blkiocg_file_write,
		.max_write_len = 256,
	},
	{
		.name = "throttle.io_service_bytes",
		.private = BLKIOFILE_PRIVATE(BLKIO_POLICY_THROTL,
				BLKIO_THROTL_io_service_bytes),
		.read_map = blkiocg_file_read_map,
	},
	{
		.name = "throttle.io_serviced",
		.private = BLKIOFILE_PRIVATE(BLKIO_POLICY_THROTL,
				BLKIO_THROTL_io_serviced),
		.read_map = blkiocg_file_read_map,
	},
#endif /* CONFIG_BLK_DEV_THROTTLING */

1641
#ifdef CONFIG_DEBUG_BLK_CGROUP
1642 1643
	{
		.name = "avg_queue_size",
1644 1645 1646
		.private = BLKIOFILE_PRIVATE(BLKIO_POLICY_PROP,
				BLKIO_PROP_avg_queue_size),
		.read_map = blkiocg_file_read_map,
1647
	},
1648 1649
	{
		.name = "group_wait_time",
1650 1651 1652
		.private = BLKIOFILE_PRIVATE(BLKIO_POLICY_PROP,
				BLKIO_PROP_group_wait_time),
		.read_map = blkiocg_file_read_map,
1653 1654 1655
	},
	{
		.name = "idle_time",
1656 1657 1658
		.private = BLKIOFILE_PRIVATE(BLKIO_POLICY_PROP,
				BLKIO_PROP_idle_time),
		.read_map = blkiocg_file_read_map,
1659 1660 1661
	},
	{
		.name = "empty_time",
1662 1663 1664
		.private = BLKIOFILE_PRIVATE(BLKIO_POLICY_PROP,
				BLKIO_PROP_empty_time),
		.read_map = blkiocg_file_read_map,
1665
	},
1666
	{
1667
		.name = "dequeue",
1668 1669 1670
		.private = BLKIOFILE_PRIVATE(BLKIO_POLICY_PROP,
				BLKIO_PROP_dequeue),
		.read_map = blkiocg_file_read_map,
1671
	},
1672 1673 1674 1675 1676 1677
	{
		.name = "unaccounted_time",
		.private = BLKIOFILE_PRIVATE(BLKIO_POLICY_PROP,
				BLKIO_PROP_unaccounted_time),
		.read_map = blkiocg_file_read_map,
	},
1678
#endif
1679 1680 1681 1682 1683 1684 1685 1686 1687 1688 1689
};

static int blkiocg_populate(struct cgroup_subsys *subsys, struct cgroup *cgroup)
{
	return cgroup_add_files(cgroup, subsys, blkio_files,
				ARRAY_SIZE(blkio_files));
}

static void blkiocg_destroy(struct cgroup_subsys *subsys, struct cgroup *cgroup)
{
	struct blkio_cgroup *blkcg = cgroup_to_blkio_cgroup(cgroup);
1690 1691
	unsigned long flags;
	struct blkio_group *blkg;
1692
	struct request_queue *q;
1693
	struct blkio_policy_type *blkiop;
1694
	struct blkio_policy_node *pn, *pntmp;
1695 1696

	rcu_read_lock();
1697 1698
	do {
		spin_lock_irqsave(&blkcg->lock, flags);
1699

1700 1701 1702 1703
		if (hlist_empty(&blkcg->blkg_list)) {
			spin_unlock_irqrestore(&blkcg->lock, flags);
			break;
		}
1704

1705 1706
		blkg = hlist_entry(blkcg->blkg_list.first, struct blkio_group,
					blkcg_node);
1707
		q = rcu_dereference(blkg->q);
1708
		__blkiocg_del_blkio_group(blkg);
1709

1710
		spin_unlock_irqrestore(&blkcg->lock, flags);
1711

1712 1713 1714
		/*
		 * This blkio_group is being unlinked as associated cgroup is
		 * going away. Let all the IO controlling policies know about
1715
		 * this event.
1716 1717
		 */
		spin_lock(&blkio_list_lock);
1718 1719 1720
		list_for_each_entry(blkiop, &blkio_list, list) {
			if (blkiop->plid != blkg->plid)
				continue;
1721
			blkiop->ops.blkio_unlink_group_fn(q, blkg);
1722
		}
1723 1724
		spin_unlock(&blkio_list_lock);
	} while (1);
1725 1726 1727 1728 1729

	list_for_each_entry_safe(pn, pntmp, &blkcg->policy_list, node) {
		blkio_policy_delete_node(pn);
		kfree(pn);
	}
1730

1731
	free_css_id(&blkio_subsys, &blkcg->css);
1732
	rcu_read_unlock();
B
Ben Blum 已提交
1733 1734
	if (blkcg != &blkio_root_cgroup)
		kfree(blkcg);
1735 1736 1737 1738 1739
}

static struct cgroup_subsys_state *
blkiocg_create(struct cgroup_subsys *subsys, struct cgroup *cgroup)
{
1740 1741
	struct blkio_cgroup *blkcg;
	struct cgroup *parent = cgroup->parent;
1742

1743
	if (!parent) {
1744 1745 1746 1747 1748 1749 1750 1751 1752 1753 1754 1755 1756
		blkcg = &blkio_root_cgroup;
		goto done;
	}

	blkcg = kzalloc(sizeof(*blkcg), GFP_KERNEL);
	if (!blkcg)
		return ERR_PTR(-ENOMEM);

	blkcg->weight = BLKIO_WEIGHT_DEFAULT;
done:
	spin_lock_init(&blkcg->lock);
	INIT_HLIST_HEAD(&blkcg->blkg_list);

1757
	INIT_LIST_HEAD(&blkcg->policy_list);
1758 1759 1760 1761 1762 1763 1764 1765 1766
	return &blkcg->css;
}

/*
 * We cannot support shared io contexts, as we have no mean to support
 * two tasks with the same ioc in two different groups without major rework
 * of the main cic data structures.  For now we allow a task to change
 * its cgroup only if it's the only owner of its ioc.
 */
1767 1768
static int blkiocg_can_attach(struct cgroup_subsys *ss, struct cgroup *cgrp,
			      struct cgroup_taskset *tset)
1769
{
1770
	struct task_struct *task;
1771 1772 1773 1774
	struct io_context *ioc;
	int ret = 0;

	/* task_lock() is needed to avoid races with exit_io_context() */
1775 1776 1777 1778 1779 1780 1781 1782 1783
	cgroup_taskset_for_each(task, cgrp, tset) {
		task_lock(task);
		ioc = task->io_context;
		if (ioc && atomic_read(&ioc->nr_tasks) > 1)
			ret = -EINVAL;
		task_unlock(task);
		if (ret)
			break;
	}
1784 1785 1786
	return ret;
}

1787 1788
static void blkiocg_attach(struct cgroup_subsys *ss, struct cgroup *cgrp,
			   struct cgroup_taskset *tset)
1789
{
1790
	struct task_struct *task;
1791 1792
	struct io_context *ioc;

1793
	cgroup_taskset_for_each(task, cgrp, tset) {
1794 1795 1796 1797
		/* we don't lose anything even if ioc allocation fails */
		ioc = get_task_io_context(task, GFP_ATOMIC, NUMA_NO_NODE);
		if (ioc) {
			ioc_cgroup_changed(ioc);
1798
			put_io_context(ioc);
1799
		}
1800
	}
1801 1802
}

1803 1804 1805
void blkio_policy_register(struct blkio_policy_type *blkiop)
{
	spin_lock(&blkio_list_lock);
1806 1807 1808

	BUG_ON(blkio_policy[blkiop->plid]);
	blkio_policy[blkiop->plid] = blkiop;
1809
	list_add_tail(&blkiop->list, &blkio_list);
1810

1811 1812 1813 1814 1815 1816 1817
	spin_unlock(&blkio_list_lock);
}
EXPORT_SYMBOL_GPL(blkio_policy_register);

void blkio_policy_unregister(struct blkio_policy_type *blkiop)
{
	spin_lock(&blkio_list_lock);
1818 1819 1820

	BUG_ON(blkio_policy[blkiop->plid] != blkiop);
	blkio_policy[blkiop->plid] = NULL;
1821
	list_del_init(&blkiop->list);
1822

1823 1824 1825
	spin_unlock(&blkio_list_lock);
}
EXPORT_SYMBOL_GPL(blkio_policy_unregister);