1. 03 2月, 2023 2 次提交
    • C
      Remove NUMA setting for benchmark-linux (#11180) · fec5c8de
      changyubi 提交于
      Summary:
      benchmark-linux is failing on main branch after https://github.com/facebook/rocksdb/issues/11074 with the following error msg:
      ```
      /usr/bin/time -f '%e %U %S' -o /tmp/benchmark-results/8.0.0/benchmark_overwriteandwait.t1.s0.log.time numactl --interleave=all timeout 1200 ./db_bench --benchmarks=overwrite,waitforcompaction,stats --use_existing_db=1 --sync=0 --level0_file_num_compaction_trigger=4 --level0_slowdown_writes_trigger=20 --level0_stop_writes_trigger=30 --max_background_jobs=4 --max_write_buffer_number=8 --undefok=use_blob_cache,use_shared_block_and_blob_cache,blob_cache_size,blob_cache_numshardbits,prepopulate_blob_cache,multiread_batched,cache_low_pri_pool_ratio,prepopulate_block_cache --db=/tmp/rocksdb-benchmark-datadir --wal_dir=/tmp/rocksdb-benchmark-datadir --num=20000000 --key_size=20 --value_size=400 --block_size=8192 --cache_size=10737418240 --cache_numshardbits=6 --compression_max_dict_bytes=0 --compression_ratio=0.5 --compression_type=none --bytes_per_sync=1048576 --cache_index_and_filter_blocks=1 --cache_high_pri_pool_ratio=0.5 --cache_low_pri_pool_ratio=0 --benchmark_write_rate_limit=0 --write_buffer_size=16777216 --target_file_size_base=16777216 --max_bytes_for_level_base=67108864 --verify_checksum=1 --delete_obsolete_files_period_micros=62914560 --max_bytes_for_level_multiplier=8 --statistics=0 --stats_per_interval=1 --stats_interval_seconds=20 --report_interval_seconds=1 --histogram=1 --memtablerep=skip_list --bloom_bits=10 --open_files=-1 --subcompactions=1 --compaction_style=0 --num_levels=8 --min_level_to_compress=3 --level_compaction_dynamic_level_bytes=true --pin_l0_filter_and_index_blocks_in_cache=1 --duration=600 --threads=1 --merge_operator="put" --seed=1675372532 --report_file=/tmp/benchmark-results/8.0.0/benchmark_overwriteandwait.t1.s0.log.r.csv 2>&1 | tee -a /tmp/benchmark-results/8.0.0/benchmark_overwriteandwait.t1.s0.log
      /usr/bin/time: cannot run numactl: No such file or directory
      ```
      This PR removes the newly added NUMA setting.
      
      Pull Request resolved: https://github.com/facebook/rocksdb/pull/11180
      
      Test Plan: check next main branch run for benchmark-linux
      
      Reviewed By: ajkr
      
      Differential Revision: D42975930
      
      Pulled By: cbi42
      
      fbshipit-source-id: f084d39aeba9877c0752502e879c5e612b507653
      fec5c8de
    • A
      CI Benchmarking. Small configuration changes based on performance analysis. (#11074) · 6781009e
      Alan Paxton 提交于
      Summary:
      First, we made a small reduction in DURATION_RW as runs were exceeding 1 hour and colliding with subsequent runs.
      
      See Mark Callaghan’s blog post at http://smalldatum.blogspot.com/2023/01/variance-in-rocksdb-benchmarks-on-cloud.html
      
      Configuration parameters which are not consistent with the following email from Mark (see the blog post for more context) have been updated. Where Mark has defined the parameter and we haven't, we define it explicitly. We will need to further monitor for an expected reduction in variance of test times:
      
      To match what I did:
       ---
      
      nsecs=1800
      dbdir=/data/m/rx
      resultdir=bm.lc.nt1.cm1.d0
      
      env WRITE_BUFFER_SIZE_MB=16 TARGET_FILE_SIZE_BASE_MB=16 MAX_BYTES_FOR_LEVEL_BASE_MB=64 MAX_BACKGROUND_JOBS=4 NUM_KEYS=20000000 CACHE_SIZE_MB=10240 DURATION_RW=$nsecs DURATION_RO=$nsecs MB_WRITE_PER_SEC=2 NUM_THREADS=1 COMPRESSION_TYPE=none CACHE_INDEX_AND_FILTER_BLOCKS=1 VALUE_SIZE=400 NUMA=1 MIN_LEVEL_TO_COMPRESS=3 COMPACTION_STYLE=leveled bash benchmark_compare.sh $dbdir $resultdir 7.8.fb
      
      env WRITE_BUFFER_SIZE_MB=16 TARGET_FILE_SIZE_BASE_MB=16 MAX_BYTES_FOR_LEVEL_BASE_MB=64 MAX_BACKGROUND_JOBS=4 NUM_KEYS=200000000 CACHE_SIZE_MB=10240 DURATION_RW=$nsecs DURATION_RO=$nsecs MB_WRITE_PER_SEC=2 NUM_THREADS=1 COMPRESSION_TYPE=lz4 CACHE_INDEX_AND_FILTER_BLOCKS=1 VALUE_SIZE=400 NUMA=1 MIN_LEVEL_TO_COMPRESS=3 COMPACTION_STYLE=leveled bash benchmark_compare.sh $dbdir $resultdir 7.8.fb
      
      Pull Request resolved: https://github.com/facebook/rocksdb/pull/11074
      
      Reviewed By: ajkr
      
      Differential Revision: D42969668
      
      Pulled By: cbi42
      
      fbshipit-source-id: 1ea4e6a3901be4016108f93817eb58f74baac21a
      6781009e
  2. 21 9月, 2022 1 次提交
  3. 26 8月, 2022 1 次提交
    • A
      CI benchmarks refine configuration (#10514) · 7fbee01f
      Alan Paxton 提交于
      Summary:
      CI benchmarks refine configuration
      
      Run only “essential” benchmarks, but for longer
      Fix (reduce) the NUM_KEYS to ensure cached behaviour
      Reduce level size to try to ensure more levels
      
      Refine test durations again, more time per test, but fewer tests.
      In CI benchmark mode, the only read test is readrandom.
      There are still 3 mostly-read tests.
      
      Goal is to squeeze complete run a little bit inside 1 hour so it doesn’t clash with the next run (cron scheduled for main branch), but it gets to run as long as possible, so that results are as credible as possible.
      
      Reduce thread count to physical capacity, in an attempt to reduce throughput variance for write heavy tests. See Mark Callaghan’s comments in related documentation..
      
      Pull Request resolved: https://github.com/facebook/rocksdb/pull/10514
      
      Reviewed By: ajkr
      
      Differential Revision: D38952469
      
      Pulled By: jay-zhuang
      
      fbshipit-source-id: 72fa6bba897cc47066ced65facd1fd36e28f30a8
      7fbee01f
  4. 26 7月, 2022 1 次提交