1. 11 11月, 2013 1 次提交
  2. 24 10月, 2013 1 次提交
  3. 23 10月, 2013 1 次提交
    • M
      Dbid feature · 9b50106f
      Mayank Agarwal 提交于
      Summary:
      Create a new type of file on startup if it doesn't already exist called DBID.
      This will store a unique number generated from boost library's uuid header file.
      The use-case is to identify the case of a db losing all its data and coming back up either empty or from an image(backup/live replica's recovery)
      the key point to note is that DBID is not stored in a backup or db snapshot
      It's preferable to use Boost for uuid because:
      1) A non-standard way of generating uuid is not good
      2) /proc/sys/kernel/random/uuid generates a uuid but only on linux environments and the solution would not be clean
      3) c++ doesn't have any direct way to get a uuid
      4) Boost is a very good library that was already having linkage in rocksdb from third-party
      Note: I had to update the TOOLCHAIN_REV in build files to get latest verison of boost from third-party as the older version had a bug.
      I had to put Wno-uninitialized in Makefile because boost-1.51 has an unitialized variable and rocksdb would not comiple otherwise. Latet open-source for boost is 1.54 but is not there in third-party. I have notified the concerned people in fbcode about it.
      @kailiu : While releasing to third-party, an additional dependency will need to be created for boost in TARGETS file. I can help identify.
      
      Test Plan:
      Expand db_test to test 2 cases
      1) Restarting db with Id file present - verify that no change to Id
      2)Restarting db with Id file deleted - verify that a different Id is there after reopen
      Also run make all check
      
      Reviewers: dhruba, haobo, kailiu, sdong
      
      Reviewed By: dhruba
      
      CC: leveldb
      
      Differential Revision: https://reviews.facebook.net/D13587
      9b50106f
  4. 16 8月, 2013 1 次提交
    • K
      Clean up the Makefile and the build scripts · 457dcc60
      Kai Liu 提交于
      Summary: As Aaron suggested, there are quite some problems with our Makefile and scripts. So in this diff I did some cleanup for them and revise some part of the scripts/makefile to help people better understand some mysterious parts.
      
      Test Plan:
      Ran make in several modes;
      Ran the updated scripts.
      
      Reviewers: dhruba, emayanke, akushner
      
      Differential Revision: https://reviews.facebook.net/D12285
      457dcc60
  5. 26 1月, 2013 1 次提交
  6. 16 1月, 2013 1 次提交
    • C
      Add optional clang compile mode · a2dcd79c
      Chip Turner 提交于
      Summary:
      clang is an alternate compiler based on llvm.  It produces
      nicer error messages and finds some bugs that gcc doesn't, such as the
      size_t change in this file (which caused some write return values to be
      misinterpreted!)
      
      Clang isn't the default; to try it, do "USE_CLANG=1 make" or "export
      USE_CLANG=1" then make as normal
      
      Test Plan: "make check" and "USE_CLANG=1 make check"
      
      Reviewers: dhruba
      
      Reviewed By: dhruba
      
      Differential Revision: https://reviews.facebook.net/D7899
      a2dcd79c
  7. 15 1月, 2013 1 次提交
    • C
      Various build cleanups/improvements · c0cb289d
      Chip Turner 提交于
      Summary:
      Specific changes:
      
      1) Turn on -Werror so all warnings are errors
      2) Fix some warnings the above now complains about
      3) Add proper dependency support so changing a .h file forces a .c file
      to rebuild
      4) Automatically use fbcode gcc on any internal machine rather than
      whatever system compiler is laying around
      5) Fix jemalloc to once again be used in the builds (seemed like it
      wasn't being?)
      6) Fix issue where 'git' would fail in build_detect_version because of
      LD_LIBRARY_PATH being set in the third-party build system
      
      Test Plan:
      make, make check, make clean, touch a header file, make sure
      rebuild is expected
      
      Reviewers: dhruba
      
      Reviewed By: dhruba
      
      Differential Revision: https://reviews.facebook.net/D7887
      c0cb289d
  8. 28 12月, 2012 1 次提交
  9. 21 12月, 2012 1 次提交
    • Z
      Add libevent include and lib directories · 58d14444
      Zheng Shao 提交于
      Summary:
      Without this fix, I see failures like this:
      [zshao@dev1049 /data/users/zshao/rocksdb] . fbcode.gcc471.sh; gmake clean libleveldb.a
      . . .
      ./thrift/lib/cpp/async/TEventUtil.h:22:32: fatal error: event.h: No such file or directory
      
      Test Plan: . fbcode.gcc471.sh; make clean libleveldb.a
      
      Reviewers: dhruba, emayanke, sheki
      
      Reviewed By: sheki
      
      CC: leveldb
      
      Differential Revision: https://reviews.facebook.net/D7497
      58d14444
  10. 22 11月, 2012 1 次提交
    • C
      Fix ldb segfault and use static libsnappy for all builds · 879e45eb
      Chip Turner 提交于
      Summary:
      Link statically against snappy, using the gvfs one for facebook
      environments, and the bundled one otherwise.
      
      In addition, fix a few minor segfaults in ldb when it couldn't open the
      database, and update .gitignore to include a few other build artifacts.
      
      Test Plan: make check
      
      Reviewers: dhruba
      
      Reviewed By: dhruba
      
      CC: leveldb
      
      Differential Revision: https://reviews.facebook.net/D6855
      879e45eb
  11. 14 11月, 2012 1 次提交
    • D
      Make sse compilation optional. · 33cf6f3b
      Dhruba Borthakur 提交于
      Summary:
      The fbcode compilation was always switching on msse by default.
      This patch keeps the same behaviour but allows the compilation
      process to switch off msse if needed.
      
      If one does not want to use sse, then do the following:
      export USE_SSE=0
      make clean all
      
      Test Plan: make clean all
      
      Reviewers: heyongqiang
      
      Reviewed By: heyongqiang
      
      CC: leveldb
      
      Differential Revision: https://reviews.facebook.net/D6717
      33cf6f3b
  12. 18 10月, 2012 1 次提交
  13. 18 9月, 2012 2 次提交
  14. 05 9月, 2012 2 次提交
  15. 22 8月, 2012 1 次提交
  16. 18 8月, 2012 1 次提交
  17. 08 7月, 2012 1 次提交
  18. 21 6月, 2012 1 次提交
  19. 19 6月, 2012 1 次提交
  20. 16 6月, 2012 1 次提交
  21. 14 6月, 2012 1 次提交
  22. 15 5月, 2012 1 次提交