Skip to content

R
rocksdb

kvdb / rocksdb
11 个月 前同步成功

通知 0
Star 0
Fork 0
R
rocksdb

体验新版 GitCode，发现更多精彩内容 >>

切换分支/标签
  1. 08 11月, 2014 12 次提交
    • I
      Get rid of mutex in CompactionJob's state · e3d3567b
      由 Igor Canadi 提交于 
      Summary: Based on @sdong's feedback in the diff, we shouldn't keep db_mutex in CompactionJob's state. This diff removes db_mutex from CompactionJob state, by making next_file_number_ atomic. That way we only need to pass the lock to InstallCompactionResults() because of LogAndApply()

Test Plan: make check

Reviewers: ljin, yhchiang, rven, sdong

Reviewed By: sdong

Subscribers: sdong, dhruba, leveldb

Differential Revision: https://reviews.facebook.net/D28491
      e3d3567b
    • Y
      Fixed the shadowing in db/compaction.cc and include/rocksdb/db.h · 344edbb0
      由 Yueh-Hsuan Chiang 提交于 
      Summary:
Fixed the shadowing in db/compaction.cc and include/rocksdb/db.h

Test Plan:
make
      344edbb0
    • Y
      Fixed compile error in db/db_impl.cc · b8b39034
      由 Yueh-Hsuan Chiang 提交于 
      Summary:
Fixed compile error in db/db_impl.cc

Test Plan:
make
      b8b39034
    • Y
      Fixed compile error in db/flush_job.cc · b622ba5d
      由 Yueh-Hsuan Chiang 提交于 
      Summary:
Fixed compile error in db/flush_job.cc

Test Plan:
make
      b622ba5d
    • Y
      Fixed compile error in db/compaction.cc and db/compaction_picker.cc · 642ac9d8
      由 Yueh-Hsuan Chiang 提交于 
      Summary:
Fixed compile error in db/compaction.cc and db/compaction_picker.cc

Test Plan:
make
      642ac9d8
    • I
      Fix -Wshadow for tools · 68effa03
      由 Igor Canadi 提交于 
      Summary: Previously I made `make check` work with -Wshadow, but there are some tools that are not compiled using `make check`.

Test Plan: make all

Reviewers: yhchiang, rven, ljin, sdong

Reviewed By: ljin, sdong

Subscribers: dhruba, leveldb

Differential Revision: https://reviews.facebook.net/D28497
      68effa03
    • Y
      Fixed -WShadow errors in db/db_test.cc and include/rocksdb/metadata.h · 84478618
      由 Yueh-Hsuan Chiang 提交于 
      Summary:
Fixed -WShadow errors in db/db_test.cc and include/rocksdb/metadata.h

Test Plan:
make
      84478618
    • Y
      CompactFiles, EventListener and GetDatabaseMetaData · 28c82ff1
      由 Yueh-Hsuan Chiang 提交于 
      Summary:
This diff adds three sets of APIs to RocksDB.

= GetColumnFamilyMetaData =
* This APIs allow users to obtain the current state of a RocksDB instance on one column family.
* See GetColumnFamilyMetaData in include/rocksdb/db.h

= EventListener =
* A virtual class that allows users to implement a set of
  call-back functions which will be called when specific
  events of a RocksDB instance happens.
* To register EventListener, simply insert an EventListener to ColumnFamilyOptions::listeners

= CompactFiles =
* CompactFiles API inputs a set of file numbers and an output level, and RocksDB
  will try to compact those files into the specified level.

= Example =
* Example code can be found in example/compact_files_example.cc, which implements
  a simple external compactor using EventListener, GetColumnFamilyMetaData, and
  CompactFiles API.

Test Plan:
listener_test
compactor_test
example/compact_files_example
export ROCKSDB_TESTS=CompactFiles
db_test
export ROCKSDB_TESTS=MetaData
db_test

Reviewers: ljin, igor, rven, sdong

Reviewed By: sdong

Subscribers: MarkCallaghan, dhruba, leveldb

Differential Revision: https://reviews.facebook.net/D24705
      28c82ff1
    • I
      Turn on -Wshadow · 5c930905
      由 Igor Canadi 提交于 
      Summary:
Only one more try, I promise.

I talked to Jim and he mentioned that if we include our system includes with -isystem rather than with -I, that signals to the compile that those are system includes and thus no warnings are issued. So I turned our glibc includes into system includes and now we no longer get the warning from there, making us shadow-warning-free!

Test Plan: compiles with both clang and gcc

Reviewers: sdong, yhchiang, rven, ljin

Reviewed By: ljin

Subscribers: dhruba, leveldb

Differential Revision: https://reviews.facebook.net/D28479
      5c930905
    • I
      Fix implicit compare · 31342c40
      由 Igor Canadi 提交于
      31342c40
    • I
      Fix compile · a0f887c9
      由 Igor Canadi 提交于
      a0f887c9
    • I
      Redesign pending_outputs_ · 53af5d87
      由 Igor Canadi 提交于 
      Summary:
Here's a prototype of redesigning pending_outputs_. This way, we don't have to expose pending_outputs_ to other classes (CompactionJob, FlushJob, MemtableList). DBImpl takes care of it.

Still have to write some comments, but should be good enough to start the discussion.

Test Plan: make check, will also run stress test

Reviewers: ljin, sdong, rven, yhchiang

Reviewed By: yhchiang

Subscribers: dhruba, leveldb

Differential Revision: https://reviews.facebook.net/D28353
      53af5d87
  3. 07 11月, 2014 13 次提交
  5. 06 11月, 2014 3 次提交
  7. 05 11月, 2014 12 次提交