1. 20 5月, 2017 1 次提交
    • Y
      Suppress clang-analyzer false positive · d746aead
      Yi Wu 提交于
      Summary:
      Fixing two types of clang-analyzer false positives:
      * db is deleted and then reopen, and clang-analyzer thinks we are reusing the pointer after it has been deleted. Adding asserts to hint clang-analyzer the pointer is recreated.
      * ParsedInternalKey is (intentionally) uninitialized. Initialize the struct only when clang-analyzer is running.
      Closes https://github.com/facebook/rocksdb/pull/2334
      
      Differential Revision: D5093801
      
      Pulled By: yiwu-arbug
      
      fbshipit-source-id: f51355382098eb3da5ab9f64e094c6d03e6bdf7d
      d746aead
  2. 19 5月, 2017 2 次提交
  3. 18 5月, 2017 10 次提交
  4. 17 5月, 2017 7 次提交
  5. 16 5月, 2017 7 次提交
    • fix log err · 4f9e69cc
      赵星宇 提交于
      Summary: Closes https://github.com/facebook/rocksdb/pull/2206
      
      Differential Revision: D5054222
      
      Pulled By: yiwu-arbug
      
      fbshipit-source-id: d8742bda1bf3e76d7b68eeb86df4608031b5cbc8
      4f9e69cc
    • N
      cross-platform compatibility improvements · 11c5d474
      Nikhil Benesch 提交于
      Summary:
      We've had a couple CockroachDB users fail to build RocksDB on exotic platforms, so I figured I'd try my hand at solving these issues upstream. The problems stem from a) `USE_SSE=1` being too aggressive about turning on SSE4.2, even on toolchains that don't support SSE4.2 and b) RocksDB attempting to detect support for thread-local storage based on OS, even though it can vary by compiler on the same OS.
      
      See the individual commit messages for details. Regarding SSE support, this PR should change virtually nothing for non-CMake based builds. `make`, `PORTABLE=1 make`, `USE_SSE=1 make`, and `PORTABLE=1 USE_SSE=1 make` function exactly as before, except that SSE support will be automatically disabled when a simple SSE4.2-using test program fails to compile, as it does on OpenBSD. (OpenBSD's ports GCC supports SSE4.2, but its binutils do not, so `__SSE_4_2__` is defined but an SSE4.2-using program will fail to assemble.) A warning is emitted in this case. The CMake build is modified to support the same set of options, except that `USE_SSE` is spelled `FORCE_SSE42` because `USE_SSE` is rather useless now that we can automatically detect SSE support, and I figure changing options in the CMake build is less disruptive than changing the non-CMake build.
      
      I've tested these changes on all the platforms I can get my hands on (macOS, Windows MSVC, Windows MinGW, and OpenBSD) and it all works splendidly. Let me know if there's anything you object to—I obviously don't mean to break any of your build pipelines in the process of fixing ours downstream.
      Closes https://github.com/facebook/rocksdb/pull/2199
      
      Differential Revision: D5054042
      
      Pulled By: yiwu-arbug
      
      fbshipit-source-id: 938e1fc665c049c02ae15698e1409155b8e72171
      11c5d474
    • J
      Put lib files into suitable path in RPM package · d0043330
      Jeff Li 提交于
      Summary:
      Currently, the RPM package will install the lib and header files into `/usr/package/lib` and `/usr/package/include` which is not in the default search paths. It is reasonable to install them under `/usr/lib` and `/usr/include` so that no extra configuration is required.
      Closes https://github.com/facebook/rocksdb/pull/2221
      
      Differential Revision: D5054030
      
      Pulled By: yiwu-arbug
      
      fbshipit-source-id: 1d23de5ff21f07e6738c9dfa04429acd7a839143
      d0043330
    • Y
      Fix build error with blob DB. · 86d54925
      Yi Wu 提交于
      Summary:
      snprintf is in <stdio.h> and not in namespace std.
      Closes https://github.com/facebook/rocksdb/pull/2287
      
      Reviewed By: anirbanr-fb
      
      Differential Revision: D5054752
      
      Pulled By: yiwu-arbug
      
      fbshipit-source-id: 356807ec38f3c7d95951cdb41f31a3d3ae0714d4
      86d54925
    • A
      Fix the RocksJava Release on Windows · 254c4680
      Adam Retter 提交于
      Summary:
      This was previously broken accidentally by https://github.com/facebook/rocksdb/pull/2107
      
      Closes https://github.com/facebook/rocksdb/issues/2293
      Closes https://github.com/facebook/rocksdb/pull/2296
      
      Differential Revision: D5061248
      
      Pulled By: sagar0
      
      fbshipit-source-id: 7f58fee754723a7052d2a7f9d3d0369051c3cc5c
      254c4680
    • S
      Fix .gitignore pattern · 7a47b431
      Sergei Vorobev 提交于
      Summary:
      `java/**.asc` is not a correct gitignore pattern
      See https://git-scm.com/docs/gitignore for the list of allowed `**` patterns
      
      It seems reasonable to assume that intention is `java/**/*.asc`
      
      The reason why it bothers me is the fact that ripgrep parses .gitignore files
      and complains about invalid pattern
      https://github.com/BurntSushi/ripgrep
      Closes https://github.com/facebook/rocksdb/pull/2214
      
      Differential Revision: D5063030
      
      Pulled By: yiwu-arbug
      
      fbshipit-source-id: ddd6682b81f03134be15f20fd596130776b69695
      7a47b431
    • A
      Make sure that zstd is statically linked correctly in the Java static build · fa5a15ce
      Adam Retter 提交于
      Summary:
      Closes https://github.com/facebook/rocksdb/issues/2280
      Closes https://github.com/facebook/rocksdb/pull/2292
      
      Differential Revision: D5061259
      
      Pulled By: sagar0
      
      fbshipit-source-id: eec89111d114c04beee5870a4eb4b51857754783
      fa5a15ce
  6. 13 5月, 2017 6 次提交
    • A
      Add GetAllKeyVersions API · 3fa9a39c
      Andrew Kryczka 提交于
      Summary:
      - Introduced an include/ file dedicated to db-related debug functions to avoid making db.h more complex
      - Added debugging function, `GetAllKeyVersions()`, to return a listing of internal data for a range of user keys. The new `struct KeyVersion` exposes data similar to internal key without exposing any internal type.
      - Migrated the "ldb idump" subcommand to use this function
      - The API takes an inclusive-exclusive range to match behavior of "ldb idump". This will be quite annoying for users who want to query a single user key's versions :(.
      Closes https://github.com/facebook/rocksdb/pull/2232
      
      Differential Revision: D4976007
      
      Pulled By: ajkr
      
      fbshipit-source-id: cab375da53a7595d6575af2b7e3b776aa3ad793e
      3fa9a39c
    • A
      Simplified instructions for CentOS · 1a60982a
      Adam Retter 提交于
      Summary:
      Minimal changes for improvements to INSTALL.md for CentOS/RHEL
      Closes https://github.com/facebook/rocksdb/pull/2266
      
      Differential Revision: D5053530
      
      Pulled By: yiwu-arbug
      
      fbshipit-source-id: c05f30299f8efec949b9001a73969d649536ea8a
      1a60982a
    • A
      Facility for cross-building RocksJava using Docker · a5cc7ece
      Adam Retter 提交于
      Summary:
      As an alternative to Vagrant, we can now also use Docker to cross-build RocksDB. The advantages are:
      
      1. The Docker images are fixed; they include all the latest updates and build tools.
      2. The Vagrant image, required scripts that ran for every build that would update CentOS and install the buildtools. This lead to slow repeatable builds, we don't need to do this with Docker as they are already in the provided images.
      
      The Docker images I have used have their Docker build files here: https://github.com/evolvedbinary/docker-rocksjava and the images themselves are available from Docker hub: https://hub.docker.com/r/evolvedbinary/rocksjava/
      
      I have added the following targets to the `Makefile`:
      1. `rocksdbjavastaticreleasedocker` this uses Docker to perform the cross-builds. It is basically the Docker version of the existing Vagrant `rocksdbjavastaticrelease` target.
      2. `rocksdbjavastaticpublishdocker` delegates to `rocksdbjavastaticreleasedocker` and then `rocksdbjavastaticpublishcentral` to upload the artiacts to Maven Central. Equivalent to the existing Vagrant target: `rocksdbjavastaticpublish`
      Closes https://github.com/facebook/rocksdb/pull/2278
      
      Differential Revision: D5048206
      
      Pulled By: yiwu-arbug
      
      fbshipit-source-id: 78fa96ef9d966fe09638ed01de282cd4e31961a9
      a5cc7ece
    • M
      Blog post for partitioned index/filters · ccd3dddf
      Maysam Yabandeh 提交于
      Summary: Closes https://github.com/facebook/rocksdb/pull/2285
      
      Differential Revision: D5053096
      
      Pulled By: maysamyabandeh
      
      fbshipit-source-id: c696a6b82391d039c446d16222313f78341c37e8
      ccd3dddf
    • M
      Update blog authors · b145c34d
      Maysam Yabandeh 提交于
      Summary: Closes https://github.com/facebook/rocksdb/pull/2284
      
      Differential Revision: D5052835
      
      Pulled By: maysamyabandeh
      
      fbshipit-source-id: afe5fdb4b2d659cf612446a666dbc1d11afc3b5d
      b145c34d
    • A
      core-local array type conversions · bbe9ee7d
      Andrew Kryczka 提交于
      Summary:
      try to clean up the type conversions and hope it passes on windows.
      
      one interesting thing I learned is that bitshift operations are special: in `x << y`, the result type depends only on the type of `x`, unlike most arithmetic operations where the result type depends on both operands' types.
      Closes https://github.com/facebook/rocksdb/pull/2277
      
      Differential Revision: D5050145
      
      Pulled By: ajkr
      
      fbshipit-source-id: f3309e77526ac9612c632bf93a62d99757af9a29
      bbe9ee7d
  7. 12 5月, 2017 2 次提交
  8. 11 5月, 2017 5 次提交