1. 17 8月, 2017 3 次提交
  2. 16 8月, 2017 4 次提交
  3. 15 8月, 2017 3 次提交
  4. 14 8月, 2017 4 次提交
  5. 13 8月, 2017 1 次提交
  6. 12 8月, 2017 9 次提交
    • A
      fix deletion dropping in intra-L0 · acf935e4
      Andrew Kryczka 提交于
      Summary:
      `KeyNotExistsBeyondOutputLevel` didn't consider L0 files' key-ranges. So if a key only was covered by older L0 files' key-ranges, we would incorrectly drop deletions of that key. This PR just skips the deletion-dropping optimization when output level is L0.
      Closes https://github.com/facebook/rocksdb/pull/2726
      
      Differential Revision: D5617286
      
      Pulled By: ajkr
      
      fbshipit-source-id: 4bff1396b06d49a828ba4542f249191052915bce
      acf935e4
    • A
      make sst_dump compression size command consistent · 8254e9b5
      Andrew Kryczka 提交于
      Summary:
      - like other subcommands, reporting compression sizes should be specified with the `--command` CLI arg.
      - also added `--compression_types` arg as it's useful to restrict the types of compression used, at least in my dictionary compression experiments.
      Closes https://github.com/facebook/rocksdb/pull/2706
      
      Differential Revision: D5589520
      
      Pulled By: ajkr
      
      fbshipit-source-id: 305bb4ebcc95eecc8a85523cd3b1050619c9ddc5
      8254e9b5
    • A
      db_bench support for non-uniform column family ops · 74f18c13
      Andrew Kryczka 提交于
      Summary:
      Previously we could only select the CF on which to operate uniformly at random. This is a limitation, e.g., when testing universal compaction as all CFs would need to run full compaction at roughly the same time, which isn't realistic.
      
      This PR allows the user to specify the probability distribution for selecting CFs via the `--column_family_distribution` argument.
      Closes https://github.com/facebook/rocksdb/pull/2677
      
      Differential Revision: D5544436
      
      Pulled By: ajkr
      
      fbshipit-source-id: 478d56260995236ae90895ce5bd51f38882e185a
      74f18c13
    • A
      approximate histogram stats to save cpu · 5de98f2d
      Andrew Kryczka 提交于
      Summary:
      sounds like we're willing to tradeoff minor inaccuracy in stats for speed. start with histogram stats. ticker stats will be harder (and, IMO, we shouldn't change them in this manner) as many test cases rely on them being exactly correct.
      Closes https://github.com/facebook/rocksdb/pull/2720
      
      Differential Revision: D5607884
      
      Pulled By: ajkr
      
      fbshipit-source-id: 1b754cda35ea6b252d1fdd5aa3cfb58866506372
      5de98f2d
    • Y
      Fix c_test ASAN failure · 3f588843
      yiwu-arbug 提交于
      Summary:
      Fix c_test missing deletion of write batch pointer.
      Closes https://github.com/facebook/rocksdb/pull/2725
      
      Differential Revision: D5613866
      
      Pulled By: yiwu-arbug
      
      fbshipit-source-id: bf3f59a6812178577c9c25bae558ef36414a1f51
      3f588843
    • Y
      Fix blob DB transaction usage while GC · e5a1b727
      yiwu-arbug 提交于
      Summary:
      While GC, blob DB use optimistic transaction to delete or replace the index entry in LSM, to guarantee correctness if there's a normal write writing to the same key. However, the previous implementation doesn't call SetSnapshot() nor use GetForUpdate() of transaction API, instead it do its own sequence number checking before beginning the transaction. A normal write can sneak in after the sequence number check and overwrite the key, and the GC will delete or relocate the old version of the key by mistake. Update the code to property use GetForUpdate() to check the existing index entry.
      
      After the patch the sequence number store with each blob record is useless, So I'm considering remove the sequence number from blob record, in another patch.
      Closes https://github.com/facebook/rocksdb/pull/2703
      
      Differential Revision: D5589178
      
      Pulled By: yiwu-arbug
      
      fbshipit-source-id: 8dc960cd5f4e61b36024ba7c32d05584ce149c24
      e5a1b727
    • A
      fix corruption_test valgrind · 6f051e0c
      Andrew Kryczka 提交于
      Summary: Closes https://github.com/facebook/rocksdb/pull/2724
      
      Differential Revision: D5613416
      
      Pulled By: ajkr
      
      fbshipit-source-id: ed55fb66ab1b41dfdfe765fe3264a1c87a8acb00
      6f051e0c
    • K
      expose set_skip_stats_update_on_db_open to C bindings · ac098a46
      Kent767 提交于
      Summary:
      It would be super helpful to not have to recompile rocksdb to get this performance tweak for mechanical disks.
      
      I have signed the CLA.
      Closes https://github.com/facebook/rocksdb/pull/2718
      
      Differential Revision: D5606994
      
      Pulled By: yiwu-arbug
      
      fbshipit-source-id: c05e92bad0d03bd38211af1e1ced0d0d1e02f634
      ac098a46
    • S
      Support prefetch last 512KB with direct I/O in block based file reader · 666a005f
      Siying Dong 提交于
      Summary:
      Right now, if direct I/O is enabled, prefetching the last 512KB cannot be applied, except compaction inputs or readahead is enabled for iterators. This can create a lot of I/O for HDD cases. To solve the problem, the 512KB is prefetched in block based table if direct I/O is enabled. The prefetched buffer is passed in totegher with random access file reader, so that we try to read from the buffer before reading from the file. This can be extended in the future to support flexible user iterator readahead too.
      Closes https://github.com/facebook/rocksdb/pull/2708
      
      Differential Revision: D5593091
      
      Pulled By: siying
      
      fbshipit-source-id: ee36ff6d8af11c312a2622272b21957a7b5c81e7
      666a005f
  7. 11 8月, 2017 6 次提交
  8. 10 8月, 2017 3 次提交
    • J
      fix comment · 23c7d135
      jimmyway 提交于
      Summary:
      Signed-off-by: Ntang.jin <tang.jin@istuary.com>
      Closes https://github.com/facebook/rocksdb/pull/2644
      
      Differential Revision: D5600861
      
      Pulled By: yiwu-arbug
      
      fbshipit-source-id: 9516636cb6e77b09fe0ebef78953adf4b7e88cc8
      23c7d135
    • D
      Makefile: correct faligned-new test · 1fbad84b
      Daniel Black 提交于
      Summary:
      Commit 4f81ab38 has the test wrong.
      
      clang doesn't support a -dumpversion option. By lucky coincidence
      clang/gcc --version both place a version number at the same output location
      when --verison is passed.
      
      Example output (1st line only).
      
          $ clang --version
          clang version 3.9.1 (tags/RELEASE_391/final)
      
          $ gcc --version
          gcc (GCC) 6.4.1 20170727 (Red Hat 6.4.1-1)
      
      During the test of the compiler we ensure that a minimum version is met
      as Makefile doesn't support patterns.
      
      Also xcode9 doesn't seem affected by https://github.com/facebook/rocksdb/issues/2672
      and also doesn't have "clang" as the first part of its output so the
      fix implemented here also is Apple clang friendly.
      
          $ clang --version
          Apple LLVM version 9.0.0 (clang-900.0.31)
      Signed-off-by: NDaniel Black <daniel.black@au.ibm.com>
      Closes https://github.com/facebook/rocksdb/pull/2699
      
      Differential Revision: D5600818
      
      Pulled By: yiwu-arbug
      
      fbshipit-source-id: 3b0f2751becb53c1c35468bf29f3f828e7cf2c2a
      1fbad84b
    • A
      add VerifyChecksum() to db.h · 7848f0b2
      Aaron G 提交于
      Summary:
      We need a tool to check any sst file corruption in the db.
      It will check all the sst files in current version and read all the blocks (data, meta, index) with checksum verification. If any verification fails, the function will return non-OK status.
      Closes https://github.com/facebook/rocksdb/pull/2498
      
      Differential Revision: D5324269
      
      Pulled By: lightmark
      
      fbshipit-source-id: 6f8a272008b722402a772acfc804524c9d1a483b
      7848f0b2
  9. 09 8月, 2017 2 次提交
  10. 08 8月, 2017 2 次提交
  11. 07 8月, 2017 2 次提交
  12. 06 8月, 2017 1 次提交