- 24 1月, 2015 4 次提交
-
-
由 Igor Canadi 提交于
Summary: It looks like ASAN with gcc 4.9 works better than 4.8.1. It detected this possibility of heap buffer overflow. This was in our codebase for a year :) Test Plan: COMPILE_WITH_ASAN=1 make backupable_db && ./backupable_db Reviewers: yhchiang, rven, sdong Reviewed By: sdong Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D32085
-
由 Igor Canadi 提交于
Summary: We need this because we build MySQL with 4.8.1. Test Plan: ROCKSDB_FBCODE_BUILD_WITH_481=1 make check Reviewers: sdong, yhchiang, rven, yoshinorim Reviewed By: yoshinorim Subscribers: jonahcohen, yoshinorim, dhruba, leveldb Differential Revision: https://reviews.facebook.net/D32073
-
由 Igor Canadi 提交于
Summary: When you compile with COMPILE_WITH_TSAN=1, we will compile the code with -fsanitize=thread. This will resolve bunch of data race issues we might have. Test Plan: COMPILE_WITH_TSAN=1 m db_test Reviewers: yhchiang, rven, sdong Reviewed By: sdong Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D32019
-
由 Igor Canadi 提交于
Summary: Upgrade gcc to 4.9.1 and clang to dev. With new compilers I succeeded to run thread sanitizer, too. I'll post output (doesn't look good) and fix some things in separate diffs. Test Plan: compiles with both g++ and clang Reviewers: yhchiang, rven, sdong Reviewed By: sdong Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D32007
-
- 23 1月, 2015 14 次提交
-
-
由 Yueh-Hsuan Chiang 提交于
[RocksJava] Allow using ReadOptions with iterators
-
由 fyrz 提交于
The methods: - newIterator - iterators support now also ReadOptions. That allows a user of the Java API to retrieve RocksIterator instances on a snapshot.
-
由 Yueh-Hsuan Chiang 提交于
Summary: Make options_test runnable on ROCKSDB_LITE by blocking those tests that require non-ROCKSDB_LITE feature. Test Plan: make options_test OPT=-DROCKSDB_LITE -j32 ./options_test make clean make options_test -j32 ./options_test Reviewers: sdong, igor Reviewed By: igor Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D32025
-
由 Yueh-Hsuan Chiang 提交于
[RocksJava] Format version support in BlockBasedTableConfig
-
由 Yueh-Hsuan Chiang 提交于
-
由 Yueh-Hsuan Chiang 提交于
-
由 Yueh-Hsuan Chiang 提交于
[RocksJava] ColumnFamily name JNI correction
-
由 Igor Canadi 提交于
-
由 fyrz 提交于
- added spaces between operators - removed obsolete text in JavaDoc
-
由 fyrz 提交于
- Added support for format version in BlockBasedTableConfig
-
由 fyrz 提交于
-
由 sdong 提交于
Summary: Now we don't sync manifest file when initializing it, so DB cannot be safely reopened before the first mem table flush. Fix it by syncing it. This fixes fault_injection_test. Test Plan: make all check Reviewers: rven, yhchiang, igor Reviewed By: igor Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D32001
-
由 fyrz 提交于
Summary: Previous to this commit there was a problem with unterminated String usage as jByteArrays are not zero terminated. Test Plan: make rocksdbjava make jtest mvn -f rocksjni.pom package Reviewers: yhchiang, adamretter, ankgup87 Subscribers: dhruba Differential Revision: https://reviews.facebook.net/D31809
-
由 fyrz 提交于
Previous to this commit there was a problem with unterminated String usage as jByteArrays are not zero terminated.
-
- 22 1月, 2015 3 次提交
-
-
由 Igor Canadi 提交于
-
由 Igor Canadi 提交于
Summary: I saw this when running readrandom benchmark with corrupted database -- benchmark worked! If a Get() returns corruption we should probably abort. Test Plan: compiles Reviewers: yhchiang, rven, sdong Reviewed By: sdong Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D31701
-
由 sdong 提交于
Summary: GetLiveFilesMetaData() already adds a leading "/" in file name. No need to add one extra "/" in DBImpl::CheckConsistency() Test Plan: make all check Reviewers: yhchiang, rven, igor Reviewed By: igor Subscribers: leveldb, dhruba Differential Revision: https://reviews.facebook.net/D31779
-
- 20 1月, 2015 2 次提交
-
-
由 Yueh-Hsuan Chiang 提交于
[RocksJava] TTL DB support
-
由 fyrz 提交于
-
- 18 1月, 2015 5 次提交
-
-
由 fyrz 提交于
-
由 fyrz 提交于
Summary: TTLDB Support exposed in Java-API. It is now possible to open a datbase using the RocksDB time to live feature. Test Plan: make rocksdbjava make test mvn -f rocksjni.pom package @Adam please test mac osx compile Reviewers: yhchiang, adamretter, ankgup87 Subscribers: dhruba, adam Differential Revision: https://reviews.facebook.net/D31449
-
由 fyrz 提交于
-
由 fyrz 提交于
-
由 Yueh-Hsuan Chiang 提交于
[RocksJava] DirectSlice String termination fix
-
- 17 1月, 2015 6 次提交
-
-
由 fyrz 提交于
-
由 fyrz 提交于
DirectSlice fix for non terminated String copy. This lead sometimes to problems with DirectSliceTest.
-
由 sdong 提交于
Summary: Now using memenv, DB will not able to be reopened, since a "//" in the file name. Fix it by normalizing file path. Test Plan: Add a unit test that used to fail and now pass. Reviewers: rven, yhchiang, igor Reviewed By: igor Subscribers: leveldb, dhruba Differential Revision: https://reviews.facebook.net/D31767
-
由 Yueh-Hsuan Chiang 提交于
[RocksJava] Fixes to latest WriteBatchWithIndex addition
-
由 Yoshinori Matsunobu 提交于
Summary: This diff enables to configure prefix_extractor string parameter as a CF option. Test Plan: make all check, ./options_test Reviewers: sdong, igor Reviewed By: igor Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D31653
-
由 Igor Canadi 提交于
Summary: We added a new format version. Reflect that in the comments. Test Plan: none Reviewers: sdong, rven, yhchiang, MarkCallaghan Reviewed By: MarkCallaghan Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D31629
-
- 16 1月, 2015 6 次提交
-
-
由 Igor Canadi 提交于
-
由 fyrz 提交于
Previous to this commit identiy checks were performed. Now tests are performed using equals - method as intended.
-
由 fyrz 提交于
Some of the latest commits included illegal JavaDoc formattings.
-
由 Yueh-Hsuan Chiang 提交于
Summary: This patch remove the unnecessary Compaction::ReleaseInputs(). Compaction::ReleaseInputs() tries to unref its input_version and column_family. However, such unref is always done in ~Compaction(), and all current ReleaseInputs() calls are right before the destructor. Test Plan: ./db_test Reviewers: igor Reviewed By: igor Subscribers: igor, rven, dhruba, sdong Differential Revision: https://reviews.facebook.net/D31605
-
由 Venkatesh Radhakrishnan 提交于
Summary: While running cross-functional tests for weak iterators, I encountered a bug in GeoDB. GeoDB reads a key from the database and tries to use it after doing a Seek. Fixing it by storing the key locally so that it is still visible after the Seek. Test Plan: Run geodb_test Reviewers: sdong, igor Reviewed By: igor Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D31599
-
由 Thomas Dudziak 提交于
Summary: This is a port of [[ https://github.com/google/leveldb/blob/master/db/fault_injection_test.cc | LevelDB's fault_injection_test ]] to RocksDB. Unfortunately it fails with: ``` ==== Test FaultInjectionTest.FaultTest db/fault_injection_test.cc:491: Corruption: no meta-nextfile entry in descriptor #0 ./fault_injection_test() [0x41477a] rocksdb::FaultInjectionTest::PartialCompactTestReopenWithFault(rocksdb::FaultInjectionTest::ResetMethod, int, int) /data/users/tomdzk/rocksdb/db/fault_injection_test.cc:491 #1 ./fault_injection_test() [0x40a38a] rocksdb::_Test_FaultTest::_Run() /data/users/tomdzk/rocksdb/db/fault_injection_test.cc:517 #2 ./fault_injection_test() [0x415bea] rocksdb::_Test_FaultTest::_RunIt() /data/users/tomdzk/rocksdb/db/fault_injection_test.cc:507 #3 ./fault_injection_test() [0x584367] rocksdb::test::RunAllTests() /data/users/tomdzk/rocksdb/util/testharness.cc:70 #4 /usr/local/fbcode/gcc-4.8.1-glibc-2.17/lib/libc.so.6(__libc_start_main+0x10e) [0x7f7a40857efe] ?? ??:0 #5 ./fault_injection_test() [0x408bb8] _start ??:0 ``` so I commented out the test invocation in the source code for now (lines 514-520) so it can be merged. Test Plan: This is a new test. Reviewers: igor Reviewed By: igor Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D31587
-