1. 25 3月, 2015 5 次提交
    • F
      [RocksJava] Maven build fix · 8f104ae5
      fyrz 提交于
      8f104ae5
    • Y
      Merge pull request #546 from fyrz/RocksJava-MemEnv · afc51649
      Yueh-Hsuan Chiang 提交于
      [RocksJava] Expose MemEnv in RocksJava
      afc51649
    • Y
      Merge pull request #545 from fyrz/RocksJava-Level-Compression · 6284eef4
      Yueh-Hsuan Chiang 提交于
      [RocksJava] Add compression per level to API
      6284eef4
    • Y
      Report elapsed time in micros in ThreadStatus instead of start time. · 248c063b
      Yueh-Hsuan Chiang 提交于
      Summary:
      Report elapsed time of a thread operation in micros in ThreadStatus
      instead of start time of a thread operation in seconds since the
      Epoch, 1970-01-01 00:00:00 (UTC).
      
      Test Plan:
      ./db_bench --benchmarks=fillrandom --num=100000 --threads=40 \
      --max_background_compactions=10 --max_background_flushes=3 \
      --thread_status_per_interval=1000 --key_size=16 --value_size=1000 \
      --num_column_families=10
      
      Sample Output:
                  ThreadID ThreadType                    cfName    Operation  ElapsedTime                                         Stage        State
           140667724562496   High Pri column_family_name_000002        Flush   772.419 ms                    FlushJob::WriteLevel0Table
           140667728756800   High Pri                   default        Flush   617.845 ms                    FlushJob::WriteLevel0Table
           140667732951104   High Pri column_family_name_000005        Flush   772.078 ms                    FlushJob::WriteLevel0Table
           140667875557440    Low Pri column_family_name_000008   Compaction  1409.216 ms                        CompactionJob::Install
           140667737145408    Low Pri
           140667749728320    Low Pri
           140667816837184    Low Pri column_family_name_000007   Compaction  1071.815 ms      CompactionJob::ProcessKeyValueCompaction
           140667787477056    Low Pri column_family_name_000009   Compaction   772.516 ms      CompactionJob::ProcessKeyValueCompaction
           140667741339712    Low Pri
           140667758116928    Low Pri column_family_name_000004   Compaction   620.739 ms      CompactionJob::ProcessKeyValueCompaction
           140667753922624    Low Pri
           140667842003008    Low Pri column_family_name_000006   Compaction  1260.079 ms      CompactionJob::ProcessKeyValueCompaction
           140667745534016    Low Pri
      
      Reviewers: sdong, igor, rven
      
      Subscribers: dhruba, leveldb
      
      Differential Revision: https://reviews.facebook.net/D35769
      248c063b
    • I
      Undeprecate GetLiveFiles() · 315abac9
      Igor Canadi 提交于
      Summary: There is no alternative to GetLiveFiles() function
      
      Test Plan: none
      
      Reviewers: sdong
      
      Reviewed By: sdong
      
      Subscribers: dhruba, leveldb
      
      Differential Revision: https://reviews.facebook.net/D35805
      315abac9
  2. 24 3月, 2015 10 次提交
  3. 23 3月, 2015 2 次提交
  4. 21 3月, 2015 1 次提交
  5. 20 3月, 2015 7 次提交
    • I
      rocksdb: print status error message when (ASSERT|EXPECT)_OK fails · 28bc6de9
      Igor Sugak 提交于
      Summary: Modified rocksdb status assertions ASSERT_OK and EXPECT_OK to print error message from Status::ToString() when failed.
      
      Test Plan: Modify a test to fail status assertions ASSERT_OK and EXPECT_OK and notice an error message that came from Status::ToString()
      
      Reviewers: meyering, sdong, yhchiang, igor
      
      Reviewed By: igor
      
      Subscribers: dhruba, leveldb
      
      Differential Revision: https://reviews.facebook.net/D35469
      28bc6de9
    • I
      rocksdb: Remove #include "util/string_util.h" from util/testharness.h · 9405b5ef
      Igor Sugak 提交于
      Summary:
      1. Manually deleted #include "util/string_util.h" from util/testharness.h
      2.
      ```
      % USE_CLANG=1 make all -j55 -k 2> build.log
      % perl -naF: -E 'say $F[0] if /: error:/' build.log | sort -u | xargs sed -i '/#include "util\/testharness.h"/i #include "util\/string_util.h"'
      ```
      
      Test Plan:
      Make sure make all completes with no errors.
      ```
      % make all -j55
      ```
      
      Reviewers: meyering, igor, sdong
      
      Reviewed By: sdong
      
      Subscribers: dhruba, leveldb
      
      Differential Revision: https://reviews.facebook.net/D35493
      9405b5ef
    • I
      rocksdb: Remove #include "util/random.h" from util/testharness.h · 220d0dff
      Igor Sugak 提交于
      Summary: Cleaning util/testharness.h
      
      Test Plan:
      Make completes with no errors.
      ```
      % make all
      ```
      
      Reviewers: meyering, igor, sdong
      
      Reviewed By: sdong
      
      Subscribers: dhruba, leveldb
      
      Differential Revision: https://reviews.facebook.net/D35487
      220d0dff
    • I
      Don't delete files when column family is dropped · b088c83e
      Igor Canadi 提交于
      Summary:
      To understand the bug read t5943287 and check out the new test in column_family_test (ReadDroppedColumnFamily), iter 0.
      
      RocksDB contract allowes you to read a drop column family as long as there is a live reference. However, since our iteration ignores dropped column families, AddLiveFiles() didn't mark files of a dropped column families as live. So we deleted them.
      
      In this patch I no longer ignore dropped column families in the iteration. I think this behavior was confusing and it also led to this bug. Now if an iterator client wants to ignore dropped column families, he needs to do it explicitly.
      
      Test Plan: Added a new unit test that is failing on master. Unit test succeeds now.
      
      Reviewers: sdong, rven, yhchiang
      
      Reviewed By: yhchiang
      
      Subscribers: dhruba, leveldb
      
      Differential Revision: https://reviews.facebook.net/D32535
      b088c83e
    • I
      rocksdb: initial util/testharness clean up · 17ae3fcb
      Igor Sugak 提交于
      Summary: Deleted some redundant code. More comming.
      
      Test Plan:
      ```lang=bash
      % USE_CLANG=1 make check
      ```
      
      Reviewers: meyering, sdong, igor
      
      Reviewed By: igor
      
      Subscribers: dhruba, leveldb
      
      Differential Revision: https://reviews.facebook.net/D35463
      17ae3fcb
    • F
      [RocksJava] Enhanced Logger comment · 39f4271b
      fyrz 提交于
      Added information about performance penalties using a custom
      logger implementation.
      39f4271b
    • F
      [RocksJava] 32-Bit adjustments · 5615e23d
      fyrz 提交于
      Summary:
      Before this change overflowing size_t values led to a checked Exception.
      
      After that change:
      
      size_t overflows on 32-Bit architecture throw now an IllegalArgumentException,
      which removes the necessity for a developer to catch these Exceptions explicitly.
      
      This is especially an advantage for developers targeting 64-Bit systems because
      it is not necessary anymore to catch exceptions which are never thrown on a 64-Bit
      system.
      
      Test Plan:
      make clean jclean rocksdbjava jtest
      mvn -f rocksjni.pom package
      
      Reviewers: adamretter, yhchiang, ankgup87
      
      Subscribers: dhruba
      
      Differential Revision: https://reviews.facebook.net/D34923
      5615e23d
  6. 19 3月, 2015 14 次提交
  7. 18 3月, 2015 1 次提交
    • A
      Create an abstract interface for write batches · 81345b90
      agiardullo 提交于
      Summary: WriteBatch and WriteBatchWithIndex now both inherit from a common abstract base class.  This makes it easier to write code that is agnostic toward the implementation of the particular write batch.  In particular, I plan on utilizing this abstraction to allow transactions to support using either implementation of a write batch.
      
      Test Plan: modified existing WriteBatchWithIndex tests to test new functions.  Running all tests.
      
      Reviewers: igor, rven, yhchiang, sdong
      
      Reviewed By: sdong
      
      Subscribers: dhruba, leveldb
      
      Differential Revision: https://reviews.facebook.net/D34017
      81345b90