1. 11 6月, 2016 1 次提交
    • S
      Merge db/slice.cc into util/slice.cc · 6faddd7c
      sdong 提交于
      Summary: It confuses some compilers to have slice.cc under multiple directories. Merge them.
      
      Test Plan: Run existing tests
      
      Reviewers: andrewkr, yhchiang, IslamAbdelRahman
      
      Reviewed By: IslamAbdelRahman
      
      Subscribers: leveldb, andrewkr, dhruba
      
      Differential Revision: https://reviews.facebook.net/D59409
      6faddd7c
  2. 07 5月, 2016 1 次提交
    • A
      [ldb] Export ldb_cmd*.h · 04dec2a3
      Arun Sharma 提交于
      Summary:
      This is needed so that rocksdb users can add more
      commands to the included ldb tool by adding more custom
      commands.
      
      Test Plan: make -j ldb
      
      Reviewers: sdong, IslamAbdelRahman
      
      Reviewed By: IslamAbdelRahman
      
      Subscribers: andrewkr, dhruba
      
      Differential Revision: https://reviews.facebook.net/D57243
      04dec2a3
  3. 31 3月, 2016 1 次提交
    • L
      to/from hex refactor · 21700a51
      Laurent Demailly 提交于
      Summary:
      Expose the inverse of ToString(hex=true) on Slice: Slice::DecodeHex
      Refactor the other implementation of to/from hex in ldb_cmd.h to use the Slice
      version
      (Difference between the 2 is whether 0x is expected/produced in front of the hex
      string or not)
      Eliminated support for invalid odd length hex string - this is now invalid
      instead of having 1/2 byte set
      Added (inverse of HexToString) test for LDBCommand::StringToHex which also
      indirectly tests Slice::ToString(true)
      
      After moving the original implementation from ldb_cmd.h, updated it to much simpler/efficient version
      (originally/inspired from https://github.com/facebook/wdt/blob/master/util/EncryptionUtils.cpp#L140-L169 )
      
      Test Plan: run tests
      
      Reviewers: uddipta, sdong
      
      Reviewed By: sdong
      
      Subscribers: andrewkr, dhruba
      
      Differential Revision: https://reviews.facebook.net/D56121
      21700a51
  4. 10 2月, 2016 1 次提交
  5. 03 10月, 2015 1 次提交
    • Y
      [RocksDB Options] Support more options in RocksDBOptionParser for sanity check. · 5c7bf56d
      Yueh-Hsuan Chiang 提交于
      Summary:
      RocksDBOptionsParser now supports CompressionType and the following
      pointer-typed options in RocksDBOptionParser
      for sanity check:
        prefix_extractor
        table_factory
        comparator
        compaction_filter
        compaction_filter_factory
        merge_operator
        memtable_factory
      
      In the RocksDB Options file, only high level information about pointer-typed
      options are serialized, and those information is only used for verification
      / sanity check purpose.
      
      Test Plan: added more tests in options_test
      
      Reviewers: igor, IslamAbdelRahman, sdong, anthony
      
      Reviewed By: sdong
      
      Subscribers: dhruba, leveldb
      
      Differential Revision: https://reviews.facebook.net/D47925
      5c7bf56d
  6. 14 7月, 2015 1 次提交
    • S
      "make format" against last 10 commits · f9728640
      sdong 提交于
      Summary: This helps Windows port to format their changes, as discussed. Might have formatted some other codes too becasue last 10 commits include more.
      
      Test Plan: Build it.
      
      Reviewers: anthony, IslamAbdelRahman, kradhakrishnan, yhchiang, igor
      
      Reviewed By: igor
      
      Subscribers: leveldb, dhruba
      
      Differential Revision: https://reviews.facebook.net/D41961
      f9728640
  7. 08 7月, 2015 1 次提交
  8. 02 7月, 2015 1 次提交
    • D
      Windows Port from Microsoft · 18285c1e
      Dmitri Smirnov 提交于
       Summary: Make RocksDb build and run on Windows to be functionally
       complete and performant. All existing test cases run with no
       regressions. Performance numbers are in the pull-request.
      
       Test plan: make all of the existing unit tests pass, obtain perf numbers.
      
       Co-authored-by: Praveen Rao praveensinghrao@outlook.com
       Co-authored-by: Sherlock Huang baihan.huang@gmail.com
       Co-authored-by: Alex Zinoviev alexander.zinoviev@me.com
       Co-authored-by: Dmitri Smirnov dmitrism@microsoft.com
      18285c1e
  9. 27 2月, 2015 1 次提交
    • I
      rocksdb: Add missing override · 62247ffa
      Igor Sugak 提交于
      Summary:
      When using latest clang (3.6 or 3.7/trunck) rocksdb is failing with many errors. Almost all of them are missing override errors. This diff adds missing override keyword. No manual changes.
      
      Prerequisites: bear and clang 3.5 build with extra tools
      
      ```lang=bash
      % USE_CLANG=1 bear make all # generate a compilation database http://clang.llvm.org/docs/JSONCompilationDatabase.html
      % clang-modernize -p . -include . -add-override
      % make format
      ```
      
      Test Plan:
      Make sure all tests are passing.
      ```lang=bash
      % #Use default fb code clang.
      % make check
      ```
      Verify less error and no missing override errors.
      ```lang=bash
      % # Have trunk clang present in path.
      % ROCKSDB_NO_FBCODE=1 CC=clang CXX=clang++ make
      ```
      
      Reviewers: igor, kradhakrishnan, rven, meyering, sdong
      
      Reviewed By: sdong
      
      Subscribers: dhruba, leveldb
      
      Differential Revision: https://reviews.facebook.net/D34077
      62247ffa
  10. 31 1月, 2015 1 次提交
  11. 25 11月, 2014 1 次提交
  12. 14 5月, 2014 1 次提交
  13. 17 10月, 2013 1 次提交
  14. 05 10月, 2013 1 次提交
  15. 24 8月, 2013 1 次提交
  16. 23 8月, 2013 1 次提交
    • J
      Add three new MemTableRep's · 74781a0c
      Jim Paton 提交于
      Summary:
      This patch adds three new MemTableRep's: UnsortedRep, PrefixHashRep, and VectorRep.
      
      UnsortedRep stores keys in an std::unordered_map of std::sets. When an iterator is requested, it dumps the keys into an std::set and iterates over that.
      
      VectorRep stores keys in an std::vector. When an iterator is requested, it creates a copy of the vector and sorts it using std::sort. The iterator accesses that new vector.
      
      PrefixHashRep stores keys in an unordered_map mapping prefixes to ordered sets.
      
      I also added one API change. I added a function MemTableRep::MarkImmutable. This function is called when the rep is added to the immutable list. It doesn't do anything yet, but it seems like that could be useful. In particular, for the vectorrep, it means we could elide the extra copy and just sort in place. The only reason I haven't done that yet is because the use of the ArenaAllocator complicates things (I can elaborate on this if needed).
      
      Test Plan:
      make -j32 check
      ./db_stress --memtablerep=vector
      ./db_stress --memtablerep=unsorted
      ./db_stress --memtablerep=prefixhash --prefix_size=10
      
      Reviewers: dhruba, haobo, emayanke
      
      Reviewed By: dhruba
      
      CC: leveldb
      
      Differential Revision: https://reviews.facebook.net/D12117
      74781a0c
  17. 14 8月, 2013 1 次提交
    • T
      Prefix filters for scans (v4) · f5f18422
      Tyler Harter 提交于
      Summary: Similar to v2 (db and table code understands prefixes), but use ReadOptions as in v3.  Also, make the CreateFilter code faster and cleaner.
      
      Test Plan: make db_test; export LEVELDB_TESTS=PrefixScan; ./db_test
      
      Reviewers: dhruba
      
      Reviewed By: dhruba
      
      CC: haobo, emayanke
      
      Differential Revision: https://reviews.facebook.net/D12027
      f5f18422