1. 30 10月, 2015 4 次提交
  2. 29 10月, 2015 7 次提交
    • I
      Fix RocksDB lite build for write_stress · c97667d9
      Igor Canadi 提交于
      Summary: We don't have access to GetLiveFilesMetadata() in RocksDB lite. If compiling write_stress for lite, I skip the check for leaked files, which depends on this function.
      
      Test Plan: OPT=-DROCKSDB_LITE m write_stress
      
      Reviewers: sdong
      
      Reviewed By: sdong
      
      Subscribers: dhruba, leveldb
      
      Differential Revision: https://reviews.facebook.net/D49647
      c97667d9
    • H
      Use the correct variable when fetching table properties. · 0d720dfc
      Herman Lee 提交于
      Summary:
      An uninitialized parameter was being passed into the call to fetch the table
      properties during the compaction notification callbacks.
      
      Test Plan:
      Build it with myrocks and verify unit test passed.
      Run unit tests.
      
      Reviewers: rven, yhchiang, igor
      
      Reviewed By: igor
      
      Subscribers: dhruba
      
      Differential Revision: https://reviews.facebook.net/D49635
      0d720dfc
    • I
      Write stress test · 4b66d953
      Igor Canadi 提交于
      Summary:
      The goal of this diff is to create a simple stress test with focus on catching:
      * bugs in compaction/flush processes, especially the ones that cause assertion errors
      * bugs in the code that deletes obsolete files
      
      There are two parts of the test:
      * write_stress, a binary that writes to the database
      * write_stress_runner.py, a script that invokes and kills write_stress
      
      Here are some interesting parts of write_stress:
      * Runs with very high concurrency of compactions and flushes (32 threads total) and tries to create a huge amount of small files
      * The keys written to the database are not uniformly distributed -- there is a 3-character prefix that mutates occasionally (in prefix mutator thread), in such a way that the first character mutates slower than second, which mutates slower than third character. That way, the compaction stress tests some interesting compaction features like trivial moves and bottommost level calculation
      * There is a thread that creates an iterator, holds it for couple of seconds and then iterates over all keys. This is supposed to test RocksDB's abilities to keep the files alive when there are references to them.
      * Some writes trigger WAL sync. This is stress testing our WAL sync code.
      * At the end of the run, we make sure that we didn't leak any of the sst files
      
      write_stress_runner.py changes the mode in which we run write_stress and also kills and restarts it. There are some interesting characteristics:
      * At the beginning we divide the full test runtime into smaller parts -- shorter runtimes (couple of seconds) and longer runtimes (100, 1000) seconds
      * The first time we run write_stress, we destroy the old DB. Every next time during the test, we use the same DB.
      * We can run in kill mode or clean-restart mode. Kill mode kills the write_stress violently.
      * We can run in mode where delete_obsolete_files_with_fullscan is true or false
      * We can run with low_open_files mode turned on or off. When it's turned on, we configure table cache to only hold a couple of files -- that way we need to reopen files every time we access them.
      
      Another goal was to create a stress test without a lot of parameters. So tools/write_stress_runner.py should only take one parameter -- runtime_sec and it should figure out everything else on its own.
      
      In a separate diff, I'll add this new test to our nightly legocastle runs.
      
      Test Plan:
      The goal of this test was to retroactively catch the following bugs: D33045, D48201, D46899, D42399. I failed to reproduce D48201, but all others have been caught!
      
      When i reverted https://reviews.facebook.net/D33045:
      
           ./write_stress --runtime_sec=200 --low_open_files_mode=true
           Iterator statuts not OK: IO error: /fast-rocksdb-tmp/rocksdb_test/write_stress/089166.sst: No such file or directory
      
      When i reverted https://reviews.facebook.net/D42399:
      
          python tools/write_stress_runner.py --runtime_sec=5000
          Running write_stress, will kill after 5 seconds: ./write_stress --runtime_sec=-1
          Running write_stress, will kill after 2 seconds: ./write_stress --runtime_sec=-1 --destroy_db=false --delete_obsolete_files_with_fullscan=true
          Running write_stress, will kill after 7 seconds: ./write_stress --runtime_sec=-1 --destroy_db=false
          Running write_stress, will kill after 5 seconds: ./write_stress --runtime_sec=-1 --destroy_db=false
          Running write_stress, will kill after 8 seconds: ./write_stress --runtime_sec=-1 --destroy_db=false --low_open_files_mode=true
          Write to DB failed: IO error: /fast-rocksdb-tmp/rocksdb_test/write_stress/019250.sst: No such file or directory
          ERROR: write_stress died with exitcode=-6
      
      When i reverted https://reviews.facebook.net/D46899:
      
          python tools/write_stress_runner.py --runtime_sec=1000
          runtime: 1000
          Going to execute write stress for [3, 3, 100, 3, 2, 100, 1, 788]
          Running write_stress for 3 seconds: ./write_stress --runtime_sec=3 --low_open_files_mode=true
          Running write_stress for 3 seconds: ./write_stress --runtime_sec=3 --destroy_db=false --delete_obsolete_files_with_fullscan=true
          Running write_stress, will kill after 100 seconds: ./write_stress --runtime_sec=-1 --destroy_db=false --delete_obsolete_files_with_fullscan=true
          write_stress: db/db_impl.cc:2070: void rocksdb::DBImpl::MarkLogsSynced(uint64_t, bool, const rocksdb::Status&): Assertion `log.getting_synced' failed.
          ERROR: write_stress died with exitcode=-6
      
      Reviewers: IslamAbdelRahman, yhchiang, rven, kradhakrishnan, sdong, anthony
      
      Reviewed By: anthony
      
      Subscribers: leveldb, dhruba
      
      Differential Revision: https://reviews.facebook.net/D49533
      4b66d953
    • S
      Move include/posix/io_posix.h to util/io_posix.h · 47414c6c
      sdong 提交于
      Summary: include/posix/io_posix.h is not a public API. Although include/posix/ is not a public header directory, it is confusing to put non-public headers to under include/. Move it to util/ to be clearer.
      
      Test Plan: Run all tests
      
      Reviewers: rven, IslamAbdelRahman, anthony, kradhakrishnan, yhchiang, igor
      
      Reviewed By: igor
      
      Subscribers: leveldb, dhruba
      
      Differential Revision: https://reviews.facebook.net/D49611
      47414c6c
    • S
      Revert "Avoid to reply on ROCKSDB_FALLOCATE_PRESENT in include/posix/io_posix.h" · 2889df84
      sdong 提交于
      This reverts commit c37223c0.
      2889df84
    • S
      Merge pull request #795 from yuslepukhin/fix_mocktable_id · 28c8758a
      Siying Dong 提交于
      Fix MockTable ID storage
      28c8758a
    • D
      Fix MockTable ID storage · 5c8f2ee7
      Dmitri Smirnov 提交于
        On Windows two tests fail that use MockTable:
        flush_job_test and compaction_job_test with the following message:
        compaction_job_test_je.exe : Assertion failed: result.size() == 4,
        file c:\dev\rocksdb\rocksdb\table\mock_table.cc, line 110
      
        Investigation reveals that this failure occurs when a 4 byte
        ID written to a beginning of the physically open file (main
        contents remains in a in-memory map) can not be read back.
      
        The reason for the failure is that the ID is written directly
        to a WritableFile bypassing WritableFileWriter. The side effect of that
        is that pending_sync_ never becomes true so the file is never flushed,
        however, the direct cause of the failure is that the filesize_ member
        of the WritableFileWriter remains zero. At Close() the file is truncated
        to that size and the file becomes empty so the ID can not be read back.
      5c8f2ee7
  3. 28 10月, 2015 8 次提交
  4. 27 10月, 2015 8 次提交
  5. 25 10月, 2015 1 次提交
  6. 23 10月, 2015 4 次提交
  7. 22 10月, 2015 2 次提交
    • J
      Split posix storage backend into Env and library · 6e6dd5f6
      Javier González 提交于
      Summary: This patch splits the posix storage backend into Env and
      the actual *File implementations. The motivation is to allow other Envs
      to use posix as a library. This enables a storage backend different from
      posix to split its secondary storage between a normal file system
      partition managed by posix, and it own media.
      
      Test Plan: No new functionality is added to posix Env or the library,
      thus the current tests should suffice.
      6e6dd5f6
    • A
      Fix a bug in GetApproximateSizes · 980a82ee
      Alexey Maykov 提交于
      Summary: Need to pass through the memtable parameter.
      
      Test Plan: built, tested through myrocks
      
      Reviewers: igor, sdong, rven
      
      Reviewed By: rven
      
      Subscribers: dhruba
      
      Differential Revision: https://reviews.facebook.net/D49167
      980a82ee
  8. 21 10月, 2015 6 次提交
    • S
      fix bug in db_crashtest.py · d0d13ebf
      Shusen Liu 提交于
      Summary:
      in tools/db_crashtest.py, cmd_params['db'] by default is a lambda expression, not the actual db_name.
      fix by get the db_name before passing it to gen_cmd.
      
      Test Plan: run `make crashtest`
      
      Reviewers: sdong
      
      Reviewed By: sdong
      
      Subscribers: dhruba
      
      Differential Revision: https://reviews.facebook.net/D49119
      d0d13ebf
    • V
      Merge remote-tracking branch 'upstream/master' · 01a41af0
      Vasili Svirski 提交于
      01a41af0
    • Y
      Use DEBUG_LEVEL=0 in make release and make clean · 5678c05d
      Yueh-Hsuan Chiang 提交于
      Summary: Use DEBUG_LEVEL=0 in make release and make clean
      
      Test Plan:
      make clean
      make release -j32
      
      Reviewers: MarkCallaghan, sdong, anthony, IslamAbdelRahman, igor
      
      Reviewed By: igor
      
      Subscribers: dhruba, leveldb
      
      Differential Revision: https://reviews.facebook.net/D49125
      5678c05d
    • S
      Merge pull request #779 from yuslepukhin/optimize_windows_build · ac25fe6b
      Siying Dong 提交于
      Do not build test only code and unit tests in Release builds
      ac25fe6b
    • D
      Do not build test only code and unit tests in Release builds · e154ee08
      Dmitri Smirnov 提交于
        Test code errors are currently blocking Windows Release builew
        We do not want spend time building in Release what we can not run
        We want to eliminate a source of most frequent errors when people
        check-in test only code which can not be built in Release.
        This feature will work only if you invoke msbuild against rocksdb.sln
        Invoking it against ALL_BUILD target will attempt to build everything.
      e154ee08
    • V
      Error while cmake by building from zip-archive · cd3286fa
      Vasili Svirski 提交于
      * add validation is git found
      * add validation is .git folder exists in project (project zip archive download without .git folder)
      * get head commit SHA if git found and .git folder exists
      
      Tested:
      * configure project by CMake 3.0.0 successfully (with and without git), with project zip archive (without .git folder) and with project cloned from github
      * configure project by command: cmake -G "Visual Studio 12 Win64"
      * build solution by Visual Studio
      * manually validate that file utils/build_version.cc contains valid head revision value
      cd3286fa