1. 22 5月, 2014 1 次提交
  2. 21 5月, 2014 5 次提交
  3. 20 5月, 2014 2 次提交
    • S
      Print out thread ID while thread terminates for decreased pool size. · bd1105aa
      sdong 提交于
      Summary: Per request from @nkg-, temporarily print thread ID when a thread terminates. It is a temp solution as we try to minimized stderr messages.
      
      Test Plan: env_test
      
      Reviewers: haobo, igor, dhruba
      
      Reviewed By: igor
      
      CC: nkg-, leveldb
      
      Differential Revision: https://reviews.facebook.net/D18753
      bd1105aa
    • S
      ThreadPool to allow decrease number of threads and increase of number of... · 3df07d17
      sdong 提交于
      ThreadPool to allow decrease number of threads and increase of number of threads is to be instantly scheduled
      
      Summary:
      Add a feature to decrease the number of threads in thread pool.
      Also instantly schedule more threads if number of threads is increased.
      
      Here is the way it is implemented: each background thread needs its thread ID. After decreasing number of threads, all threads are woken up. The thread with the largest thread ID will terminate. If there are more threads to terminate, the thread will wake up all threads again.
      
      Another change is made so that when number of threads is increased, more threads are created and all previous excessive threads are woken up to do the work.
      
      Test Plan: Add a unit test.
      
      Reviewers: haobo, dhruba
      
      Reviewed By: haobo
      
      CC: yhchiang, igor, nkg-, leveldb
      
      Differential Revision: https://reviews.facebook.net/D18675
      3df07d17
  4. 17 5月, 2014 1 次提交
  5. 16 5月, 2014 4 次提交
  6. 15 5月, 2014 11 次提交
  7. 14 5月, 2014 7 次提交
    • Y
    • Y
      [Java] Refined the output of Java DbBenchmark. · e883407e
      Yueh-Hsuan Chiang 提交于
      e883407e
    • S
      FixedPrefixTransform to include prefix length in its name · 8c2c4602
      sdong 提交于
      Summary: As title
      
      Test Plan: make all check.
      
      Reviewers: haobo, igor, yhchiang
      
      Reviewed By: igor
      
      CC: leveldb
      
      Differential Revision: https://reviews.facebook.net/D18705
      8c2c4602
    • Y
      [Java] Fixed a bug in Java DB Benchmark where random reads does not consider full key range. · e30dec93
      Yueh-Hsuan Chiang 提交于
      Summary: Fixed a bug in Java DB Benchmark where random reads does not consider full key range.
      
      Test Plan:
      make rocksdbjava
      make jdb_bench
      cd java
      jdb_bench.sh --db=/tmp/rocksdb-test --benchmarks=fillseq --use_existing_db=false --num=100000
      jdb_bench.sh --db=/tmp/rocksdb-test --benchmarks=readrandom --use_existing_db=true --num=100000 --reads=1000000
      
      Reviewers: haobo, sdong
      
      Reviewed By: haobo
      
      CC: leveldb
      
      Differential Revision: https://reviews.facebook.net/D18693
      e30dec93
    • Y
      [Java] Make read benchmarks print out found / not-found information. · 93f26436
      Yueh-Hsuan Chiang 提交于
      Summary: Make read benchmarks print out found / not-found information.
      
      Test Plan:
      make rocksdbjava
      make jdb_bench
      cd java
      ./jdb_bench.sh
      
      Reviewers: haobo, sdong
      
      CC: leveldb
      
      Differential Revision: https://reviews.facebook.net/D18699
      93f26436
    • I
      TablePropertiesCollectorFactory · 26f5dd9a
      Igor Canadi 提交于
      Summary:
      This diff addresses task #4296714 and rethinks how users provide us with TablePropertiesCollectors as part of Options.
      
      Here's description of task #4296714:
             I'm debugging #4295529 and noticed that our count of user properties kDeletedKeys is wrong. We're sharing one single InternalKeyPropertiesCollector with all Table Builders. In LOG Files, we're outputting number of kDeletedKeys as connected with a single table, while it's actually the total count of deleted keys since creation of the DB.
      
             For example, this table has 3155 entries and 1391828 deleted keys.
      
      The problem with current approach that we call methods on a single TablePropertiesCollector for all the tables we create. Even worse, we could do it from multiple threads at the same time and TablePropertiesCollector has no way of knowing which table we're calling it for.
      
      Good part: Looks like nobody inside Facebook is using Options::table_properties_collectors. This means we should be able to painfully change the API.
      
      In this change, I introduce TablePropertiesCollectorFactory. For every table we create, we call `CreateTablePropertiesCollector`, which creates a TablePropertiesCollector for a single table. We then use it sequentially from a single thread, which means it doesn't have to be thread-safe.
      
      Test Plan:
      Added a test in table_properties_collector_test that fails on master (build two tables, assert that kDeletedKeys count is correct for the second one).
      Also, all other tests
      
      Reviewers: sdong, dhruba, haobo, kailiu
      
      Reviewed By: kailiu
      
      CC: leveldb
      
      Differential Revision: https://reviews.facebook.net/D18579
      26f5dd9a
    • Y
      [Java] Temporary set the number of BG threads based on the number of BG compactions. · 2082a7d7
      Yueh-Hsuan Chiang 提交于
      Summary:
      Before the Java binding for Env is ready, Java developers have no way to
      control the number of background threads.  This diff provides a temporary
      solution where RocksDB.setMaxBackgroundCompactions() will affect the
      number of background threads.
      
      Note that once Env is ready.  Changes made in this diff should be reverted.
      
      Test Plan:
      make rocksdbjava
      make jtest
      make jdb_bench
      java/jdb_bench.sh
      
      Reviewers: haobo, sdong
      
      Reviewed By: sdong
      
      CC: leveldb
      
      Differential Revision: https://reviews.facebook.net/D18681
      2082a7d7
  8. 13 5月, 2014 3 次提交
  9. 12 5月, 2014 1 次提交
  10. 11 5月, 2014 5 次提交