1. 26 1月, 2017 2 次提交
  2. 25 1月, 2017 4 次提交
    • I
      Remove function from DBImpl that are not used anywhere · 03ca2ac8
      Islam AbdelRahman 提交于
      Summary:
      GetAndRefSuperVersionUnlocked
      ReturnAndCleanupSuperVersionUnlocked
      GetColumnFamilyHandleUnlocked
      
      Are dead code that are not used any where
      Closes https://github.com/facebook/rocksdb/pull/1802
      
      Differential Revision: D4459948
      
      Pulled By: IslamAbdelRahman
      
      fbshipit-source-id: 30fa89d
      03ca2ac8
    • A
      Test merge op covered by range deletion in memtable · b0029bc7
      Andrew Kryczka 提交于
      Summary:
      It's a test case for #1797. Also got rid of kTypeDeletion in the conditional since we treat it the same as kTypeRangeDeletion.
      Closes https://github.com/facebook/rocksdb/pull/1800
      
      Differential Revision: D4451300
      
      Pulled By: ajkr
      
      fbshipit-source-id: b39dda1
      b0029bc7
    • A
      Test range deletion block outlives table reader · d438e1ec
      Andrew Kryczka 提交于
      Summary:
      This test ensures RangeDelAggregator can still access blocks even if it outlives the table readers that created them (detailed description in comments).
      
      I plan to optimize away the extra cache lookup we currently do in BlockBasedTable::NewRangeTombstoneIterator(), as it is ~5% CPU in my random read benchmark in a database with 1k tombstones. This test will help make sure nothing breaks in the process.
      Closes https://github.com/facebook/rocksdb/pull/1739
      
      Differential Revision: D4375954
      
      Pulled By: ajkr
      
      fbshipit-source-id: aef9357
      d438e1ec
    • A
      Version librocksdb.so · fba726e5
      Arun Sharma 提交于
      Summary:
      After make install, I see a directory hierarchy that looks like
      
      ```
      ./usr
      ./usr/include
      ./usr/include/rocksdb
      ./usr/include/rocksdb/filter_policy.h
      [..]
      ./usr/include/rocksdb/iterator.h
      ./usr/include/rocksdb/utilities
      ./usr/include/rocksdb/utilities/ldb_cmd_execute_result.h
      ./usr/include/rocksdb/utilities/lua
      ./usr/include/rocksdb/utilities/lua/rocks_lua_custom_library.h
      ./usr/include/rocksdb/utilities/lua/rocks_lua_util.h
      ./usr/include/rocksdb/utilities/lua/rocks_lua_compaction_filter.h
      ./usr/include/rocksdb/utilities/backupable_db.h
      [..]
      ./usr/include/rocksdb/utilities/env_registry.h
      [..]
      ./usr/include/rocksdb/env.h
      ./usr/lib64
      ./usr/lib64/librocksdb.so.5
      ./usr/lib64/librocksdb.so.5.0.0
      ./usr/lib64/librocksdb.so
      ./usr/lib64/librocksdb.a
      ```
      Closes https://github.com/facebook/rocksdb/pull/1798
      
      Differential Revision: D4456536
      
      Pulled By: yiwu-arbug
      
      fbshipit-source-id: 5494e91
      fba726e5
  3. 24 1月, 2017 3 次提交
  4. 21 1月, 2017 11 次提交
  5. 20 1月, 2017 4 次提交
  6. 19 1月, 2017 3 次提交
  7. 18 1月, 2017 2 次提交
  8. 16 1月, 2017 2 次提交
  9. 14 1月, 2017 2 次提交
  10. 13 1月, 2017 1 次提交
  11. 12 1月, 2017 4 次提交
    • A
      direct reads refactor · dc2584ee
      Aaron Gao 提交于
      Summary:
      direct IO reads refactoring
      remove unnecessary classes and unified interfaces
      tested with db_bench
      
      need more change for options and ON/OFF for different files.
      Since disabled is default, it should be fine now
      Closes https://github.com/facebook/rocksdb/pull/1636
      
      Differential Revision: D4307189
      
      Pulled By: lightmark
      
      fbshipit-source-id: 6991e22
      dc2584ee
    • M
      Abort compactions more reliably when closing DB · d18dd2c4
      Mike Kolupaev 提交于
      Summary:
      DB shutdown aborts running compactions by setting an atomic shutting_down=true that CompactionJob periodically checks. Without this PR it checks it before processing every _output_ value. If compaction filter filters everything out, the compaction is uninterruptible. This PR adds checks for shutting_down on every _input_ value (in CompactionIterator and MergeHelper).
      
      There's also some minor code cleanup along the way.
      Closes https://github.com/facebook/rocksdb/pull/1639
      
      Differential Revision: D4306571
      
      Pulled By: yiwu-arbug
      
      fbshipit-source-id: f050890
      d18dd2c4
    • A
      Guarding extra fallocate call with TRAVIS because its not working pro… · 62384ebe
      Anirban Rahut 提交于
      Summary:
      …perly on travis
      
       There is some old code in PosixWritableFile::Close(), which
      truncates the file to the measured size and then does an extra fallocate
      with KEEP_SIZE. This is commented as a failsafe because in some
      cases ftruncate doesn't do the right job (I don't know of an instance of
      this btw). However doing an fallocate with KEEP_SIZE should not increase
      the file size. However on Travis Worker which is Docker (likely AUFS )
      its not working. There are comments on web that show that the AUFS
      author had initially not implemented fallocate, and then did it later.
      So not sure what is the quality of the implementation.
      Closes https://github.com/facebook/rocksdb/pull/1765
      
      Differential Revision: D4401340
      
      Pulled By: anirbanr-fb
      
      fbshipit-source-id: e2d8100
      62384ebe
    • C
      Performance: Iterate vector by reference · 9f246298
      Changli Gao 提交于
      Summary: Closes https://github.com/facebook/rocksdb/pull/1763
      
      Differential Revision: D4398796
      
      Pulled By: yiwu-arbug
      
      fbshipit-source-id: b82636d
      9f246298
  12. 11 1月, 2017 2 次提交
    • A
      Allow incrementing refcount on cache handles · fe395fb6
      Andrew Kryczka 提交于
      Summary:
      Previously the only way to increment a handle's refcount was to invoke Lookup(), which (1) did hash table lookup to get cache handle, (2) incremented that handle's refcount. For a future DeleteRange optimization, I added a function, Ref(), for when the caller already has a cache handle and only needs to do (2).
      Closes https://github.com/facebook/rocksdb/pull/1761
      
      Differential Revision: D4397114
      
      Pulled By: ajkr
      
      fbshipit-source-id: 9addbe5
      fe395fb6
    • S
      Fix build on FreeBSD · 2172b660
      Sunpoet Po-Chuan Hsieh 提交于
      Summary:
      ```
        CC       utilities/column_aware_encoding_exp.o
      utilities/column_aware_encoding_exp.cc:149:5: error: use of undeclared identifier 'exit'
          exit(1);
          ^
      utilities/column_aware_encoding_exp.cc:154:5: error: use of undeclared identifier 'exit'
          exit(1);
          ^
      utilities/column_aware_encoding_exp.cc:158:5: error: use of undeclared identifier 'exit'
          exit(1);
          ^
      3 errors generated.
      ```
      Closes https://github.com/facebook/rocksdb/pull/1754
      
      Differential Revision: D4399044
      
      Pulled By: IslamAbdelRahman
      
      fbshipit-source-id: fbab5a2
      2172b660