- 26 9月, 2015 10 次提交
-
-
由 Mike Lin 提交于
Override DBImplReadOnly::SyncWAL() to return NotSupported. Previously, calling it caused program abort.
-
由 krad 提交于
Summary: Added email notification for a few jobs and fixed a bug in no_compression script Test Plan: Manual test Reviewers: CC: leveldb@ Task ID: #6968635 Blame Rev:
-
由 Igor Canadi 提交于
Summary: AllocateFromHugePage() can return nullptr, and then we need to try to allocate the block with AllocateNewBlock() Test Plan: arena_test Reviewers: sdong Reviewed By: sdong Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D47607
-
由 Yueh-Hsuan Chiang 提交于
Summary: Fixed a bug which causes rocksdb.flush.write.bytes stat is always zero Test Plan: augment existing db_test Reviewers: sdong, anthony, IslamAbdelRahman, igor Reviewed By: igor Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D47595
-
由 Igor Canadi 提交于
Summary: clang is a bit confused, see here: https://travis-ci.org/facebook/rocksdb/jobs/82214750 Test Plan: travis CI Reviewers: sdong Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D47601
-
由 Igor Canadi 提交于
prevent potential memleaks in Arena::Allocate*()
-
由 jsteemann 提交于
The previous memory allocation procedures tried to allocate memory via `new` or `mmap` and inserted the pointer to the memory into an std::vector afterwards. In case `new` or `mmap` threw or returned a nullptr, no memory was leaking. If `new` or `mmap` worked ok, the following `vector::push_back` could still fail and throw an exception. In this case, the memory just allocated was leaked. The fix is to reserve space in the target memory pointer block beforehand. If this throws, then no memory is allocated nor leaked. If the reserve works but the actual allocation fails, still no memory is leaked, only the target vector will have space for at least one more element than actually required (but this may be reused for the next allocation)
-
由 agiardullo 提交于
Summary: Fixed some bugs in using SingleDelete on a WriteBatchWithIndex and added some tests. Test Plan: new tests Reviewers: sdong, yhchiang, rven, kradhakrishnan, IslamAbdelRahman, igor Reviewed By: igor Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D47529
-
由 Yueh-Hsuan Chiang 提交于
Summary: Fixed a memory leak issue in DBTest.UnremovableSingleDelete Test Plan: valgrind --error-exitcode=2 --leak-check=full ./db_test --gtest_filter="*UnremovableSingleDelete*" Reviewers: sdong, anthony, IslamAbdelRahman, igor Reviewed By: igor Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D47583
-
由 Igor Canadi 提交于
Summary: As title Test Plan: make check Reviewers: yhchiang, sdong Reviewed By: sdong Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D46983
-
- 25 9月, 2015 1 次提交
-
-
由 krad 提交于
Summary: Removing the leveldb@fb.com and making it a command line argument Test Plan: Manual test Reviewers: CC: leveldb@ Task ID: #6968635 Blame Rev:
-
- 24 9月, 2015 9 次提交
-
-
由 Mayank Pundir 提交于
Summary: Test cases for IsBottommostLevel function create FileMetaData objects which were not getting deleted in the destructor. Test Plan: Valgrind check on compaction_picker_test Reviewers: yhchiang, igor, sdong Subscribers: rven, kradhakrishnan, IslamAbdelRahman, dhruba, anthony Differential Revision: https://reviews.facebook.net/D47463
-
由 sdong 提交于
Summary: Recent patch introduced a bug that if non-mmap mode is used, in prefix encoding case, there is a resizing of cur_key_ within the same prefix, we still read prefix from the released buffer. It fails ASAN tests and this commit fixes it. Test Plan: Run the ASAN tests for the failing test case. Reviewers: IslamAbdelRahman, yhchiang, anthony, igor, kradhakrishnan, rven Subscribers: leveldb, dhruba Differential Revision: https://reviews.facebook.net/D47457
-
由 krad 提交于
Summary: Our valgrind testing is buggy and cumbersome in terms of locating the error. It originates from the fact we accumulate all output for the tests. It is extremely hard to locate the point of error. The communication between valgrind and the script is not sturdy. We are experiencing bugs. Simplifying to stop on first error. Test Plan: Run manually Reviewers: sdong igor CC: leveldb@ Task ID: #6968635 Blame Rev:
-
由 Assaf Sela 提交于
Summary: Fix hex2String performance issues by removing sscanf dependency. Also fixed some edge case handling (odd length, bad input). Test Plan: Created a test file which called old and new implementation, and validated results are the same. I'll paste results in the phabricator diff. Reviewers: igor, rven, anthony, IslamAbdelRahman, kradhakrishnan, yhchiang, sdong Reviewed By: sdong Subscribers: thatsafunnyname, leveldb, dhruba Differential Revision: https://reviews.facebook.net/D46785
-
由 Islam AbdelRahman 提交于
Summary: This is an initial version of bulk load feature This diff allow us to create sst files, and then bulk load them later, right now the restrictions for loading an sst file are (1) Memtables are empty (2) Added sst files have sequence number = 0, and existing values in database have sequence number = 0 (3) Added sst files values are not overlapping Test Plan: unit testing Reviewers: igor, ott, sdong Reviewed By: sdong Subscribers: leveldb, ott, dhruba Differential Revision: https://reviews.facebook.net/D39081
-
由 Yueh-Hsuan Chiang 提交于
Summary: Fixed old lint errors in db/filename.cc Test Plan: make Reviewers: igor, sdong, anthony, IslamAbdelRahman Reviewed By: IslamAbdelRahman Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D47445
-
由 Yueh-Hsuan Chiang 提交于
Summary: Fixed old lint errors in db/filename.h Test Plan: make Reviewers: igor, sdong, anthony, IslamAbdelRahman Reviewed By: IslamAbdelRahman Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D47439
-
由 sdong 提交于
Summary: PlainTableReader now only allows mmap-mode. Add the support to non-mmap mode for more flexibility. Refactor the codes to move all logic of reading data to PlainTableKeyDecoder, and consolidate the calls to Read() call and ReadVarint32() call. Implement the calls for both of mmap and non-mmap case seperately. For non-mmap mode, make copy of keys in several places when we need to move the buffer after reading the keys. Test Plan: Add the mode of non-mmap case in plain_table_db_test. Run it in valgrind mode too. Subscribers: leveldb, dhruba Differential Revision: https://reviews.facebook.net/D47187
-
由 sdong 提交于
Summary: RandomAccessFileReader unnecessarily inherited RandomAccessFile, which can introduce unnecessarily extra costs. Remove it. Test Plan: Run all existing tests Reviewers: yhchiang, anthony, igor, kradhakrishnan, rven, IslamAbdelRahman Reviewed By: IslamAbdelRahman Subscribers: leveldb, dhruba Differential Revision: https://reviews.facebook.net/D47409
-
- 23 9月, 2015 5 次提交
-
-
由 krad 提交于
Summary: The job errors with log print step. Removing the step and re-enabling the test case. Test Plan: Manual test run Reviewers: CC: levledb@ Task ID: #6968635 Blame Rev:
-
由 sdong 提交于
Summary: https://reviews.facebook.net/D23343 changed WAL sync bytes to extra fsync. This change does the same for internal stats. Test Plan: Run all existing unit tests and verify results in db_bench. Reviewers: anthony, rven, igor, MarkCallaghan, kradhakrishnan, yhchiang Reviewed By: yhchiang Subscribers: leveldb, dhruba Differential Revision: https://reviews.facebook.net/D47349
-
由 Siying Dong 提交于
Fix Windows constexpr issue and '#ifdef' column_family_test in Release.
-
由 krad 提交于
Summary: Parallel test CI is failing. Reducing noise by temporarily disabling the job Test Plan: Manual Reviewers: CC: leveldb@ Task ID: #6968635 Blame Rev:
-
由 Dmitri Smirnov 提交于
-
- 22 9月, 2015 7 次提交
-
-
由 Yueh-Hsuan Chiang 提交于
Summary: In patch https://reviews.facebook.net/D47067, we change the log level of the initial database information to header level. As a result, even when the InfoLogLevel is set to Fatal, the LOG file of a newly opened rocksdb instance will not be empty. However, the current InfoLogLevelTest expect it should be empty. This patch fixes this issue by enabling InfoLogLevelTest to ignore the Log header. Test Plan: make jtest Reviewers: fyrz, anthony, IslamAbdelRahman, sdong, adamretter Reviewed By: sdong Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D47229
-
由 sdong 提交于
Summary: Add options.compaction_pri, which specifies the policy about which file to compact first. kCompactionPriByLargestSeq will compact oldest files first. Verified the behavior in db_bench but did not write unit tests yet. Also need to make it settable through option string and dynamically changeable. Test Plan: Will write unit tests Reviewers: igor, rven, anthony, kradhakrishnan, IslamAbdelRahman, yhchiang, MarkCallaghan Reviewed By: yhchiang Subscribers: leveldb, dhruba Differential Revision: https://reviews.facebook.net/D45951
-
由 Dmitri Smirnov 提交于
-
由 Dmitri Smirnov 提交于
-
由 krad 提交于
Summary: Long running jobs are blocking the queue due to lack of adequate machines in the CI Test Plan: Manual testing Reviewers: CC: leveldb@ Task ID: #6968635 Blame Rev:
-
由 Igor Canadi 提交于
add missing header required for std::function
-
由 Igor Canadi 提交于
Micro optimizations
-
- 20 9月, 2015 1 次提交
-
-
由 krad 提交于
Summary: The approach to serialize long scripts as string is flawed. Instead adding args to invoke the long scripts. Test Plan: Manual test Reviewers: CC: leveldb@ Task ID: #6968635 Blame Rev:
-
- 19 9月, 2015 7 次提交
-
-
由 krad 提交于
Summary: Migrating the long script jobs and the left overs from Jenkin. Test Plan: Run command manually Reviewers: sdon igor CC: leveldb@ Task ID: #6968635 Blame Rev:
-
由 jsteemann 提交于
otherwise Visual Studio will have trouble compiling this file
-
由 jsteemann 提交于
-
由 jsteemann 提交于
-
由 jsteemann 提交于
this may lead to copying less data (in case compilers don't optimize away copying the string by themselves)
-
由 jsteemann 提交于
(ignoring the unlikely case that some overrides `operator new throw(std::bad_alloc)` with a function that returns a nullptr)
-
由 jsteemann 提交于
-