1. 25 3月, 2015 10 次提交
  2. 24 3月, 2015 10 次提交
  3. 23 3月, 2015 2 次提交
  4. 21 3月, 2015 1 次提交
  5. 20 3月, 2015 7 次提交
    • I
      rocksdb: print status error message when (ASSERT|EXPECT)_OK fails · 28bc6de9
      Igor Sugak 提交于
      Summary: Modified rocksdb status assertions ASSERT_OK and EXPECT_OK to print error message from Status::ToString() when failed.
      
      Test Plan: Modify a test to fail status assertions ASSERT_OK and EXPECT_OK and notice an error message that came from Status::ToString()
      
      Reviewers: meyering, sdong, yhchiang, igor
      
      Reviewed By: igor
      
      Subscribers: dhruba, leveldb
      
      Differential Revision: https://reviews.facebook.net/D35469
      28bc6de9
    • I
      rocksdb: Remove #include "util/string_util.h" from util/testharness.h · 9405b5ef
      Igor Sugak 提交于
      Summary:
      1. Manually deleted #include "util/string_util.h" from util/testharness.h
      2.
      ```
      % USE_CLANG=1 make all -j55 -k 2> build.log
      % perl -naF: -E 'say $F[0] if /: error:/' build.log | sort -u | xargs sed -i '/#include "util\/testharness.h"/i #include "util\/string_util.h"'
      ```
      
      Test Plan:
      Make sure make all completes with no errors.
      ```
      % make all -j55
      ```
      
      Reviewers: meyering, igor, sdong
      
      Reviewed By: sdong
      
      Subscribers: dhruba, leveldb
      
      Differential Revision: https://reviews.facebook.net/D35493
      9405b5ef
    • I
      rocksdb: Remove #include "util/random.h" from util/testharness.h · 220d0dff
      Igor Sugak 提交于
      Summary: Cleaning util/testharness.h
      
      Test Plan:
      Make completes with no errors.
      ```
      % make all
      ```
      
      Reviewers: meyering, igor, sdong
      
      Reviewed By: sdong
      
      Subscribers: dhruba, leveldb
      
      Differential Revision: https://reviews.facebook.net/D35487
      220d0dff
    • I
      Don't delete files when column family is dropped · b088c83e
      Igor Canadi 提交于
      Summary:
      To understand the bug read t5943287 and check out the new test in column_family_test (ReadDroppedColumnFamily), iter 0.
      
      RocksDB contract allowes you to read a drop column family as long as there is a live reference. However, since our iteration ignores dropped column families, AddLiveFiles() didn't mark files of a dropped column families as live. So we deleted them.
      
      In this patch I no longer ignore dropped column families in the iteration. I think this behavior was confusing and it also led to this bug. Now if an iterator client wants to ignore dropped column families, he needs to do it explicitly.
      
      Test Plan: Added a new unit test that is failing on master. Unit test succeeds now.
      
      Reviewers: sdong, rven, yhchiang
      
      Reviewed By: yhchiang
      
      Subscribers: dhruba, leveldb
      
      Differential Revision: https://reviews.facebook.net/D32535
      b088c83e
    • I
      rocksdb: initial util/testharness clean up · 17ae3fcb
      Igor Sugak 提交于
      Summary: Deleted some redundant code. More comming.
      
      Test Plan:
      ```lang=bash
      % USE_CLANG=1 make check
      ```
      
      Reviewers: meyering, sdong, igor
      
      Reviewed By: igor
      
      Subscribers: dhruba, leveldb
      
      Differential Revision: https://reviews.facebook.net/D35463
      17ae3fcb
    • F
      [RocksJava] Enhanced Logger comment · 39f4271b
      fyrz 提交于
      Added information about performance penalties using a custom
      logger implementation.
      39f4271b
    • F
      [RocksJava] 32-Bit adjustments · 5615e23d
      fyrz 提交于
      Summary:
      Before this change overflowing size_t values led to a checked Exception.
      
      After that change:
      
      size_t overflows on 32-Bit architecture throw now an IllegalArgumentException,
      which removes the necessity for a developer to catch these Exceptions explicitly.
      
      This is especially an advantage for developers targeting 64-Bit systems because
      it is not necessary anymore to catch exceptions which are never thrown on a 64-Bit
      system.
      
      Test Plan:
      make clean jclean rocksdbjava jtest
      mvn -f rocksjni.pom package
      
      Reviewers: adamretter, yhchiang, ankgup87
      
      Subscribers: dhruba
      
      Differential Revision: https://reviews.facebook.net/D34923
      5615e23d
  6. 19 3月, 2015 10 次提交
    • A
      Merge pull request #532 from fyrz/RocksJava-LevelCompactionDynamicLevelBytes · 836bcc2f
      Adam Retter 提交于
      [RocksJava] Added LevelCompactionDynamicLevelBytes to Options
      836bcc2f
    • I
      rocksdb: fix make unity · 67d99580
      Igor Sugak 提交于
      Summary:
      changed make unity target to use $LIB_SOURCES as a source of library source code. In the old way (using find) table/mock_table.h was added to a list of library objects and this was a course of `make unity` break.
      
      `build_tools/unity` contains some redundant code, I deleted it and moved the functionality in the Makefile.
      
      Test Plan:
      Make sure unity completes with no errors.
      ```lang=bash
      % make unity
      ```
      
      Reviewers: sdong, rven, igor, meyering
      
      Reviewed By: igor, meyering
      
      Subscribers: dhruba, leveldb
      
      Differential Revision: https://reviews.facebook.net/D35385
      67d99580
    • I
      Clean up compactions_in_progress_ · 52e0f335
      Igor Canadi 提交于
      Summary: Suprisingly, the only way we use this vector is to keep track of level0 compactions. Thus, I simplified it.
      
      Test Plan: make check
      
      Reviewers: rven, yhchiang, sdong
      
      Reviewed By: sdong
      
      Subscribers: dhruba, leveldb
      
      Differential Revision: https://reviews.facebook.net/D35313
      52e0f335
    • I
      rocksdb: change db_test::MultiThreadedDBTest as value parameterized test. · 6b626ff2
      Igor Sugak 提交于
      Summary: This is a simple change to make db_test::MultiThreadedDBTest as value parameterized test. There is a value of creating a separate set of such tests later.
      
      Test Plan:
      ```lang=bash
      % make db_test
      % ./make db_test
      ```
      
      Also with the following command I can execute all db_test in 2:37.87 on my box
      ```
      % ./db_test --gtest_list_tests | sed 's/\# GetParam.*//' | tr -d ' ' | env time parallel --gnu --eta --joblog=LOG -- 'TEST_TMPDIR=/dev/shm/rocksdb-{} ./db_test --gtest_filter="*{}"'
      ```
      
      Reviewers: igor, rven, meyering, sdong
      
      Reviewed By: meyering
      
      Subscribers: dhruba, leveldb
      
      Differential Revision: https://reviews.facebook.net/D35361
      6b626ff2
    • S
      A build option to run through all check-in requirements. · 9720ea4d
      sdong 提交于
      Summary: Make it easier for people to run all the tests.
      
      Test Plan: Run it.
      
      Reviewers: rven, yhchiang, igor, MarkCallaghan, IslamAbdelRahman, igor.sugak, anthony, kradhakrishnan, meyering
      
      Reviewed By: meyering
      
      Subscribers: meyering, leveldb, dhruba
      
      Differential Revision: https://reviews.facebook.net/D35319
      9720ea4d
    • S
      Add a DB Property For Number of Deletions in Memtables · 0831a359
      sdong 提交于
      Summary: Add a DB property for number of deletions in memtables. It can sometimes help people debug slowness because of too many deletes.
      
      Test Plan: Add test cases.
      
      Reviewers: rven, yhchiang, kradhakrishnan, igor
      
      Reviewed By: igor
      
      Subscribers: leveldb, dhruba, yoshinorim
      
      Differential Revision: https://reviews.facebook.net/D35247
      0831a359
    • Y
      Fix RocksJava test failure due to deprecation of table_cache_remove_scan_count_limit · f7ed6546
      Yueh-Hsuan Chiang 提交于
      Summary:
      table_cache_remove_scan_count_limit is marked as deprecated in RocksDB C++.
      (see rocksdb/options.h).  This patch made necessary changes on RocksJava
      side.
      
      Test Plan:
      make rocksdbjava -j32
      make jtest
      
      Reviewers: rven, igor, fyrz, adamretter, ankgup87, sdong
      
      Reviewed By: sdong
      
      Subscribers: dhruba, leveldb
      
      Differential Revision: https://reviews.facebook.net/D35355
      f7ed6546
    • I
      Enable dynamic changing of rate limiter's bytes_per_second · 51301b86
      Igor Canadi 提交于
      Summary: This feature is going to be useful for mongodb+rocksdb. I'll expose it through mongo's API.
      
      Test Plan: added new unit test. also will run TSAN on the new unit test
      
      Reviewers: meyering, sdong
      
      Reviewed By: meyering, sdong
      
      Subscribers: meyering, dhruba, leveldb
      
      Differential Revision: https://reviews.facebook.net/D35307
      51301b86
    • Y
      Fix compilation error in rocksjni/write_batch_test.cc · 652db51a
      Yueh-Hsuan Chiang 提交于
      Summary: Fix compilation error in rocksjni/write_batch_test.cc
      
      Test Plan: make rocksdbjava -j32
      
      Reviewers: sdong, igor, rven
      
      Subscribers: dhruba, leveldb
      
      Differential Revision: https://reviews.facebook.net/D35343
      652db51a
    • M
      Add readwhilemerging benchmark · dfccc7b4
      Mark Callaghan 提交于
      Summary:
      This is like readwhilewriting but uses Merge rather than Put in the writer thread.
      I am using it for in-progress benchmarks. I don't think the other benchmarks for Merge
      cover this behavior. The purpose for this test is to measure read performance when
      readers might have to merge results. This will also benefit from work-in-progress
      to add skewed key generation.
      
      Task ID: #
      
      Blame Rev:
      
      Test Plan:
      Revert Plan:
      
      Database Impact:
      
      Memcache Impact:
      
      Other Notes:
      
      EImportant:
      
      - begin *PUBLIC* platform impact section -
      Bugzilla: #
      - end platform impact -
      
      Reviewers: igor
      
      Reviewed By: igor
      
      Subscribers: dhruba
      
      Differential Revision: https://reviews.facebook.net/D35115
      dfccc7b4