1. 09 3月, 2017 3 次提交
  2. 08 3月, 2017 4 次提交
  3. 07 3月, 2017 3 次提交
    • M
      Expose DB::DeleteRange and WriteBath::DeleteRange in Java · 5f65dc87
      Matteo Merli 提交于
      Summary:
      Added JNI wrapper from `DeleteRange` methods
      Closes https://github.com/facebook/rocksdb/pull/1951
      
      Differential Revision: D4657746
      
      Pulled By: yiwu-arbug
      
      fbshipit-source-id: 3fc7ab8
      5f65dc87
    • R
      Set logs as getting flushed before releasing lock, race condition fix · 58b12dfe
      Reid Horuff 提交于
      Summary:
      Relating to #1903:
      
      In MaybeFlushColumnFamilies() we want to modify the 'getting_flushed' flag before releasing the db mutex when SwitchMemtable() is called.
      
      The following 2 actions need to be atomic in MaybeFlushColumnFamilies()
      - getting_flushed is false on oldest log
      - we determine that all CFs can be flushed to successfully release oldest log
      - we set getting_flushed = true on the oldest log.
      -------
      - getting_flushed is false on oldest log
      - we determine that all CFs can NOT be flushed to successfully release oldest log
      - we set unable_to_flush_oldest_log_ = true on the oldest log.
      
      #### In the 2pc case:
      
      T1 enters function but is unable to flush all CFs to release log
      T1 sets unable_to_flush_oldest_log_ = true
      T1 begins flushing all CFs possible
      
      T2 enters function but is unable to flush all CFs to release log
      T2 sees unable_to_flush_oldes_log_ has been set so exits
      
      T3 enters function and will be able to flush all CFs to release oldest log
      T3 sets getting_flushed = true on oldes
      Closes https://github.com/facebook/rocksdb/pull/1909
      
      Differential Revision: D4646235
      
      Pulled By: reidHoruff
      
      fbshipit-source-id: c8d0447
      58b12dfe
    • S
      Move db_test and external_sst_file_test out of Travis's MAC OS run · f8a4ea02
      Siying Dong 提交于
      Summary:
      After we have db_basic_test and external_sst_file_basic_test, we don't need to run db_test and external_sst_file_test in Travis's MAC OS run anymore. Move it out.
      Closes https://github.com/facebook/rocksdb/pull/1940
      
      Differential Revision: D4659361
      
      Pulled By: siying
      
      fbshipit-source-id: e64e291
      f8a4ea02
  4. 06 3月, 2017 1 次提交
    • M
      Fix a bug in tests in options operator= · 534581a3
      Maysam Yabandeh 提交于
      Summary:
      Note: Using the default operator= is an unsafe approach for Options since it destructs shared_ptr in
      the same order of their creation, in contrast to destructors which
      destructs them in the opposite order of creation. One particular problme is
      that the cache destructor might invoke callback functions that use Option
      members such as statistics. To work around this problem, we manually call
      destructor of table_facotry which eventually clears the block cache.
      Closes https://github.com/facebook/rocksdb/pull/1950
      
      Differential Revision: D4655473
      
      Pulled By: maysamyabandeh
      
      fbshipit-source-id: 6c4bbff
      534581a3
  5. 04 3月, 2017 3 次提交
  6. 03 3月, 2017 6 次提交
  7. 01 3月, 2017 4 次提交
  8. 28 2月, 2017 7 次提交
    • I
      Move advanced column family options to advanced_options.h · 08864df2
      Islam AbdelRahman 提交于
      Summary:
      For the sake of making our options simpler, we should keep options.h as simple as possible and move more advanced/less common options to advaned_options.h
      
      I started with ColumnFamilyOptions and also did some re-ordering
      
      I have moved all ColumnFamilyOptions to advanced_options.h and only left these options in options.h
      
      ```
      const Comparator* comparator = BytewiseComparator();
      std::shared_ptr<MergeOperator> merge_operator = nullptr;
      const CompactionFilter* compaction_filter = nullptr;
      std::shared_ptr<CompactionFilterFactory> compaction_filter_factory = nullptr;
      size_t write_buffer_size = 64 << 20;
      CompressionType compression;
      int level0_file_num_compaction_trigger = 4;
      bool disable_auto_compactions = false;
      ```
      Please feel free to comment on specific options if you think they should be advanced or should not be
      Closes https://github.com/facebook/rocksdb/pull/1847
      
      Differential Revision: D4519996
      
      Pulled By: IslamAbdelRahman
      
      fbshipit-source-id: abebd9a
      08864df2
    • P
      Get unique_ptr to use delete[] for char[] in DumpMallocStats · 2ca2059f
      Peter (Stig) Edwards 提交于
      Summary:
      Avoid mismatched free() / delete / delete [] in DumpMallocStats
      Closes https://github.com/facebook/rocksdb/pull/1927
      
      Differential Revision: D4622045
      
      Pulled By: siying
      
      fbshipit-source-id: 1131b30
      2ca2059f
    • T
      Add missing include for `abort()` · 253799c0
      Tamir Duberstein 提交于
      Summary:
      Fixes #1233 (again).
      Closes https://github.com/facebook/rocksdb/pull/1931
      
      Differential Revision: D4625289
      
      Pulled By: ajkr
      
      fbshipit-source-id: 70e774e
      253799c0
    • A
      Fixed various memory leaks and Java 8 JNI Compatibility · c6d464a9
      Adam Retter 提交于
      Summary:
      I have manually audited the entire RocksJava code base.
      
      Sorry for the large pull-request, I have broken it down into many small atomic commits though.
      
      My initial intention was to fix the warnings that appear when running RocksJava on Java 8 with `-Xcheck:jni`, for example when running `make jtest` you would see many errors similar to:
      
      ```
      WARNING in native method: JNI call made without checking exceptions when required to from CallObjectMethod
      WARNING in native method: JNI call made without checking exceptions when required to from CallVoidMethod
      WARNING in native method: JNI call made without checking exceptions when required to from CallStaticVoidMethod
      ...
      ```
      
      A few of those warnings still remain, however they seem to come directly from the JVM and are not directly related to RocksJava; I am in contact with the OpenJDK hostpot-dev mailing list about these - http://mail.openjdk.java.net/pipermail/hotspot-dev/2017-February/025981.html.
      
      As a result of fixing these, I realised we were not r
      Closes https://github.com/facebook/rocksdb/pull/1890
      
      Differential Revision: D4591758
      
      Pulled By: siying
      
      fbshipit-source-id: 7f7fdf4
      c6d464a9
    • I
      Fix unaligned reads in read cache · be3e5568
      Islam AbdelRahman 提交于
      Summary:
      - Fix unaligned reads in read cache by using RandomAccessFileReader
      - Allow read cache flags in db_bench
      Closes https://github.com/facebook/rocksdb/pull/1916
      
      Differential Revision: D4610885
      
      Pulled By: IslamAbdelRahman
      
      fbshipit-source-id: 2aa1dc8
      be3e5568
    • S
      Separate small subset tests in DBTest · 8ad0fcdf
      Siying Dong 提交于
      Summary:
      Separate a smal subset of tests in DBTest to DBBasicTest. Tests in DBTest don't have to run in CI tests on platforms like OSX, as long as they are covered by Linux.
      Closes https://github.com/facebook/rocksdb/pull/1924
      
      Differential Revision: D4616702
      
      Pulled By: siying
      
      fbshipit-source-id: 13e6549
      8ad0fcdf
    • S
      Run fewer tests in OSX · 6c951c43
      Siying Dong 提交于
      Summary:
      Travis is short of OSX resource. Try to move platform independent test suites out of OSX
      Closes https://github.com/facebook/rocksdb/pull/1922
      
      Differential Revision: D4616070
      
      Pulled By: siying
      
      fbshipit-source-id: 786342c
      6c951c43
  9. 24 2月, 2017 9 次提交