提交 bc898c5f 编写于 作者: A Alex Loukissas

Fix unused parameter warnings.

上级 138876a6
...@@ -258,9 +258,9 @@ class DB { ...@@ -258,9 +258,9 @@ class DB {
// This check is potentially lighter-weight than invoking DB::Get(). One way // This check is potentially lighter-weight than invoking DB::Get(). One way
// to make this lighter weight is to avoid doing any IOs. // to make this lighter weight is to avoid doing any IOs.
// Default implementation here returns true and sets 'value_found' to false // Default implementation here returns true and sets 'value_found' to false
virtual bool KeyMayExist(const ReadOptions& options, virtual bool KeyMayExist(const ReadOptions&,
ColumnFamilyHandle* column_family, const Slice& key, ColumnFamilyHandle*, const Slice&,
std::string* value, bool* value_found = nullptr) { std::string*, bool* value_found = nullptr) {
if (value_found != nullptr) { if (value_found != nullptr) {
*value_found = false; *value_found = false;
} }
...@@ -502,8 +502,8 @@ class DB { ...@@ -502,8 +502,8 @@ class DB {
return CompactRange(options, DefaultColumnFamily(), begin, end); return CompactRange(options, DefaultColumnFamily(), begin, end);
} }
virtual Status SetOptions(ColumnFamilyHandle* column_family, virtual Status SetOptions(ColumnFamilyHandle*,
const std::unordered_map<std::string, std::string>& new_options) { const std::unordered_map<std::string, std::string>&) {
return Status::NotSupported("Not implemented"); return Status::NotSupported("Not implemented");
} }
virtual Status SetOptions( virtual Status SetOptions(
...@@ -653,7 +653,7 @@ class DB { ...@@ -653,7 +653,7 @@ class DB {
// Returns a list of all table files with their level, start key // Returns a list of all table files with their level, start key
// and end key // and end key
virtual void GetLiveFilesMetaData(std::vector<LiveFileMetaData>* metadata) {} virtual void GetLiveFilesMetaData(std::vector<LiveFileMetaData>*) {}
// Obtains the meta data of the specified column family of the DB. // Obtains the meta data of the specified column family of the DB.
// Status::NotFound() will be returned if the current DB does not have // Status::NotFound() will be returned if the current DB does not have
...@@ -662,8 +662,7 @@ class DB { ...@@ -662,8 +662,7 @@ class DB {
// If cf_name is not specified, then the metadata of the default // If cf_name is not specified, then the metadata of the default
// column family will be returned. // column family will be returned.
virtual void GetColumnFamilyMetaData( virtual void GetColumnFamilyMetaData(
ColumnFamilyHandle* column_family, ColumnFamilyHandle*, ColumnFamilyMetaData*) {}
ColumnFamilyMetaData* metadata) {}
// Get the metadata of the default column family. // Get the metadata of the default column family.
void GetColumnFamilyMetaData( void GetColumnFamilyMetaData(
......
...@@ -150,8 +150,7 @@ class EventListener { ...@@ -150,8 +150,7 @@ class EventListener {
// Note that the this function must be implemented in a way such that // Note that the this function must be implemented in a way such that
// it should not run for an extended period of time before the function // it should not run for an extended period of time before the function
// returns. Otherwise, RocksDB may be blocked. // returns. Otherwise, RocksDB may be blocked.
virtual void OnFlushCompleted( virtual void OnFlushCompleted(DB*, const FlushJobInfo&) {}
DB* db, const FlushJobInfo& flush_job_info) {}
// A call-back function for RocksDB which will be called whenever // A call-back function for RocksDB which will be called whenever
// a SST file is deleted. Different from OnCompactionCompleted and // a SST file is deleted. Different from OnCompactionCompleted and
...@@ -164,8 +163,7 @@ class EventListener { ...@@ -164,8 +163,7 @@ class EventListener {
// Note that if applications would like to use the passed reference // Note that if applications would like to use the passed reference
// outside this function call, they should make copies from the // outside this function call, they should make copies from the
// returned value. // returned value.
virtual void OnTableFileDeleted( virtual void OnTableFileDeleted(const TableFileDeletionInfo&) {}
const TableFileDeletionInfo& info) {}
// A call-back function for RocksDB which will be called whenever // A call-back function for RocksDB which will be called whenever
// a registered RocksDB compacts a file. The default implementation // a registered RocksDB compacts a file. The default implementation
...@@ -180,7 +178,7 @@ class EventListener { ...@@ -180,7 +178,7 @@ class EventListener {
// @param ci a reference to a CompactionJobInfo struct. 'ci' is released // @param ci a reference to a CompactionJobInfo struct. 'ci' is released
// after this function is returned, and must be copied if it is needed // after this function is returned, and must be copied if it is needed
// outside of this function. // outside of this function.
virtual void OnCompactionCompleted(DB *db, const CompactionJobInfo& ci) {} virtual void OnCompactionCompleted(DB*, const CompactionJobInfo&) {}
// A call-back function for RocksDB which will be called whenever // A call-back function for RocksDB which will be called whenever
// a SST file is created. Different from OnCompactionCompleted and // a SST file is created. Different from OnCompactionCompleted and
...@@ -194,7 +192,7 @@ class EventListener { ...@@ -194,7 +192,7 @@ class EventListener {
// outside this function call, they should make copies from these // outside this function call, they should make copies from these
// returned value. // returned value.
virtual void OnTableFileCreated( virtual void OnTableFileCreated(
const TableFileCreationInfo& info) {} const TableFileCreationInfo&) {}
virtual ~EventListener() {} virtual ~EventListener() {}
}; };
......
...@@ -105,9 +105,7 @@ class TablePropertiesCollector { ...@@ -105,9 +105,7 @@ class TablePropertiesCollector {
// DEPRECATE User defined collector should implement AddUserKey(), though // DEPRECATE User defined collector should implement AddUserKey(), though
// this old function still works for backward compatible reason. // this old function still works for backward compatible reason.
// Add() will be called when a new key/value pair is inserted into the table. // Add() will be called when a new key/value pair is inserted into the table.
// @params key the user key that is inserted into the table. virtual Status Add(const Slice&, const Slice&) {
// @params value the value that is inserted into the table.
virtual Status Add(const Slice& key, const Slice& value) {
return Status::InvalidArgument( return Status::InvalidArgument(
"TablePropertiesCollector::Add() deprecated."); "TablePropertiesCollector::Add() deprecated.");
} }
...@@ -116,10 +114,8 @@ class TablePropertiesCollector { ...@@ -116,10 +114,8 @@ class TablePropertiesCollector {
// table. // table.
// @params key the user key that is inserted into the table. // @params key the user key that is inserted into the table.
// @params value the value that is inserted into the table. // @params value the value that is inserted into the table.
// @params file_size file size up to now
virtual Status AddUserKey(const Slice& key, const Slice& value, virtual Status AddUserKey(const Slice& key, const Slice& value,
EntryType type, SequenceNumber seq, EntryType, SequenceNumber, uint64_t) {
uint64_t file_size) {
// For backwards-compatibility. // For backwards-compatibility.
return Add(key, value); return Add(key, value);
} }
......
...@@ -147,7 +147,7 @@ class WriteBatch : public WriteBatchBase { ...@@ -147,7 +147,7 @@ class WriteBatch : public WriteBatchBase {
return Status::InvalidArgument( return Status::InvalidArgument(
"non-default column family and PutCF not implemented"); "non-default column family and PutCF not implemented");
} }
virtual void Put(const Slice& key, const Slice& value) {} virtual void Put(const Slice&, const Slice&) {}
virtual Status DeleteCF(uint32_t column_family_id, const Slice& key) { virtual Status DeleteCF(uint32_t column_family_id, const Slice& key) {
if (column_family_id == 0) { if (column_family_id == 0) {
...@@ -157,7 +157,7 @@ class WriteBatch : public WriteBatchBase { ...@@ -157,7 +157,7 @@ class WriteBatch : public WriteBatchBase {
return Status::InvalidArgument( return Status::InvalidArgument(
"non-default column family and DeleteCF not implemented"); "non-default column family and DeleteCF not implemented");
} }
virtual void Delete(const Slice& key) {} virtual void Delete(const Slice&) {}
virtual Status SingleDeleteCF(uint32_t column_family_id, const Slice& key) { virtual Status SingleDeleteCF(uint32_t column_family_id, const Slice& key) {
if (column_family_id == 0) { if (column_family_id == 0) {
...@@ -167,7 +167,7 @@ class WriteBatch : public WriteBatchBase { ...@@ -167,7 +167,7 @@ class WriteBatch : public WriteBatchBase {
return Status::InvalidArgument( return Status::InvalidArgument(
"non-default column family and SingleDeleteCF not implemented"); "non-default column family and SingleDeleteCF not implemented");
} }
virtual void SingleDelete(const Slice& key) {} virtual void SingleDelete(const Slice&) {}
// Merge and LogData are not pure virtual. Otherwise, we would break // Merge and LogData are not pure virtual. Otherwise, we would break
// existing clients of Handler on a source code level. The default // existing clients of Handler on a source code level. The default
...@@ -181,7 +181,7 @@ class WriteBatch : public WriteBatchBase { ...@@ -181,7 +181,7 @@ class WriteBatch : public WriteBatchBase {
return Status::InvalidArgument( return Status::InvalidArgument(
"non-default column family and MergeCF not implemented"); "non-default column family and MergeCF not implemented");
} }
virtual void Merge(const Slice& key, const Slice& value) {} virtual void Merge(const Slice&, const Slice&) {}
// The default implementation of LogData does nothing. // The default implementation of LogData does nothing.
virtual void LogData(const Slice& blob); virtual void LogData(const Slice& blob);
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册