• M
    Counter for merge failure · f1bf1694
    Mayank Agarwal 提交于
    Summary:
    With Merge returning bool, it can keep failing silently(eg. While faling to fetch timestamp in TTL). We need to detect this through a rocksdb counter which can get bumped whenever Merge returns false. This will also be super-useful for the mcrocksdb-counter service where Merge may fail.
    Added a counter NUMBER_MERGE_FAILURES and appropriately updated db/merge_helper.cc
    
    I felt that it would be better to directly add counter-bumping in Merge as a default function of MergeOperator class but user should not be aware of this, so this approach seems better to me.
    
    Test Plan: make all check
    
    Reviewers: dnicholas, haobo, dhruba, vamsi
    
    CC: leveldb
    
    Differential Revision: https://reviews.facebook.net/D12129
    f1bf1694
memtable.h 4.3 KB