• M
    Make WithParamInterface virtual in transaction_test · ec225d2e
    Maysam Yabandeh 提交于
    Summary:
    Without this patch, ubsan_check is currently failing with this error:
    ```
    utilities/transactions/write_prepared_transaction_test.cc:369:63: runtime error: member call on address 0x0000051649f8 which does not point to an object of type 'WithParamInterface'
    0x0000051649f8: note: object has invalid vptr
    ```
    Tested by `COMPILE_WITH_UBSAN=1 make -j32 transaction_test` and running `./write_prepared_transaction_test --gtest_filter=TwoWriteQueues/SnapshotConcurrentAccessTest.SnapshotConcurrentAccessTest1/0`
    Closes https://github.com/facebook/rocksdb/pull/3444
    
    Differential Revision: D6850087
    
    Pulled By: maysamyabandeh
    
    fbshipit-source-id: 5b254da8504b8757f7aec8a820ad464154da1a1d
    ec225d2e
transaction_test.h 13.0 KB