• B
    Added memtable garbage statistics (#8411) · e817bc96
    Baptiste Lemaire 提交于
    Summary:
    **Summary**:
    2 new statistics counters are added to RocksDB: `MEMTABLE_PAYLOAD_BYTES_AT_FLUSH` and `MEMTABLE_GARBAGE_BYTES_AT_FLUSH`. The former tracks how many raw bytes of useful data are present on the memtable at flush time, whereas the latter is tracks how many of these raw bytes are considered garbage, meaning that they ended up not being imported on the SSTables resulting from the flush operations.
    
    **Unit test**: run `make db_flush_test -j$(nproc); ./db_flush_test` to run the unit test.
    This executable includes 3 tests, that test support and correct stat calculations for workloads with inserts, deletes, and DeleteRanges. The parameters are set such that the workloads are performed on a single memtable, and a single SSTable is created as a result of the flush operation. The flush operation is manually called in the test file. The tests verify that the values of these 2 statistics counters introduced in this PR  can be exactly predicted, showing that we have a full understanding of the underlying operations.
    
    **Performance testing**:
    `./db_bench -statistics -benchmarks=fillrandom -num=10000000` repeated 10 times.
    Timing done using "date" function in a bash script.
    _Results_:
    Original Rocksdb fork: mean 66.6 sec, std 1.18 sec.
    This feature branch: mean 67.4 sec, std 1.35 sec.
    
    Pull Request resolved: https://github.com/facebook/rocksdb/pull/8411
    
    Reviewed By: akankshamahajan15
    
    Differential Revision: D29150629
    
    Pulled By: bjlemaire
    
    fbshipit-source-id: 7b3c2e86d50c6aa34fa50fd134282eacb543a5b1
    e817bc96
statistics.cc 20.4 KB