• M
    Add a SystemClock class to capture the time functions of an Env (#7858) · 12f11373
    mrambacher 提交于
    Summary:
    Introduces and uses a SystemClock class to RocksDB.  This class contains the time-related functions of an Env and these functions can be redirected from the Env to the SystemClock.
    
    Many of the places that used an Env (Timer, PerfStepTimer, RepeatableThread, RateLimiter, WriteController) for time-related functions have been changed to use SystemClock instead.  There are likely more places that can be changed, but this is a start to show what can/should be done.  Over time it would be nice to migrate most (if not all) of the uses of the time functions from the Env to the SystemClock.
    
    There are several Env classes that implement these functions.  Most of these have not been converted yet to SystemClock implementations; that will come in a subsequent PR.  It would be good to unify many of the Mock Timer implementations, so that they behave similarly and be tested similarly (some override Sleep, some use a MockSleep, etc).
    
    Additionally, this change will allow new methods to be introduced to the SystemClock (like https://github.com/facebook/rocksdb/issues/7101 WaitFor) in a consistent manner across a smaller number of classes.
    
    Pull Request resolved: https://github.com/facebook/rocksdb/pull/7858
    
    Reviewed By: pdillinger
    
    Differential Revision: D26006406
    
    Pulled By: mrambacher
    
    fbshipit-source-id: ed10a8abbdab7ff2e23d69d85bd25b3e7e899e90
    12f11373
db_iter.cc 50.5 KB