• H
    Account memory of FileMetaData in global memory limit (#9924) · d665afdb
    Hui Xiao 提交于
    Summary:
    **Context/Summary:**
    As revealed by heap profiling, allocation of `FileMetaData` for [newly created file added to a Version](https://github.com/facebook/rocksdb/pull/9924/files#diff-a6aa385940793f95a2c5b39cc670bd440c4547fa54fd44622f756382d5e47e43R774) can consume significant heap memory. This PR is to account that toward our global memory limit based on block cache capacity.
    
    Pull Request resolved: https://github.com/facebook/rocksdb/pull/9924
    
    Test Plan:
    - Previous `make check` verified there are only 2 places where the memory of  the allocated `FileMetaData` can be released
    - New unit test `TEST_P(ChargeFileMetadataTestWithParam, Basic)`
    - db bench (CPU cost of `charge_file_metadata` in write and compact)
       - **write micros/op: -0.24%** : `TEST_TMPDIR=/dev/shm/testdb ./db_bench -benchmarks=fillseq -db=$TEST_TMPDIR -charge_file_metadata=1 (remove this option for pre-PR) -disable_auto_compactions=1 -write_buffer_size=100000 -num=4000000 | egrep 'fillseq'`
       - **compact micros/op -0.87%** : `TEST_TMPDIR=/dev/shm/testdb ./db_bench -benchmarks=fillseq -db=$TEST_TMPDIR -charge_file_metadata=1 -disable_auto_compactions=1 -write_buffer_size=100000 -num=4000000 -numdistinct=1000 && ./db_bench -benchmarks=compact -db=$TEST_TMPDIR -use_existing_db=1 -charge_file_metadata=1 -disable_auto_compactions=1 | egrep 'compact'`
    
    table 1 - write
    
    #-run | (pre-PR) avg micros/op | std micros/op | (post-PR)  micros/op | std micros/op | change (%)
    -- | -- | -- | -- | -- | --
    10 | 3.9711 | 0.264408 | 3.9914 | 0.254563 | 0.5111933721
    20 | 3.83905 | 0.0664488 | 3.8251 | 0.0695456 | -0.3633711465
    40 | 3.86625 | 0.136669 | 3.8867 | 0.143765 | 0.5289363078
    80 | 3.87828 | 0.119007 | 3.86791 | 0.115674 | **-0.2673865734**
    160 | 3.87677 | 0.162231 | 3.86739 | 0.16663 | **-0.2419539978**
    
    table 2 - compact
    
    #-run | (pre-PR) avg micros/op | std micros/op | (post-PR)  micros/op | std micros/op | change (%)
    -- | -- | -- | -- | -- | --
    10 | 2,399,650.00 | 96,375.80 | 2,359,537.00 | 53,243.60 | -1.67
    20 | 2,410,480.00 | 89,988.00 | 2,433,580.00 | 91,121.20 | 0.96
    40 | 2.41E+06 | 121811 | 2.39E+06 | 131525 | **-0.96**
    80 | 2.40E+06 | 134503 | 2.39E+06 | 108799 | **-0.78**
    
    - stress test: `python3 tools/db_crashtest.py blackbox --charge_file_metadata=1  --cache_size=1` killed as normal
    
    Reviewed By: ajkr
    
    Differential Revision: D36055583
    
    Pulled By: hx235
    
    fbshipit-source-id: b60eab94707103cb1322cf815f05810ef0232625
    d665afdb
no_batched_ops_stress.cc 36.9 KB