• P
    Remove flaky, redundant, and dubious DBTest.SparseMerge (#7800) · a727efca
    Peter Dillinger 提交于
    Summary:
    This test would occasionally fail like this:
    
        WARNING: c:\users\circleci\project\db\db_test.cc(1343): error: Expected:
        (dbfull()->TEST_MaxNextLevelOverlappingBytes(handles_[1])) <= (20 * 1048576), actual: 33501540 vs 20971520
    
    And being a super old test, it's not structured in a sound way. And it appears that DBTest2.MaxCompactionBytesTest is a better test of what SparseMerge was intended to test. In fact, SparseMerge fails if I set
    
        options.max_compaction_bytes = options.target_file_size_base * 1000;
    
    Thus, we are removing this negative-value test.
    
    Pull Request resolved: https://github.com/facebook/rocksdb/pull/7800
    
    Test Plan: Q.E.D.
    
    Reviewed By: ajkr
    
    Differential Revision: D25693366
    
    Pulled By: pdillinger
    
    fbshipit-source-id: 9da07d4dce0559547fc938b2163a2015e956c548
    a727efca
db_test.cc 224.4 KB