• P
    Improve support for valgrind error on reachable (#8503) · a53d6d25
    Peter Dillinger 提交于
    Summary:
    MyRocks apparently uses valgrind to check for unreachable
    unfreed data, which is stricter than our valgrind checks. Internal ref:
    D29257815
    
    This patch adds valgrind support to STATIC_AVOID_DESTRUCTION so that it's
    not reported with those stricter checks.
    
    Pull Request resolved: https://github.com/facebook/rocksdb/pull/8503
    
    Test Plan:
    make valgrind_test
    Also, with modified VALGRIND_OPTS (see Makefile), more kinds of
    failures seen before than after this commit.
    
    Reviewed By: ajkr, yizhang82
    
    Differential Revision: D29597784
    
    Pulled By: pdillinger
    
    fbshipit-source-id: 360de157a176aec4d1be99ca20d160ecd47c0873
    a53d6d25
Makefile 88.2 KB