• M
    WriteUnPrepared Txn: Disable seek to snapshot optimization (#3955) · a16e00b7
    Manuel Ung 提交于
    Summary:
    This is implemented by extending ReadCallback with another function `MaxUnpreparedSequenceNumber` which returns the largest visible sequence number for the current transaction, if there is uncommitted data written to DB. Otherwise, it returns zero, indicating no uncommitted data.
    
    There are the places where reads had to be modified.
    - Get and Seek/Next was just updated to seek to max(snapshot_seq, MaxUnpreparedSequenceNumber()) instead, and iterate until a key was visible.
    - Prev did not need need updates since it did not use the Seek to sequence number optimization. Assuming that locks were held when writing unprepared keys, and ValidateSnapshot runs, there should only be committed keys and unprepared keys of the current transaction, all of which are visible. Prev will simply iterate to get the last visible key.
    - Reseeking to skip keys optimization was also disabled for write unprepared, since it's possible to hit the max_skip condition even while reseeking. There needs to be some way to resolve infinite looping in this case.
    Closes https://github.com/facebook/rocksdb/pull/3955
    
    Differential Revision: D8286688
    
    Pulled By: lth
    
    fbshipit-source-id: 25e42f47fdeb5f7accea0f4fd350ef35198caafe
    a16e00b7
db_iter.cc 53.8 KB