• M
    Adding pin_l0_filter_and_index_blocks_in_cache feature and related fixes. · 9b519875
    Marton Trencseni 提交于
    Summary:
    When a block based table file is opened, if prefetch_index_and_filter is true, it will prefetch the index and filter blocks, putting them into the block cache.
    What this feature adds: when a L0 block based table file is opened, if pin_l0_filter_and_index_blocks_in_cache is true in the options (and prefetch_index_and_filter is true), then the filter and index blocks aren't released back to the block cache at the end of BlockBasedTableReader::Open(). Instead the table reader takes ownership of them, hence pinning them, ie. the LRU cache will never push them out. Meanwhile in the table reader, further accesses will not hit the block cache, thus avoiding lock contention.
    
    Test Plan:
    'export TEST_TMPDIR=/dev/shm/ && DISABLE_JEMALLOC=1 OPT=-g make all valgrind_check -j32' is OK.
    I didn't run the Java tests, I don't have Java set up on my devserver.
    
    Reviewers: sdong
    
    Reviewed By: sdong
    
    Subscribers: andrewkr, dhruba
    
    Differential Revision: https://reviews.facebook.net/D56133
    9b519875
c.cc 70.4 KB