• P
    Real fix for race in backup custom checksum checking (#7309) · 9aad24da
    Peter Dillinger 提交于
    Summary:
    This is a "real" fix for the issue worked around in https://github.com/facebook/rocksdb/issues/7294.
    To get DB checksum info for live files, we now read the manifest file
    that will become part of the checkpoint/backup. This requires a little
    extra handling in taking a custom checkpoint, including only reading the
    manifest file up to the size prescribed by the checkpoint.
    
    This moves GetFileChecksumsFromManifest from backup code to
    file_checksum_helper.{h,cc} and removes apparently unnecessary checking
    related to column families.
    
    Updated HISTORY.md and warned potential future users of
    DB::GetLiveFilesChecksumInfo()
    
    Pull Request resolved: https://github.com/facebook/rocksdb/pull/7309
    
    Test Plan: updated unit test, before and after
    
    Reviewed By: ajkr
    
    Differential Revision: D23311994
    
    Pulled By: pdillinger
    
    fbshipit-source-id: 741e30a2dc1830e8208f7648fcc8c5f000d4e2d5
    9aad24da
checkpoint_impl.h 3.3 KB