• V
    Persistent globally unique DB ID in manifest (#5725) · 979fbdc6
    Vijay Nadimpalli 提交于
    Summary:
    Each DB has a globally unique ID. A DB can be physically copied around, or backed-up and restored, and the users should be identify the same DB. This unique ID right now is stored as plain text in file IDENTITY under the DB directory. This approach introduces at least two problems: (1) the file is not checksumed; (2) the source of truth of a DB is the manifest file, which can be copied separately from IDENTITY file, causing the DB ID to be wrong.
    The goal of this PR is solve this problem by moving the  DB ID to manifest. To begin with we will write to both identity file and manifest. Write to Manifest is controlled via the flag write_dbid_to_manifest in Options and default is false.
    Pull Request resolved: https://github.com/facebook/rocksdb/pull/5725
    
    Test Plan: Added unit tests.
    
    Differential Revision: D16963840
    
    Pulled By: vjnadimpalli
    
    fbshipit-source-id: 8a86a4c8c82c716003c40fd6b9d2d758030d92e9
    979fbdc6
options_helper.cc 91.7 KB