• I
    [RocksDB] [Column Family] Interface proposal · 9385a524
    Igor Canadi 提交于
    Summary:
    <This diff is for Column Family branch>
    
    Sharing some of the work I've done so far. This diff compiles and passes the tests.
    
    The biggest change is in options.h - I broke down Options into two parts - DBOptions and ColumnFamilyOptions. DBOptions is DB-specific (env, create_if_missing, block_cache, etc.) and ColumnFamilyOptions is column family-specific (all compaction options, compresion options, etc.). Note that this does not break backwards compatibility at all.
    
    Further, I created DBWithColumnFamily which inherits DB interface and adds new functions with column family support. Clients can transparently switch to DBWithColumnFamily and it will not break their backwards compatibility.
    There are few methods worth checking out: ListColumnFamilies(), MultiNewIterator(), MultiGet() and GetSnapshot(). [GetSnapshot() returns the snapshot across all column families for now - I think that's what we agreed on]
    
    Finally, I made small changes to WriteBatch so we are able to atomically insert data across column families.
    
    Please provide feedback.
    
    Test Plan: make check works, the code is backward compatible
    
    Reviewers: dhruba, haobo, sdong, kailiu, emayanke
    
    CC: leveldb
    
    Differential Revision: https://reviews.facebook.net/D14445
    9385a524
db_impl_readonly.cc 2.9 KB